From patchwork Sat Jan 30 16:55:59 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Curtin X-Patchwork-Id: 8171731 Return-Path: X-Original-To: patchwork-platform-driver-x86@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 28B519F6DA for ; Sat, 30 Jan 2016 16:56:23 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 40C0A20396 for ; Sat, 30 Jan 2016 16:56:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3987C20395 for ; Sat, 30 Jan 2016 16:56:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932163AbcA3Q4C (ORCPT ); Sat, 30 Jan 2016 11:56:02 -0500 Received: from mail-wm0-f48.google.com ([74.125.82.48]:37806 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932126AbcA3Q4A (ORCPT ); Sat, 30 Jan 2016 11:56:00 -0500 Received: by mail-wm0-f48.google.com with SMTP id l66so18487090wml.0; Sat, 30 Jan 2016 08:56:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=SgNptPSYNFmXo1mfw4T/U+O7oqtHlzcMG3Ux6mql2pM=; b=Mxj+NnmI1b2X/c5V9LbjAjLzMZk8AjshrlkqGLPSoFH8neg32t+ToQaUaAoWzZwm6N DQKsEDhCHguHBzazMh47LrfHFNHKbGCwgxOUFUDyfEh8Ek9ByWdjXrVRAv8cA7Eh1zvb Ewa1ZjDxQDawye7EPyBOhmhxTpjI/cWYXtz1oAMkRtCeZzFprWEJHZ1pGngUeZcx3Lnu 04/QBkdT1uzMQkweeTNWSuVlsTfD9so/c0cmK2jfz0C7pCuC16RQL7ajq+db0S8ghBwx 0VGYW411a1HXmbGs+2q4wULHsoQqgITyrbPF4K88D7SyDNif+Fi3FksOPLbspTdISD4X S5Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=SgNptPSYNFmXo1mfw4T/U+O7oqtHlzcMG3Ux6mql2pM=; b=M9KSL7PUM0FIuB24zGLNxKrp4jF3ZmPrruI96qYU8zwfEAGBEhCvrwjiRlPYSVZxTK jKwrvHR8kH+ruYdx7B5RN3G1go2sxMGTL2rxZPY7RUOjKLIHeNf+izUllX4BwZoadGnb G0kaVXgA8O5lmti39jgfRGfA61X854OFIe5QqHXTRgOJT2iAFviZ9QUHh9dghtBWEwuZ rr7+wlLFJ4mcCP7/8LkhhKsXbNjuCFwgOf0nF4kAbHnpspxRDwOPGzzNah3C4clEt//X QjTaFg/r8aFu1mzAUBmJaO2uq3j4xw2uxvH0RE0KUiD2QxpAwS5focqy/GZF6YnQHtbe IuKQ== X-Gm-Message-State: AG10YOSRIXIa3bILDCcWKQi0cMQC4ABGWJ5eJ0traT66QvkafLAPcDWG6bWnlnD8mWAQJUDXD+YK40C+tliBZw== MIME-Version: 1.0 X-Received: by 10.194.161.166 with SMTP id xt6mr15597488wjb.98.1454172959345; Sat, 30 Jan 2016 08:55:59 -0800 (PST) Received: by 10.27.217.211 with HTTP; Sat, 30 Jan 2016 08:55:59 -0800 (PST) In-Reply-To: <20160130122045.GA14919@khazad-dum.debian.net> References: <1453937211.10099.31.camel@perches.com> <20160130122045.GA14919@khazad-dum.debian.net> Date: Sat, 30 Jan 2016 16:55:59 +0000 Message-ID: Subject: Re: [PATCH] Remove ambiguous logging for "Unsupported brightness interface" From: Eric Curtin To: Henrique de Moraes Holschuh Cc: Joe Perches , platform-driver-x86@vger.kernel.org, Kernel development list , Darren Hart , ibm-acpi-devel@lists.sourceforge.net Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 30 January 2016 at 12:20, Henrique de Moraes Holschuh wrote: > On Wed, 27 Jan 2016, Joe Perches wrote: >> On Wed, 2016-01-27 at 22:14 +0000, Eric Curtin wrote: >> > Message gets logged on machines that are well supported. >> > >> > Signed-off-by: Eric Curtin >> > --- >> > drivers/platform/x86/thinkpad_acpi.c | 1 - >> > 1 file changed, 1 deletion(-) >> > >> > diff --git a/drivers/platform/x86/thinkpad_acpi.c >> > b/drivers/platform/x86/thinkpad_acpi.c >> > index a268a7a..4eb41aa 100644 >> > --- a/drivers/platform/x86/thinkpad_acpi.c >> > +++ b/drivers/platform/x86/thinkpad_acpi.c >> > @@ -6661,7 +6661,6 @@ static void __init >> > tpacpi_detect_brightness_capabilities(void) >> > pr_info("detected a 8-level brightness capable >> > ThinkPad\n"); >> > break; >> > default: >> > - pr_info("Unsupported brightness interface\n"); >> > tp_features.bright_unkfw = 1; >> > bright_maxlvl = b - 1; >> > } >> >> Perhaps this should be something like this instead: >> --- >> drivers/platform/x86/thinkpad_acpi.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c >> index a268a7a..bd12c71 100644 >> --- a/drivers/platform/x86/thinkpad_acpi.c >> +++ b/drivers/platform/x86/thinkpad_acpi.c >> @@ -6653,18 +6653,16 @@ static void __init tpacpi_detect_brightness_capabilities(void) >> switch (b) { >> case 16: >> bright_maxlvl = 15; >> - pr_info("detected a 16-level brightness capable ThinkPad\n"); >> break; >> case 8: >> case 0: >> bright_maxlvl = 7; >> - pr_info("detected a 8-level brightness capable ThinkPad\n"); >> break; >> default: >> - pr_info("Unsupported brightness interface\n"); >> tp_features.bright_unkfw = 1; >> bright_maxlvl = b - 1; >> } >> + pr_info("detected %u brightness levels\n", bright_maxlvl + 1); >> } > > This can be made pr_debug, since we're touching it... > > -- > "One disk to rule them all, One disk to find them. One disk to bring > them all and in the darkness grind them. In the Land of Redmond > where the shadows lie." -- The Silicon Valley Tarot > Henrique Holschuh "Unsupported brightness interface" message gets logged on machines that are well supported. Signed-off-by: Eric Curtin Acked-by: Henrique de Moraes Holschuh --- drivers/platform/x86/thinkpad_acpi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) static int __init brightness_init(struct ibm_init_struct *iibm) diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c index a268a7a..e305ab5 100644 --- a/drivers/platform/x86/thinkpad_acpi.c +++ b/drivers/platform/x86/thinkpad_acpi.c @@ -6653,18 +6653,16 @@ static void __init tpacpi_detect_brightness_capabilities(void) switch (b) { case 16: bright_maxlvl = 15; - pr_info("detected a 16-level brightness capable ThinkPad\n"); break; case 8: case 0: bright_maxlvl = 7; - pr_info("detected a 8-level brightness capable ThinkPad\n"); break; default: - pr_info("Unsupported brightness interface\n"); tp_features.bright_unkfw = 1; bright_maxlvl = b - 1; } + pr_debug("detected %u brightness levels\n", bright_maxlvl + 1); }