| Message ID | CANpvso6S3jH0qYoPRmoNAc7sCsRd4UkosfzXFBAuLLUuZaPKCw@mail.gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
On 16 January 2016 at 23:43, Eric Curtin <ericcurtin17@gmail.com> wrote: > Message gets logged on machines that are well supported. > Fixed one checkpatch.pl ERROR also. > > Signed-off-by: Eric Curtin <ericcurtin17@gmail.com> > --- > drivers/platform/x86/thinkpad_acpi.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/platform/x86/thinkpad_acpi.c > b/drivers/platform/x86/thinkpad_acpi.c > index 0bed473..b149dec 100644 > --- a/drivers/platform/x86/thinkpad_acpi.c > +++ b/drivers/platform/x86/thinkpad_acpi.c > @@ -6434,7 +6434,7 @@ static const struct tpacpi_quirk > brightness_quirk_table[] __initconst = { > */ > static void __init tpacpi_detect_brightness_capabilities(void) > { > - unsigned int b; > + const unsigned int b = tpacpi_check_std_acpi_brightness_support(); > > vdbg_printk(TPACPI_DBG_INIT, > "detecting firmware brightness interface capabilities\n"); > @@ -6447,7 +6447,6 @@ static void __init > tpacpi_detect_brightness_capabilities(void) > * Lenovo Vista BIOS to ACPI brightness mode even if we are not > * going to publish a backlight interface > */ > - b = tpacpi_check_std_acpi_brightness_support(); > switch (b) { > case 16: > bright_maxlvl = 15; > @@ -6459,7 +6458,6 @@ static void __init > tpacpi_detect_brightness_capabilities(void) > pr_info("detected a 8-level brightness capable ThinkPad\n"); > break; > default: > - pr_info("Unsupported brightness interface\n"); > tp_features.bright_unkfw = 1; > bright_maxlvl = b - 1; > } > @@ -7440,7 +7438,7 @@ static struct ibm_struct volume_driver_data = { > > #define alsa_card NULL > > -static void inline volume_alsa_notify_change(void) > +static inline void volume_alsa_notify_change(void) > { > } > > -- > 2.5.0 Hi Guys, Sorry to be bugging you. Is this going to be accepted or not? Just a poke! :) -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Jan 21, 2016, at 09:18, Eric Curtin wrote: > On 16 January 2016 at 23:43, Eric Curtin <ericcurtin17@gmail.com> wrote: > > Message gets logged on machines that are well supported. > > Fixed one checkpatch.pl ERROR also. > > > > Signed-off-by: Eric Curtin <ericcurtin17@gmail.com> > > --- > > drivers/platform/x86/thinkpad_acpi.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/platform/x86/thinkpad_acpi.c > > b/drivers/platform/x86/thinkpad_acpi.c > > index 0bed473..b149dec 100644 > > --- a/drivers/platform/x86/thinkpad_acpi.c > > +++ b/drivers/platform/x86/thinkpad_acpi.c > > @@ -6434,7 +6434,7 @@ static const struct tpacpi_quirk > > brightness_quirk_table[] __initconst = { > > */ > > static void __init tpacpi_detect_brightness_capabilities(void) > > { > > - unsigned int b; > > + const unsigned int b = tpacpi_check_std_acpi_brightness_support(); This unrelated change can have side-effects, and I didn't stop to look at the code yet to know if it is desired. Regardless, it should be in a separate patch anyway as it has nothing to do with the removal of the log message, so please drop it.
On 23 January 2016 at 00:28, Eric Curtin <ericcurtin17@gmail.com> wrote: > Message gets logged on machines that are well supported. > > Signed-off-by: Eric Curtin <ericcurtin17@gmail.com> > --- > drivers/platform/x86/thinkpad_acpi.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/platform/x86/thinkpad_acpi.c > b/drivers/platform/x86/thinkpad_acpi.c > index a268a7a..4eb41aa 100644 > --- a/drivers/platform/x86/thinkpad_acpi.c > +++ b/drivers/platform/x86/thinkpad_acpi.c > @@ -6661,7 +6661,6 @@ static void __init > tpacpi_detect_brightness_capabilities(void) > pr_info("detected a 8-level brightness capable ThinkPad\n"); > break; > default: > - pr_info("Unsupported brightness interface\n"); > tp_features.bright_unkfw = 1; > bright_maxlvl = b - 1; > } > -- > 2.5.0 > Hi Guys, This patch doesn't appear on any of the Linux kernel archive sites. Could somebody enlighten me why this is so? -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c index 0bed473..b149dec 100644 --- a/drivers/platform/x86/thinkpad_acpi.c +++ b/drivers/platform/x86/thinkpad_acpi.c @@ -6434,7 +6434,7 @@ static const struct tpacpi_quirk brightness_quirk_table[] __initconst = { */ static void __init tpacpi_detect_brightness_capabilities(void) { - unsigned int b; + const unsigned int b = tpacpi_check_std_acpi_brightness_support(); vdbg_printk(TPACPI_DBG_INIT,
Message gets logged on machines that are well supported. Fixed one checkpatch.pl ERROR also. Signed-off-by: Eric Curtin <ericcurtin17@gmail.com> --- drivers/platform/x86/thinkpad_acpi.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) "detecting firmware brightness interface capabilities\n"); @@ -6447,7 +6447,6 @@ static void __init tpacpi_detect_brightness_capabilities(void) * Lenovo Vista BIOS to ACPI brightness mode even if we are not * going to publish a backlight interface */ - b = tpacpi_check_std_acpi_brightness_support(); switch (b) { case 16: bright_maxlvl = 15; @@ -6459,7 +6458,6 @@ static void __init tpacpi_detect_brightness_capabilities(void) pr_info("detected a 8-level brightness capable ThinkPad\n"); break; default: - pr_info("Unsupported brightness interface\n"); tp_features.bright_unkfw = 1; bright_maxlvl = b - 1; } @@ -7440,7 +7438,7 @@ static struct ibm_struct volume_driver_data = { #define alsa_card NULL -static void inline volume_alsa_notify_change(void) +static inline void volume_alsa_notify_change(void) { }