[0/8] off-by-one and NULL pointer accesses detected by static analysis

Message

Liam Merwick Aug. 30, 2018, 3:47 p.m. UTC

Below are a number of fixes to some off-by-one, read outside array bounds, and
NULL pointer accesses detected by an internal Oracle static analysis tool (Parfait).
https://labs.oracle.com/pls/apex/f?p=labs:49:::::P49_PROJECT_ID:13

I have also included a patch to add a command-line option to configure to
select if AVX2 is used or not (keeping the existing behaviour by default).
My motivation was avoiding an issue with the static analysis tool but NetSpectre
was announced as I was working on this and I felt it may have more general uses.


Liam Merwick (8):
  configure: Provide option to explicitly disable AVX2
  job: Fix off-by-one accesses to JobSTT and JobVerbTable
  block: Null pointer dereference in blk_root_get_parent_desc()
  qemu-img: potential Null pointer deref in img_commit()
  block: Fix potential Null pointer dereferences in vvfat.c
  block: dump_qlist() may dereference a Null pointer
  io: file descriptor not initialized in qio_channel_command_new_spawn()
  qcow2: Read outside array bounds in qcow2_pre_write_overlap_check()

 block/block-backend.c    |  2 +-
 block/qcow2-refcount.c   | 17 ++++++++-------
 block/vvfat.c            | 56 ++++++++++++++++++++++++++++++++++++++++++++++++
 configure                | 11 ++++++++--
 include/qapi/qmp/qlist.h |  6 ++++++
 io/channel-command.c     |  4 ++--
 job.c                    |  4 ++--
 qemu-img.c               |  3 +++
 8 files changed, 88 insertions(+), 15 deletions(-)