From patchwork Mon Mar 11 10:29:04 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yuval Shaia X-Patchwork-Id: 10847267 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 63C6517EF for ; Mon, 11 Mar 2019 10:46:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4F8B228387 for ; Mon, 11 Mar 2019 10:46:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 42E9E285BD; Mon, 11 Mar 2019 10:46:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D0A9628387 for ; Mon, 11 Mar 2019 10:46:40 +0000 (UTC) Received: from localhost ([127.0.0.1]:59380 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3IS8-0004m9-3w for patchwork-qemu-devel@patchwork.kernel.org; Mon, 11 Mar 2019 06:46:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36314) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3IBQ-0007Xj-DS for qemu-devel@nongnu.org; Mon, 11 Mar 2019 06:29:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h3IBO-0000tm-TN for qemu-devel@nongnu.org; Mon, 11 Mar 2019 06:29:24 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:47600) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h3IBO-0000sS-Gy for qemu-devel@nongnu.org; Mon, 11 Mar 2019 06:29:22 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x2BATJZ2154235; Mon, 11 Mar 2019 10:29:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : subject : date : message-id; s=corp-2018-07-02; bh=YN5AbMQBs6ZttSPHYuBa3jU3G4AJeRNwzvQsNjYkkPA=; b=Qn+rLDx2U7Xa7xn+lXCP79jIM0rJaBXqiVdlrBlYIEyCmC4jsPRisOWlz2aorKdz11H5 aB22XoogY5GN0AT2KDsNJS3sD5g8TD2HYR1P1O1T4dxsEUrw6k+AM+Nki0cpypNKZJUN CsP+3VoaOdxJ5RjUMr8BGzz5cf6YkipS+WZq2cfJ/DtUXIaB2zzBNrQX8qOie+m+KDqj 2mwL7qw5k46sg1EkXdH9Y9IU0vfhrfl+vF3AR+sutolCFfi7BbBYyfjdbxbI1o+xaxn7 g0VhdVoO1P/CuFoTIIAu3vyRuSlgy+D7MnEuhavMh/CyvIhhmOCGQxe38ihpu1qISYij KA== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp2120.oracle.com with ESMTP id 2r464r5fdy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 11 Mar 2019 10:29:18 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id x2BATHvZ028306 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 11 Mar 2019 10:29:18 GMT Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x2BATHik009381; Mon, 11 Mar 2019 10:29:17 GMT Received: from ca-dev66.localdomain (/10.68.48.69) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 11 Mar 2019 03:29:17 -0700 From: Yuval Shaia To: dgilbert@redhat.com, yuval.shaia@oracle.com, marcel.apfelbaum@gmail.com, qemu-devel@nongnu.org, armbru@redhat.com Date: Mon, 11 Mar 2019 03:29:04 -0700 Message-Id: <1552300155-25216-1-git-send-email-yuval.shaia@oracle.com> X-Mailer: git-send-email 1.8.3.1 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9191 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1903110079 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 156.151.31.85 Subject: [Qemu-devel] [PATCH v6 00/11] Misc fixes to pvrdma device X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Hi, Please review the following patch-set which consist of cosmetics fixes to device's user interface (traces, error_report and monitor) and some bug fixes. Thanks Markus, Eric, Marcel and David for your review. Review is needed for patches 4 and 11 (new) v0 -> v1: * Explain why device attributes are exposed only in HMP interface. * Squash the 3 patches related to HMP interface into one. * Make monitor dump function simple. * Make HMP interface available only if pvrdma is included (detected by build robot). * Remove patch 03/10 ("Warn when too many consecutive poll CQ triggered on an empty CQ) and add the two counters to patch 0/7 (monitor). * Add Marcel's R-Bs. * Add mutex protection to cqe_ctx list. * Add two new patches. v1 -> v2: * Rename locked-lists to protected-lists in patch 2 and patch 6. * Add Marcel's R-Bs. v2 -> v3: * Address some 32 bit host compilation issues. v3 -> v4: * Per suggestion from Markus rebase HMP report on object_child_foreach_recursive(). * Strip off David's r-b from HMP patch (#4) because of the above. v4 -> v5: * Accept comments from Marcus and David * Rename RDMA device interface * Split patch #4 into 2 patches * Add some more counters * Add Marcus and David ack-by to hmp patch v5 -> v6: * Add some more error reports in patch #1 * New patch to fix an issue with call to object_get_typename Yuval Shaia (11): hw/rdma: Switch to generic error reporting way hw/rdma: Introduce protected qlist hw/rdma: Protect against concurrent execution of poll_cq hw/pvrdma: Collect debugging statistics {hmp, hw/pvrdma}: Expose device internals via monitor interface hw/rdma: Free all MAD receive buffers when device is closed hw/rdma: Free all receive buffers when QP is destroyed hw/pvrdma: Delete unneeded function argument hw/pvrdma: Delete pvrdma_exit function hw/pvrdma: Unregister from shutdown notifier when device goes down hw/pvrdma: Provide correct value to object_get_typename hmp-commands-info.hx | 14 ++ hmp.c | 27 +++ hmp.h | 1 + hw/rdma/Makefile.objs | 2 +- hw/rdma/rdma.c | 30 +++ hw/rdma/rdma_backend.c | 501 +++++++++++++++++++++--------------------- hw/rdma/rdma_backend.h | 7 +- hw/rdma/rdma_backend_defs.h | 10 +- hw/rdma/rdma_rm.c | 196 ++++++++++------- hw/rdma/rdma_rm.h | 11 +- hw/rdma/rdma_rm_defs.h | 28 ++- hw/rdma/rdma_utils.c | 83 ++++++- hw/rdma/rdma_utils.h | 61 +++-- hw/rdma/trace-events | 32 ++- hw/rdma/vmw/pvrdma.h | 12 +- hw/rdma/vmw/pvrdma_cmd.c | 115 +++------- hw/rdma/vmw/pvrdma_dev_ring.c | 26 +-- hw/rdma/vmw/pvrdma_main.c | 182 ++++++++------- hw/rdma/vmw/pvrdma_qp_ops.c | 52 ++--- hw/rdma/vmw/trace-events | 16 +- include/hw/rdma/rdma.h | 40 ++++ 21 files changed, 817 insertions(+), 629 deletions(-) create mode 100644 hw/rdma/rdma.c create mode 100644 include/hw/rdma/rdma.h