mbox series

[v3,0/6] iotests: Dump QCOW2 dirty bitmaps metadata

Message ID 1591019293-211155-1-git-send-email-andrey.shinkevich@virtuozzo.com (mailing list archive)
Headers show
Series iotests: Dump QCOW2 dirty bitmaps metadata | expand

Message

Andrey Shinkevich June 1, 2020, 1:48 p.m. UTC
Add dirty bitmap information to QCOW2 metadata dump in qcow2.py script.

v3:
  01: JSON format output possibility added.

v2:
  01: Refactoring of the Python code in the script qcow2.py.
      New methods were added. The bitmap dictionary was instantiated.
      The all of bitmaps information is read completely before
      printing the dictionary.
  02: The outputs of the tests 031, 036 and 061 were modified.

Andrey Shinkevich (6):
  iotests: Add extension names to qcow2.py dump
  iotests: move check for printable data to QcowHeaderExtension class
  iotests: dump bitmap extension data with qcow2.py
  iotests: Dump bitmap directory info with qcow2.py
  iotests: Dump bitmap table entries serialized in QCOW2 image
  iotests: Dump QCOW2 image metadata in JSON format with qcow2.py

 tests/qemu-iotests/031.out  |  22 +--
 tests/qemu-iotests/036.out  |   4 +-
 tests/qemu-iotests/061.out  |  18 +--
 tests/qemu-iotests/qcow2.py | 338 ++++++++++++++++++++++++++++++++++++++++++--
 4 files changed, 346 insertions(+), 36 deletions(-)

Comments

Eric Blake June 1, 2020, 9:46 p.m. UTC | #1
On 6/1/20 8:48 AM, Andrey Shinkevich wrote:
> Add dirty bitmap information to QCOW2 metadata dump in qcow2.py script.
> 
> v3:
>    01: JSON format output possibility added.

Also, you split it into a series.  Thanks; this makes it easier to 
review each step :)

> 
> v2:
>    01: Refactoring of the Python code in the script qcow2.py.
>        New methods were added. The bitmap dictionary was instantiated.
>        The all of bitmaps information is read completely before
>        printing the dictionary.
>    02: The outputs of the tests 031, 036 and 061 were modified.
> 
> Andrey Shinkevich (6):
>    iotests: Add extension names to qcow2.py dump
>    iotests: move check for printable data to QcowHeaderExtension class
>    iotests: dump bitmap extension data with qcow2.py
>    iotests: Dump bitmap directory info with qcow2.py
>    iotests: Dump bitmap table entries serialized in QCOW2 image
>    iotests: Dump QCOW2 image metadata in JSON format with qcow2.py
> 
>   tests/qemu-iotests/031.out  |  22 +--
>   tests/qemu-iotests/036.out  |   4 +-
>   tests/qemu-iotests/061.out  |  18 +--
>   tests/qemu-iotests/qcow2.py | 338 ++++++++++++++++++++++++++++++++++++++++++--
>   4 files changed, 346 insertions(+), 36 deletions(-)
>
Andrey Shinkevich June 4, 2020, 7:54 a.m. UTC | #2
Thank you very much dear colleagues for your collaboration. Your reviews comments are well noted.

Andrey