From patchwork Tue Jul 24 22:17:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leonid Bloch X-Patchwork-Id: 10543249 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 93D2914BC for ; Tue, 24 Jul 2018 22:20:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7ED73295C6 for ; Tue, 24 Jul 2018 22:20:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 721C7295D0; Tue, 24 Jul 2018 22:20:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C286F295C6 for ; Tue, 24 Jul 2018 22:20:15 +0000 (UTC) Received: from localhost ([::1]:42802 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fi5f2-00083k-Tf for patchwork-qemu-devel@patchwork.kernel.org; Tue, 24 Jul 2018 18:20:04 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45093) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fi5df-0006hb-Sv for qemu-devel@nongnu.org; Tue, 24 Jul 2018 18:18:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fi5dc-000772-Mq for qemu-devel@nongnu.org; Tue, 24 Jul 2018 18:18:39 -0400 Received: from mail-bn3nam01on0096.outbound.protection.outlook.com ([104.47.33.96]:19641 helo=NAM01-BN3-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fi5dc-00075Z-EC; Tue, 24 Jul 2018 18:18:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janustech.onmicrosoft.com; s=selector1-janustech-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WCfWQh91fc52ihDVXx3XVNQf7p5SzZEvZo/rUYNx2Jc=; b=aYNBOf9VtUpWwjB2imixkbXKpZEvIe7Z6GjyC7tdEXPYv+44ShsdiWh5cL+7TBwy0BZXQWPI0mYNrECodWrtQP1B15sAZHGjFnV0zQ/iODA8FtoreLDDEpr3G3HT/sKstp3oi0woqHZibUQMoveaTKyLxOXmNcGne9ObeXG/69s= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=lbloch@janustech.com; Received: from Jupiter.local (141.226.29.227) by BN3PR07MB2612.namprd07.prod.outlook.com (2a01:111:e400:c5f0::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.20; Tue, 24 Jul 2018 22:18:30 +0000 From: Leonid Bloch To: qemu-devel@nongnu.org Date: Wed, 25 Jul 2018 01:17:46 +0300 Message-Id: <20180724221750.16282-1-lbloch@janustech.com> X-Mailer: git-send-email 2.14.1 MIME-Version: 1.0 X-Originating-IP: [141.226.29.227] X-ClientProxiedBy: HE1PR05CA0128.eurprd05.prod.outlook.com (2603:10a6:7:28::15) To BN3PR07MB2612.namprd07.prod.outlook.com (2a01:111:e400:c5f0::16) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 49a2f0dc-244a-4bb4-c5e3-08d5f1b36454 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(7021125)(8989117)(5600073)(711020)(4534165)(7022125)(4603075)(4627221)(201702281549075)(8990107)(7048125)(7024125)(7027125)(7028125)(7023125)(2017052603328)(7153060)(7193020); SRVR:BN3PR07MB2612; X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2612; 3:o9uXZf8M8bwtFp+CkgZ7k0ryARNHaljLT/gk2vj5SDISkPYJCSHz2sHkNw4F8SgckHsUL/ePAbsNqL6vTQbD1+C5sCahTUAQBd+GTPzqZ/zud0nx1o14868Mv0Mhu9Cp9iX5ytSaLFN56TcwAa6/hZFWlwtnikZr7eg32VNw05lrv1A7X1yDUwWT2VpgtfSeRF7lKAvJkkZQnw7ZEXHKcrImt6gJJv5Qm9jIrCz693CGPmMaE/xZVDXF5TGlE40l; 25:g9SHGRfXGp0KOkSV8TSsoWSkBPD+jotdalqtBUsOdv4Rm6iy1jAlOjLbgdmvlMPYeY27wCTrarLCeTrZj37cX32Y6gB+JSMZfw8/BPetsUkm35uP6Xykja2bx5Fgm2D4VxJA3u13abNW+bhezgrNolSvPwb4Q0KOWUbm99EWZih3vuQ/mIyQ5vtLUi+eQ6OOg6yA1aHll5RWkx1xNjQxCEBNi4AJ2vLnvtEoQqN2hq+RGogru7IexnJ6ug+htD+4CFJ1zkNw9nAlO/pIdyHO/KOXvLRECm7UgFL+oWJUAgLnRHGM8gn5QTfxRs0ASVMQ6AhbsiJEHwDdwv20HlDJyQ==; 31:bHDf0K935n6l4MJ3njdlENfQAa3jn/KXSDsRO8UESzu8dHSKrcbVcBR/PhhBIWhiqOn/CcMlXOLlV73gANbCZYrhbmVsF2QneyZZDJkgq0NFuCWZyQhnCk0fkiTElKdHP4sia4qdiDxaaKwl9bNxN8rmqeyH9A6JJ0jxh8ziVJIv/9cD4Qk5h20nngA5zPavtNdRKRTSB8kt8v2qIiZikYNkYgRZ2yxJ0+kHIMqHdhY= X-MS-TrafficTypeDiagnostic: BN3PR07MB2612: X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(8121501046)(5005006)(3231311)(944501410)(52105095)(93006095)(93001095)(10201501046)(3002001)(149027)(150027)(6041310)(2016111802025)(20161123560045)(20161123562045)(20161123558120)(20161123564045)(6072148)(6043046)(201708071742011)(7699016); SRVR:BN3PR07MB2612; BCL:0; PCL:0; RULEID:; SRVR:BN3PR07MB2612; X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2612; 4:JO7wSkMljgAHMpRw1Saa6liX61JWyIux5IT3HpVcnttFb2qNm+w49pluxDeEs6jbVWxz/zhM7I0gLAYQFMpzp9MPzBN/ihQx+IPDy767plpv4BK9eVhV4cWIYzihmiqr8zJB4E4UHPvP+I4zMM0Alb61VamUGybaOk5pvh4gHxLmXEU9lnG10w/p/BOXzi0B7NWJwEJmxHldeDQ5luh+h8T0p7dZ30DzLJ8Ii5TjgTM7YeCvh9yw3+d1M7E3Qf1rMq8GQUVwafw89Z3F/gRzdg== X-Forefront-PRVS: 0743E8D0A6 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(39830400003)(396003)(346002)(366004)(136003)(376002)(199004)(189003)(68736007)(3846002)(52116002)(4326008)(51416003)(1076002)(2361001)(53936002)(54906003)(5660300001)(25786009)(8676002)(107886003)(2906002)(6486002)(6666003)(6116002)(86362001)(50466002)(48376002)(6916009)(486006)(6512007)(36756003)(2351001)(478600001)(97736004)(66066001)(305945005)(7736002)(2616005)(8936002)(956004)(476003)(47776003)(186003)(16586007)(16526019)(81156014)(26005)(316002)(6506007)(50226002)(106356001)(105586002)(81166006)(386003); DIR:OUT; SFP:1102; SCL:1; SRVR:BN3PR07MB2612; H:Jupiter.local; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: janustech.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR07MB2612; 23:Hx+DVCsESyV8/QPcOOG+N53fLElLkkNwms9RDfp30?= wDf+AjOFfGZ45E4gOxLkKHl3M1qLwtCiB4QgHsZbAokyIsBkU1OiUr0KGrp7ALUAuTAElrXu1fx7nWSNeGN9rF1a8CDky1wwmVCajd6k9Ymc1z6eRfJOHhh7CtqIocxtH96EO14L3qsdVVa83sMPPFwbcZVbgUDK55Wo2vWerFACoen4bh4lTYCHpdmECybj18NP5GIXrKnlb2GbPOKLldIxcCmjvWFirCOFazJaCp/8SgDaVkS7mx0OSHdG352WqMKSymCdsbHRZZk8DLmZld1cUZ4RP0RF7CtLSFl1XvDPh4QyTDuS0IJ0+e+JglONATwCPHhJuyfRieK14Jn6DBEMcTvDOKZkI065yLv29XDHXyOc5dtKLf+K/pKQvTt4Ob8DAuLeT3WG9tIKbR1Bu6GxP8iRKbQuaIvHgg6c2EFBijgfVYwy4x06jOlEP9Y/qbKfGWfT7MNP1h8vxTGPV8lqAi/wRSNxQOLzakOlM0IlqLYzIVioAaL0qX58cszz3u9qB6/OJ6sv+Cd9PQp+X5ySut6rDYgQeGtfipbuix5PCV+r7evCZUxkjVCDeZZUYmQqT9i3/RrSvP90XrVo4NkAuiIcUsHqfa3BOdd0drkT0a2ESQZOaxWnExbkWUpg2emffy4XFd3sCJnmVou91/y9QQGHU4Ntc14xPtjvJAtl5jWHaCyCDE/c+2sI3UEqvWRLoGVC6sn3PNreAd2LSpOnsi/Is9nfgqjs5cs81SWZSbodlSrXTzq1NauNkTsaG4mA0YgFoez1sdoABcBdOa2fUYzBrxP2gA1mwFlsjoHG0QnqxvLNwFUj0Ef6wZkCZZdZM+Puuv+mr8IdIkhBNl731PKqUh6Wvs+6FA57B/E1MOZjU35xHFrt8PZpTHL7flGpCPUdMkb575U34w0gMzfmwvo/xErPbzrPTWOjaAQe6BvOKrXyddOHqXCVLUpm1ozEIKMmewD40e/J42D2i53Bc1BmByPdOxrj7qlWZYnMlfoa82/c0DM2vhvvGVp732S6P2u8vZV6Cr3DkiZ5BIv/PgcGMF/BkM8FpBEKqFCPGVw5iNgoq6OLwsAfSwocV6a2xrwplQhRjb85czCVh/sUL2isihx9zGr3yLAW17VzPeEHLfOh0SejnsH5ps0e6BFjFWsB+jGpaxcL2enzSSn X-Microsoft-Antispam-Message-Info: Vet2+gjIdLJlIfI6n5925RjP+TB7qM844816+69Fhmxa51OV382Kp5Hx0YNg7d0m9CCwuwF4qQaV1aH8ygkTrB1ml5q4Kk1/zKawBfuVVElm8G9vUW61Ak3Qytn9M1GzSGUE2iK1znuYb7Rs2g+sgQm6+iQG25RpN5Dcp2+m5/EQnBOk++WSvbiDBOIf3t3YhkPFXVedLlyP3Tu5v7KwhoW3iYiN+hQBk8eoXDlGji0sTAamy/2toCBsoJmHxI6Ju3eAxxLUQbdU1uO1vfOF9997f4Ugi9FrdXvkahYtMKGzzYXtqz237xQmGPnqxre4W3n7xQ88Y2fHuD/owqxs8+AU9JjHeLmCqfkE01ovo9U= X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2612; 6:k+4rb5+SBeuY2YtDgHFSabdhZMPTK0XE2o9PPo7J/duphiCVRTz/bnjdy/UXQ0u7RLHpoKVWDPbdcbZWreDQoALykayyRS2NFJhLgbp+sh8TdXMaOq1vv5BOUObry+12/cXq+wncSO0cGve3qc2dbT4wq6ucZkT+SIMbWgPCQYaQwJxOtiqoQ+xKA2WfEbpwLn6f1fiKbZgx+NWZjyrEgO/mbfryQGhA5Dqiv4UntWB759xBcHZLPY1Hc8ZYPhz+LC3oPQDANncu7Wko49rKErlvZENqOOPT9NPJqIG8nC9N5Sw7g3CfidDyL5VDj3BBMCtJQ5rLON4XYqo60pW/rkx9P0B9gm+Ym0RQGtxkadhcFMy7Y1StZ13MRD9DBRKl1un0BTPFsHUiX8N1agFmZ7Xs6ijyfFEX3qm73jy5qZBePbcVmqzAdBVQ2CBHnQpjul2Y20wHbP01AjsGdyGPrA==; 5:eufLAYePZsZTMfhbwIWtAlqnW424saBjaapBvU0hkcCFNe1oinNB3aQgU9Ax7aVxJzhnhssXkNTb0VpJFjizU1IXQ+DBfub+hgKZIkTY6BQdRpuw+dAct/0QX1WsWFUp6v2gFh2w2+ilvNUTH0RaelQ5kamlH7xHuO+KPFFQuMM=; 7:xr26hrqwxkDNZMtURsKTYImsU1cqRJogGRxYXPgYlNnx7sPJtMrGzHBsWxqSTbyIGeMEhVaquC8k01EUl4jA3iO1aUEzaQITpni4yH/CeNFErS/8Gwm0v+AfOuWs9GRTZ97ak8pkGAJ/k8B8WOsk0YuEjdvtCq33lg8jqSYc3pv1UvEQ1dT9VfmaGM/MsjDiO7CiGIF47cXyiWEHsHKHdN2cnKydcytThk5m0TiaeJyNE3dCWoT1/fsaS32nABip SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: janustech.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2018 22:18:30.6793 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 49a2f0dc-244a-4bb4-c5e3-08d5f1b36454 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 34eb020e-3cf3-43a1-afeb-f5cf1310628e X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR07MB2612 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.33.96 Subject: [Qemu-devel] [PATCH v4 0/4] Introduction of l2-cache-full option for qcow2 images X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Leonid Bloch , qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP This series introduces an option to calculate and allocate automatically enough qcow2 L2 cache to cover the entire image. Using cache that covers the entire image can benefit performance, while having only a small memory overhead (just 1 MB for every 8 GB of virtual image size with the default cluster size). ------------------------- Differences from v1: 1) Documentation fixes in qapi/block-core.json and qemu-options.hx 2) Removal of the patch which was made to fix the default sizes in docs/qcow2-cache.txt - it is not needed, as the default sizes imply also default cluster sizes. 3) Documentation fixes in docs/qcow2-cache.txt, mentioning mutual exclusivity of the options. 4) Squashing the iotests patch into the main feature addition patch ------------------------- Differences from v2: 1) A separate patch for the grammar fix for 3.0 2) A separate patch for existing documentation fixes for 3.0 3) Separated back the iotests patch, because the grammar fix is separate now ------------------------- Differences from v2: 1) Grammar change commit message fix 2) Rewording the documentation more concisely 3) Squashing the l2-cache-full docs commit to the one that introduces this feature Leonid Bloch (4): qcow2: A grammar fix in conflicting cache sizing error message qcow2: Options' documentation fixes qcow2: Introduce an option for sufficient L2 cache for the entire image iotests: Add tests for the new l2-cache-full option block/qcow2.c | 37 +++++++++++++++++++++++++++++-------- block/qcow2.h | 1 + docs/qcow2-cache.txt | 18 ++++++++++++++---- qapi/block-core.json | 8 +++++++- qemu-options.hx | 14 ++++++++++---- tests/qemu-iotests/103 | 6 ++++++ tests/qemu-iotests/103.out | 4 +++- tests/qemu-iotests/137 | 2 ++ tests/qemu-iotests/137.out | 4 +++- 9 files changed, 75 insertions(+), 19 deletions(-)