From patchwork Tue Aug 7 09:16:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fam Zheng X-Patchwork-Id: 10558469 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 961F21390 for ; Tue, 7 Aug 2018 09:23:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 85D2B28D83 for ; Tue, 7 Aug 2018 09:23:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7A267293CE; Tue, 7 Aug 2018 09:23:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2A52128D83 for ; Tue, 7 Aug 2018 09:23:44 +0000 (UTC) Received: from localhost ([::1]:38070 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fmyDP-0003AE-E7 for patchwork-qemu-devel@patchwork.kernel.org; Tue, 07 Aug 2018 05:23:43 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49608) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fmy7E-0007Am-MG for qemu-devel@nongnu.org; Tue, 07 Aug 2018 05:17:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fmy7D-00078d-ST for qemu-devel@nongnu.org; Tue, 07 Aug 2018 05:17:20 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:44424 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fmy79-000759-EL; Tue, 07 Aug 2018 05:17:15 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C71F88790A; Tue, 7 Aug 2018 09:17:14 +0000 (UTC) Received: from lemon.usersys.redhat.com (ovpn-12-63.pek2.redhat.com [10.72.12.63]) by smtp.corp.redhat.com (Postfix) with ESMTP id CE4CD1C65F; Tue, 7 Aug 2018 09:17:07 +0000 (UTC) From: Fam Zheng To: qemu-devel@nongnu.org Date: Tue, 7 Aug 2018 17:16:53 +0800 Message-Id: <20180807091655.32472-1-famz@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Tue, 07 Aug 2018 09:17:14 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Tue, 07 Aug 2018 09:17:14 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'famz@redhat.com' RCPT:'' X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: [Qemu-devel] [PATCH v2 0/2] Fix aio_notify_accept() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, Fam Zheng , qemu-block@nongnu.org, Stefan Hajnoczi , lersek@redhat.com Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP v2: Implement the fix following Paolo's idea. Testing is still in progress. Calling aio_notify_accept(iothread->ctx) from main loop when it does aio_poll(iothread->ctx, false) is a bug because it may steal the event needed by aio_poll(iothread->ctx, true) in the IOThread. This can cause IOThread hanging. Fam Zheng (2): aio-posix: Don't count ctx->notifier as progress when polling aio: Do aio_notify_accept only during blocking aio_poll util/aio-posix.c | 7 ++++--- util/aio-win32.c | 3 ++- 2 files changed, 6 insertions(+), 4 deletions(-)