[v3,0/2] Fix aio_notify_accept()

Message

Fam Zheng Aug. 9, 2018, 1:22 p.m. UTC

v3: Fix commit message's bug description. [Paolo]

v2: Implement the fix following Paolo's idea.
    Testing is still in progress.

Calling aio_notify_accept(iothread->ctx) from main loop when it does
aio_poll(iothread->ctx, false) is a bug because it may steal the event needed
by aio_poll(iothread->ctx, true) in the IOThread. This can cause IOThread
hanging.

Fam Zheng (2):
  aio-posix: Don't count ctx->notifier as progress when polling
  aio: Do aio_notify_accept only during blocking aio_poll

 util/aio-posix.c | 7 ++++---
 util/aio-win32.c | 3 ++-
 2 files changed, 6 insertions(+), 4 deletions(-)

Comments

Fam Zheng Aug. 14, 2018, 2:50 a.m. UTC | #1

On Thu, 08/09 21:22, Fam Zheng wrote:
> v3: Fix commit message's bug description. [Paolo]

If there's no objection, I'm queuing this for 3.1.

Fam

Paolo Bonzini Aug. 14, 2018, 6:27 a.m. UTC | #2

On 14/08/2018 04:50, Fam Zheng wrote:
> On Thu, 08/09 21:22, Fam Zheng wrote:
>> v3: Fix commit message's bug description. [Paolo]
> 
> If there's no objection, I'm queuing this for 3.1.

Sure, thanks.

Paolo