[v4,0/3] file-posix: Simplifications on image locking

Message

Fam Zheng Aug. 21, 2018, 12:58 a.m. UTC

v4: Fix test on systems without OFD. [Patchew]

The first patch reduces chances of QEMU crash in unusual (but not unlikely)
cases especially when used by Libvirt (see commit message).

The second patch halves fd for images.

The third adds some more test for patch one (would have caught the regression
caused by v2).

Fam Zheng (3):
  file-posix: Skip effectiveless OFD lock operations
  file-posix: Drop s->lock_fd
  tests: Add unit tests for image locking

 block/file-posix.c         |  83 ++++++++++++--------
 tests/Makefile.include     |   2 +
 tests/test-image-locking.c | 154 +++++++++++++++++++++++++++++++++++++
 3 files changed, 209 insertions(+), 30 deletions(-)
 create mode 100644 tests/test-image-locking.c

Comments

Fam Zheng Sept. 19, 2018, 2:05 a.m. UTC | #1

On Tue, 08/21 08:58, Fam Zheng wrote:
> v4: Fix test on systems without OFD. [Patchew]

Ping?

> 
> The first patch reduces chances of QEMU crash in unusual (but not unlikely)
> cases especially when used by Libvirt (see commit message).
> 
> The second patch halves fd for images.
> 
> The third adds some more test for patch one (would have caught the regression
> caused by v2).
> 
> Fam Zheng (3):
>   file-posix: Skip effectiveless OFD lock operations
>   file-posix: Drop s->lock_fd
>   tests: Add unit tests for image locking
> 
>  block/file-posix.c         |  83 ++++++++++++--------
>  tests/Makefile.include     |   2 +
>  tests/test-image-locking.c | 154 +++++++++++++++++++++++++++++++++++++
>  3 files changed, 209 insertions(+), 30 deletions(-)
>  create mode 100644 tests/test-image-locking.c
> 
> -- 
> 2.17.1
> 
>