From patchwork Thu Nov 8 14:19:42 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corey Minyard X-Patchwork-Id: 10674347 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 94B0415E9 for ; Thu, 8 Nov 2018 14:23:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 858C92DC94 for ; Thu, 8 Nov 2018 14:23:34 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 839662DCFE; Thu, 8 Nov 2018 14:23:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2CC712DC94 for ; Thu, 8 Nov 2018 14:23:34 +0000 (UTC) Received: from localhost ([::1]:57069 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKlDZ-0000Cs-GR for patchwork-qemu-devel@patchwork.kernel.org; Thu, 08 Nov 2018 09:23:33 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53112) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKlAB-0004Vl-AU for qemu-devel@nongnu.org; Thu, 08 Nov 2018 09:20:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gKlA9-00077Z-VY for qemu-devel@nongnu.org; Thu, 08 Nov 2018 09:20:03 -0500 Received: from mail-io1-xd43.google.com ([2607:f8b0:4864:20::d43]:44788) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gKlA9-00070m-LJ for qemu-devel@nongnu.org; Thu, 08 Nov 2018 09:20:01 -0500 Received: by mail-io1-xd43.google.com with SMTP id c6-v6so14684493iob.11 for ; Thu, 08 Nov 2018 06:19:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=2As6yQY2aTJyfpwbER7b7Bit9jxZqrdBPW6H+TYnJKo=; b=YbMKJL9HK+nFnNDmbdkf84etpJqSbjS0qo5tcY3I+UmMEScY5wQ86522uME3wkhHNu VLqTevRdh+SJ2NzHBPUGJgSsksGvnPKHO0pki4XIMVcRlElQvCYEIvJGFHKu683JBJFz +pJKorOS/pDRuTljDrzNC190xXkC+gWhzRFxw1PEpcpv9MCRHM8lSdOFaERaFBp0g/3G x+mwSUiXHDjQ5Mke0YyUF3uhSuMNZO70k6TioBs0dFR+KhxMfj7RZMoufbS0BB57f6CZ mdDwYRi9LjmciZXyYRx+PdBjSNM69jgzVxlwxh3IgWn7icd8I2zRmU54YZaX7kVwMY/S OSEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=2As6yQY2aTJyfpwbER7b7Bit9jxZqrdBPW6H+TYnJKo=; b=fEDsu8LUF/5ZJjPSWtzhOXvdlcAun+lhiFTrpnQiIS68bkDKIeUTkw/QeAR19mBgIy 8pkRRbG+Icz/7pU4aOsJqXnpHFn+7hic31rGfbzjH2FBO4O4vIWlhpO2rk3pMFyNOBdT 6fyxoSssxp2023cn9f0hkqHXWJBoESOKRxXG4cCt7WpZbtPuBZ8hZfwiWlzkByYkiKbf 9c+mP4ZZIYORqvXZKgBTtLqqCijdpAicUpAyBaVDAMbyT6qzgTrYIvtGnlq4AYOw71NG NSajWXUwYRO2U3gCc0MGMsWLpdCrtE81yXs0dM6g/KCj3MoCl9wcCGB7raAXYrOdZ64Z TEMQ== X-Gm-Message-State: AGRZ1gJk6N+b/+wFNVbj/DMF2/YBxaySKNcRm4mlWa667nDEw+M88gfG 9HqJiO8RVoJkRfOEi6GtKg== X-Google-Smtp-Source: AJdET5cro4EA1Iob+aiZKoJcf0nS7dtGdjUSVnT+DjvspTHrW2KC9pE9uCFfLv/mwKjP60rsEAezLg== X-Received: by 2002:a6b:e216:: with SMTP id z22-v6mr1067669ioc.70.1541686790327; Thu, 08 Nov 2018 06:19:50 -0800 (PST) Received: from serve.minyard.net ([47.184.170.128]) by smtp.gmail.com with ESMTPSA id n25-v6sm1221178iop.34.2018.11.08.06.19.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Nov 2018 06:19:49 -0800 (PST) Received: from t430.minyard.net (t430m.minyard.net [192.168.27.3]) by serve.minyard.net (Postfix) with ESMTPA id 8D756BD2; Thu, 8 Nov 2018 08:19:47 -0600 (CST) Received: by t430.minyard.net (Postfix, from userid 1000) id 73152301153; Thu, 8 Nov 2018 08:19:46 -0600 (CST) From: minyard@acm.org To: qemu-devel@nongnu.org Date: Thu, 8 Nov 2018 08:19:42 -0600 Message-Id: <20181108141944.15769-1-minyard@acm.org> X-Mailer: git-send-email 2.17.1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::d43 Subject: [Qemu-devel] [PATCH 0/2] ipmi: Allow UUID to be set for a BMC X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , "Michael S . Tsirkin" , =?utf-8?q?C=C3=A9dric_Le_Goater?= , =?utf-8?q?Marc-Andr=C3=A9?= =?utf-8?q?_Lureau?= , Paolo Bonzini , David Gibson Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP The code was using the qemu UUID for the BMC. But that's really not a good method. In general, you don't want the GUID to change when you migrate, and you want the GUID to be the same between invocations of qemu (if you have a GUID). Plus, if you have multiple BMCs, they need to have different GUIDs or the host code cannot tell them apart. I'm not sure anyone really uses multiple BMCs, but I do a lot of testing with that scenario. This change lets the user set the GUID on the command line, and if the GUID is not set return an error for the GUID fetch command. This maps better to how IPMI should work. This change relies on the UUID being set to all zeros to know that it is not set. This is not optimal, perhaps, but an all zero UUID isn't valid (it's the Nil UUID), so it should be ok.