[0/6] fw_cfg: add HMP 'info fw_cfg' and add_file_from_host()

Message

Philippe Mathieu-Daudé Dec. 7, 2018, 5:03 p.m. UTC

Hi, various fw_cfg easy patches:

- First patches are trivial cleanups (and add trace events),

- patch 5 add a 'info fw_cfg' HMP command to display comprehensive list of
fw_cfg entries registered,

- patch 6 add fw_cfg_add_file_from_host(), a helper to map a file from the
host (using g_file_get_contents). This will be used by later UEFI series.

Philippe Mathieu-Daudé (6):
  hw/arm/virt: Remove null-check in virt_build_smbios()
  hw/arm: Remove unused include
  hw/i386: Remove unused include
  hw/nvram/fw_cfg: Add trace events
  hw/nvram/fw_cfg: Add HMP 'info fw_cfg' command
  hw/nvram/fw_cfg: Add fw_cfg_add_file_from_host()

 hmp-commands-info.hx      |  14 ++++
 hw/acpi/piix4.c           |   1 -
 hw/arm/virt-acpi-build.c  |   1 -
 hw/arm/virt.c             |   4 --
 hw/i386/acpi-build.c      |   1 -
 hw/i386/pc.c              |   1 -
 hw/nvram/fw_cfg.c         | 142 ++++++++++++++++++++++++++++++++++++++
 hw/nvram/trace-events     |   5 ++
 include/hw/nvram/fw_cfg.h |  24 +++++++
 9 files changed, 185 insertions(+), 8 deletions(-)

Comments

[e-mail] Dec. 7, 2018, 10:48 p.m. UTC | #1

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
time make docker-test-quick@centos7 SHOW_ENV=1 J=8
=== TEST SCRIPT END ===

libpmem support   no
libudev           no

WARNING: Use of SDL 1.2 is deprecated and will be removed in
WARNING: future releases. Please switch to using SDL 2.0

NOTE: cross-compilers enabled:  'cc'
  GEN     x86_64-softmmu/config-devices.mak.tmp


The full log is available at
http://patchew.org/logs/[e-mail]/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to [e-mail]

Philippe Mathieu-Daudé Dec. 10, 2018, 9:22 a.m. UTC | #2

On 12/7/18 11:48 PM, [e-mail] wrote:
> This series failed the docker-quick@centos7 build test. Please find the testing commands and
> their output below. If you have Docker installed, you can probably reproduce it
> locally.
> 
...
> The full log is available at
> http://patchew.org/logs/[e-mail]/testing.docker-quick@centos7/?type=message.

  qemu-system-x86_64: Back to tcg accelerator
  Broken pipe
  /tmp/qemu-test/src/tests/libqtest.c:125: kill_qemu() detected QEMU
death from signal 11 (Segmentation fault) (core dumped)
  GTester: last random seed: R02Sb6a4400485731f23217a8855e030b450
  Broken pipe

Probably the error Michael noticed:

>> +void hmp_info_fw_cfg(Monitor *mon, const QDict *qdict)
>> +{
>> +    FWCfgState *s = fw_cfg_find();
>> +    int arch, key;
>
>  Looks like this will crash on a machine without fw cfg.