From patchwork Tue Dec 18 11:03:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 10735417 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4C65A6C5 for ; Tue, 18 Dec 2018 11:14:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3A1F929EF0 for ; Tue, 18 Dec 2018 11:14:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2CBD62A3D9; Tue, 18 Dec 2018 11:14:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C0E0E29EF0 for ; Tue, 18 Dec 2018 11:14:28 +0000 (UTC) Received: from localhost ([::1]:53139 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZDKV-0006Ix-LU for patchwork-qemu-devel@patchwork.kernel.org; Tue, 18 Dec 2018 06:14:27 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41356) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZDEl-0001Ac-G0 for qemu-devel@nongnu.org; Tue, 18 Dec 2018 06:08:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gZDAe-0008O2-Ri for qemu-devel@nongnu.org; Tue, 18 Dec 2018 06:04:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52659) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gZDAW-0008GD-DM; Tue, 18 Dec 2018 06:04:10 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DF8352D7F1; Tue, 18 Dec 2018 11:04:03 +0000 (UTC) Received: from x1w.redhat.com (unknown [10.40.205.65]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 72F6360DB7; Tue, 18 Dec 2018 11:03:35 +0000 (UTC) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Date: Tue, 18 Dec 2018 12:03:30 +0100 Message-Id: <20181218110333.22558-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 18 Dec 2018 11:04:04 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2 0/3] Fix strncpy() warnings for GCC8 new -Wstringop-truncation X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" , Jeff Cody , Paolo Bonzini , Ben Pye , qemu-block@nongnu.org, Juan Quintela , David Hildenbrand , Markus Armbruster , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Thomas Huth , Stefan Weil , 1803872@bugs.launchpad.net, "Dr. David Alan Gilbert" , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Liu Yuan , David Gibson , Kevin Wolf , Max Reitz , Howard Spoelstra , Igor Mammedov Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP GCC 8 new warning prevents builds to success since quite some time. First report on the mailing list is in July 2018: https://lists.gnu.org/archive/html/qemu-devel/2018-07/msg03723.html Various intents has been sent to fix this: - Incorrectly using g_strlcpy() https://lists.gnu.org/archive/html/qemu-devel/2018-08/msg03705.html https://lists.gnu.org/archive/html/qemu-devel/2018-08/msg03706.html - Using assert() and strpadcpy() https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg03938.html - Use #pragma GCC diagnostic ignored "-Wstringop-truncation" https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04261.html - adding an inline wrapper with said pragma in there https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04261.html - -Wno-stringop-truncation is the makefile https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04261.html This series replace the strncpy() calls by strpadcpy() which seemed to me the saniest option. Regards, Phil. Marc-André Lureau (1): hw/acpi: Replace strncpy() by strpadcpy(pad='\0') Philippe Mathieu-Daudé (2): block/sheepdog: Replace strncpy() by strpadcpy(pad='\0') migration: Replace strncpy() by strpadcpy(pad='\0') block/sheepdog.c | 6 +++--- hw/acpi/aml-build.c | 6 ++++-- hw/acpi/core.c | 13 +++++++------ migration/global_state.c | 4 ++-- 4 files changed, 16 insertions(+), 13 deletions(-)