| Message ID | 20190122150543.16889-1-bala24@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | migration: calculate expected_downtime considering redirtied ram | expand |
Patchew URL: https://patchew.org/QEMU/20190122150543.16889-1-bala24@linux.vnet.ibm.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
time make docker-test-mingw@fedora SHOW_ENV=1 J=14
=== TEST SCRIPT END ===
CC net/util.o
CC net/hub.o
/tmp/qemu-test/src/migration/migration.c: In function 'migration_update_counters':
/tmp/qemu-test/src/migration/migration.c:2907:9: error: 'remaining_ram_transfer_time' undeclared (first use in this function)
remaining_ram_transfer_time = ram_counters.remaining / bandwidth
^~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/qemu-test/src/migration/migration.c:2907:9: note: each undeclared identifier is reported only once for each function it appears in
/tmp/qemu-test/src/migration/migration.c:2907:73: error: expected ';' before 'newly_dirtied_ram'
remaining_ram_transfer_time = ram_counters.remaining / bandwidth
^
;
The full log is available at
http://patchew.org/logs/20190122150543.16889-1-bala24@linux.vnet.ibm.com/testing.docker-mingw@fedora/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
From: Balamuruhan S <bala24@linux.vnet.ibm.com> Based on the discussion with Dave and David Gibson earlier with respect to expected_downtime calculation, https://lists.gnu.org/archive/html/qemu-devel/2018-04/msg02418.html got suggestions that the calculation is of not accurate and we need to consider the ram that gets redirtied during the time when we would have actually transferred ram in the current iteration. so I have came up with a calculation by considering the ram that could get redirtied during the current iteration at the time we would have transferred the remaining ram in current iteration. By this way, the total ram to be transferred will be remaining ram + redirtied ram and dividing with bandwidth would yield us better expected_downtime value. Please help to review and suggest about this approach. Balamuruhan S (1): migration: calculate expected_downtime considering redirtied ram migration/migration.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)