From patchwork Fri Feb 8 13:49:44 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefano Garzarella X-Patchwork-Id: 10803145 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 35E4513A4 for ; Fri, 8 Feb 2019 13:51:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 264C72E23F for ; Fri, 8 Feb 2019 13:51:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 17F182E22C; Fri, 8 Feb 2019 13:51:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B15BB2E230 for ; Fri, 8 Feb 2019 13:51:38 +0000 (UTC) Received: from localhost ([127.0.0.1]:56826 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gs6Z8-0000uI-1t for patchwork-qemu-devel@patchwork.kernel.org; Fri, 08 Feb 2019 08:51:38 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58778) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gs6Xx-0008Nw-As for qemu-devel@nongnu.org; Fri, 08 Feb 2019 08:50:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gs6Xw-0005Rs-HF for qemu-devel@nongnu.org; Fri, 08 Feb 2019 08:50:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44342) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gs6Xu-0005Mj-B2; Fri, 08 Feb 2019 08:50:22 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7E40187623; Fri, 8 Feb 2019 13:50:21 +0000 (UTC) Received: from steredhat.redhat.com (ovpn-116-173.ams2.redhat.com [10.36.116.173]) by smtp.corp.redhat.com (Postfix) with ESMTP id 950B35C25A; Fri, 8 Feb 2019 13:49:51 +0000 (UTC) From: Stefano Garzarella To: qemu-devel@nongnu.org Date: Fri, 8 Feb 2019 14:49:44 +0100 Message-Id: <20190208134950.187665-1-sgarzare@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Fri, 08 Feb 2019 13:50:21 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v4 0/6] virtio-blk: add DISCARD and WRITE_ZEROES features X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Kevin Wolf , Thomas Huth , Eduardo Habkost , qemu-block@nongnu.org, "Michael S. Tsirkin" , Stefan Hajnoczi , "Dr . David Alan Gilbert" , Max Reitz , Paolo Bonzini Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP This series adds the support of DISCARD and WRITE_ZEROES commands and extends the virtio-blk-test to test WRITE_ZEROES command when the feature is enabled. v4: - fixed error with mingw compiler in patch 4 gcc and clang want %lu, but mingw wants %llu for BDRV_REQUEST_MAX_SECTORS. Since is less than INT_MAX, I casted it to integer and I used %d in the format string of error_setg. (mingw now is happy) v3: - rebased on master (I removed Based-on tag since the new virtio headers from linux v5.0-rc1 are merged) - added patch 2 to add host_features field (as in virtio-net) [Michael] - fixed patch 3 (previously 2/5) using the new host_features field - fixed patch 4 (previously 3/5) following the Stefan's comments: - fixed name of functions and fields - used vdev and s pointers - removed "wz-may-unmap" property - split "dwz-max-sectors" in two properties v2: - added patch 1 to use virtio_blk_handle_rw_error() with discard operation - added patch 2 to make those new features machine-type dependent (thanks David) - fixed patch 3 (previously patch 1/2) adding more checks, block_acct_start() for WRITE_ZEROES requests, and configurable parameters to initialize the limits (max_sectors, wzeroes_may_unmap). (thanks Stefan) I moved in a new function the code to handle a single segment, in order to simplify the support of multiple segments in the future. - added patch 4 to change the assert on data_size following the discussion with Thomas, Changpeng, Michael, and Stefan (thanks all) - fixed patch 5 (previously patch 2/2) using local dwz_hdr variable instead of dynamic allocation (thanks Thomas) Thanks, Stefano Stefano Garzarella (6): virtio-blk: add acct_failed param to virtio_blk_handle_rw_error() virtio-blk: add host_features field in VirtIOBlock virtio-blk: add "discard" and "write-zeroes" properties virtio-blk: add DISCARD and WRITE_ZEROES features tests/virtio-blk: change assert on data_size in virtio_blk_request() tests/virtio-blk: add test for WRITE_ZEROES command hw/block/virtio-blk.c | 214 +++++++++++++++++++++++++++++++-- hw/core/machine.c | 2 + include/hw/virtio/virtio-blk.h | 5 +- tests/virtio-blk-test.c | 75 +++++++++++- 4 files changed, 282 insertions(+), 14 deletions(-) Acked-by: Pankaj Gupta Reviewed-by: Michael S. Tsirkin