From patchwork Wed Feb 13 06:53:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yuval Shaia X-Patchwork-Id: 10809251 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1E53C13B4 for ; Wed, 13 Feb 2019 07:14:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0854129753 for ; Wed, 13 Feb 2019 07:14:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EEB452A4F2; Wed, 13 Feb 2019 07:14:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 91C5529753 for ; Wed, 13 Feb 2019 07:14:13 +0000 (UTC) Received: from localhost ([127.0.0.1]:52135 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gtokG-0008JL-NT for patchwork-qemu-devel@patchwork.kernel.org; Wed, 13 Feb 2019 02:14:12 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33309) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gtodV-0003Ky-JR for qemu-devel@nongnu.org; Wed, 13 Feb 2019 02:07:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gtoQr-0003oE-Od for qemu-devel@nongnu.org; Wed, 13 Feb 2019 01:54:10 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:59586) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gtoQr-0003mc-Ea for qemu-devel@nongnu.org; Wed, 13 Feb 2019 01:54:09 -0500 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x1D6mmww017299; Wed, 13 Feb 2019 06:54:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : subject : date : message-id; s=corp-2018-07-02; bh=lLXCONdyUbPiqPqTDjQhB/v/SPRzJ/82ue2biMaj2js=; b=rUwd2eyBQZr2Nw3F4C7kTp8XyqHkv0Zd4ZUVUQtz9o9memTtoydK0uA00+CM8t401Gmc 7jnwQm4hjTtn2JiT30eUJxOxDpQEhn6+fiBp6zJNfgvXxW9pe3NH+9/H47Cr2E6Pmggg bm/hSVYHCXI+9+2nTJ4B2qNftBWV3tGaxVk3EDS3pi8yfaJgPFXlNHA+UwM89f9JvJxN 9Gs8txTDDQc34ffDAcLx2iZ/jnK1tI5np2yneTRtoDzxBfWGPcBl5eddv0ShbmeS3kvZ G9xCIvA/xn0jwpCF/tfGp7GzoKO1DmyvjQxvzHMIky3X3MbnyXJKPyWy9R+rlrQMYsij fg== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp2130.oracle.com with ESMTP id 2qhre5g58x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 13 Feb 2019 06:54:06 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id x1D6s6MR031315 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 13 Feb 2019 06:54:06 GMT Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x1D6s5BF005440; Wed, 13 Feb 2019 06:54:05 GMT Received: from localhost.localdomain (/77.138.186.148) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 13 Feb 2019 06:54:05 +0000 From: Yuval Shaia To: dgilbert@redhat.com, yuval.shaia@oracle.com, marcel.apfelbaum@gmail.com, armbru@redhat.com, qemu-devel@nongnu.org Date: Wed, 13 Feb 2019 08:53:47 +0200 Message-Id: <20190213065357.16076-1-yuval.shaia@oracle.com> X-Mailer: git-send-email 2.17.2 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9165 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902130050 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 141.146.126.79 Subject: [Qemu-devel] [PATCH v2 0/9] Misc fixes to pvrdma device X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Hi, Please review the following patch-set which consist of cosmetics fixes to device's user interface (traces, error_report and monitor) and some bug fixes. Thanks Markus, Eric, Marcel and David for reviewing v0. Appreciate your review to this v2. Still missing r-b for patches 2, 4 and 6. v0 -> v1: * Explain why device attributes are exposed only in HMP interface. * Squash the 3 patches related to HMP interface into one. * Make monitor dump function simple. * Make HMP interface available only if pvrdma is included (detected by build robot). * Remove patch 03/10 ("Warn when too many consecutive poll CQ triggered on an empty CQ) and add the two counters to patch 0/7 (monitor). * Add Marcel's R-Bs. * Add mutex protection to cqe_ctx list. * Add two new patches. v1 -> v2: * Rename locked-lists to protected-lists in patch 2 and patch 6. * Add Marcel's R-Bs. Thanks, Yuval Yuval Shaia (9): hw/rdma: Switch to generic error reporting way hw/rdma: Introduce protected qlist hw/rdma: Protect against concurrent execution of poll_cq {monitor,hw/pvrdma}: Expose device internals via monitor interface hw/rdma: Free all MAD receive buffers when device is closed hw/rdma: Free all receive buffers when QP is destroyed hw/pvrdma: Delete unneeded function argument hw/pvrdma: Delete pvrdma_exit function hw/pvrdma: Unregister from shutdown notifier when device goes down hmp-commands-info.hx | 16 ++ hw/rdma/rdma_backend.c | 483 +++++++++++++++++----------------- hw/rdma/rdma_backend.h | 3 +- hw/rdma/rdma_backend_defs.h | 10 +- hw/rdma/rdma_rm.c | 134 +++++----- hw/rdma/rdma_rm_defs.h | 28 +- hw/rdma/rdma_utils.c | 79 +++++- hw/rdma/rdma_utils.h | 61 ++--- hw/rdma/trace-events | 32 ++- hw/rdma/vmw/pvrdma.h | 7 +- hw/rdma/vmw/pvrdma_cmd.c | 113 ++------ hw/rdma/vmw/pvrdma_dev_ring.c | 26 +- hw/rdma/vmw/pvrdma_hmp.h | 21 ++ hw/rdma/vmw/pvrdma_main.c | 217 ++++++++------- hw/rdma/vmw/pvrdma_qp_ops.c | 52 +--- hw/rdma/vmw/trace-events | 16 +- monitor.c | 10 + 17 files changed, 709 insertions(+), 599 deletions(-) create mode 100644 hw/rdma/vmw/pvrdma_hmp.h