From patchwork Sun Mar 3 20:33:36 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yuval Shaia X-Patchwork-Id: 10837243 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BE50F17E9 for ; Sun, 3 Mar 2019 20:35:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 03865298C6 for ; Sun, 3 Mar 2019 20:35:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EB5A22994C; Sun, 3 Mar 2019 20:35:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 721BB298C6 for ; Sun, 3 Mar 2019 20:35:24 +0000 (UTC) Received: from localhost ([127.0.0.1]:43909 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h0XpT-0005Vv-3g for patchwork-qemu-devel@patchwork.kernel.org; Sun, 03 Mar 2019 15:35:23 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46141) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h0Xo8-0004Sy-MT for qemu-devel@nongnu.org; Sun, 03 Mar 2019 15:34:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h0Xo7-0006DY-Od for qemu-devel@nongnu.org; Sun, 03 Mar 2019 15:34:00 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:37252) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h0Xo7-0005s0-De for qemu-devel@nongnu.org; Sun, 03 Mar 2019 15:33:59 -0500 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x23KTm1k045749; Sun, 3 Mar 2019 20:33:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : subject : date : message-id; s=corp-2018-07-02; bh=PUlM9layLaG1QT/RDLNW84upeJa7UpROKNWeMlgqsR0=; b=3nBe0HxImgETmkl3npRANRjQMFSvh4nQFBsK27T0hqF3xMrBLC2eNp+3MkeCL1rUd7DJ GwvgGA4B0g8Nto5gFuU93NLYdxw0i/wxQ6xWUtbgKGW4b0DGls3xAJQs8rbN79CS0dyE M4+xF4A5RMJemnw0IeyFxmGugjtwuMSuy0GCgS0NILqmPDzRewQvSG8yR+YMTH6w+8b5 qNI7AUaYvrHuLZ/oi0BFqM8zbIdV9FzvAE6w4f23wTyMJSj45+NB1SbWjczPEsgfoN4H CXP19fKbC2rj/KBhX6ba+7D8VZhe49WV2RdhsO1yPqjYyPVIhdO1kt3omzjObmbXYxkt EA== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp2130.oracle.com with ESMTP id 2qyfbdv2g8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 03 Mar 2019 20:33:54 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id x23KXrJl022239 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 3 Mar 2019 20:33:53 GMT Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x23KXqS1007660; Sun, 3 Mar 2019 20:33:52 GMT Received: from localhost.localdomain (/77.138.186.148) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 03 Mar 2019 12:33:51 -0800 From: Yuval Shaia To: dgilbert@redhat.com, yuval.shaia@oracle.com, marcel.apfelbaum@gmail.com, armbru@redhat.com, qemu-devel@nongnu.org Date: Sun, 3 Mar 2019 22:33:36 +0200 Message-Id: <20190303203345.2472-1-yuval.shaia@oracle.com> X-Mailer: git-send-email 2.17.2 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9184 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1903030160 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 141.146.126.79 Subject: [Qemu-devel] [PATCH v4 0/9] Misc fixes to pvrdma device X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Hi, Please review the following patch-set which consist of cosmetics fixes to device's user interface (traces, error_report and monitor) and some bug fixes. Thanks Markus, Eric, Marcel and David for reviewing v0. David, please see version notes below, since i restructured the HMP part your second review is needed, thanks in advance. v0 -> v1: * Explain why device attributes are exposed only in HMP interface. * Squash the 3 patches related to HMP interface into one. * Make monitor dump function simple. * Make HMP interface available only if pvrdma is included (detected by build robot). * Remove patch 03/10 ("Warn when too many consecutive poll CQ triggered on an empty CQ) and add the two counters to patch 0/7 (monitor). * Add Marcel's R-Bs. * Add mutex protection to cqe_ctx list. * Add two new patches. v1 -> v2: * Rename locked-lists to protected-lists in patch 2 and patch 6. * Add Marcel's R-Bs. v2 -> v3: * Address some 32 bit host compilation issues. v3 -> v4: * Per suggestion from Markus rebase HMP report on object_child_foreach_recursive(). * Strip off David's r-b from HMP patch (#4) because of the above. Yuval Shaia (9): hw/rdma: Switch to generic error reporting way hw/rdma: Introduce protected qlist hw/rdma: Protect against concurrent execution of poll_cq {hmp,hw/pvrdma}: Expose device internals via monitor interface hw/rdma: Free all MAD receive buffers when device is closed hw/rdma: Free all receive buffers when QP is destroyed hw/pvrdma: Delete unneeded function argument hw/pvrdma: Delete pvrdma_exit function hw/pvrdma: Unregister from shutdown notifier when device goes down hmp-commands-info.hx | 14 + hmp.c | 27 ++ hmp.h | 1 + hw/rdma/Makefile.objs | 2 +- hw/rdma/rdma_backend.c | 483 +++++++++++++++++----------------- hw/rdma/rdma_backend.h | 3 +- hw/rdma/rdma_backend_defs.h | 10 +- hw/rdma/rdma_hmp.c | 30 +++ hw/rdma/rdma_rm.c | 193 ++++++++------ hw/rdma/rdma_rm.h | 7 +- hw/rdma/rdma_rm_defs.h | 28 +- hw/rdma/rdma_utils.c | 83 +++++- hw/rdma/rdma_utils.h | 61 ++--- hw/rdma/trace-events | 32 ++- hw/rdma/vmw/pvrdma.h | 7 +- hw/rdma/vmw/pvrdma_cmd.c | 113 ++------ hw/rdma/vmw/pvrdma_dev_ring.c | 26 +- hw/rdma/vmw/pvrdma_main.c | 161 +++++------- hw/rdma/vmw/pvrdma_qp_ops.c | 52 +--- hw/rdma/vmw/trace-events | 16 +- include/hw/rdma/rdma_hmp.h | 40 +++ 21 files changed, 779 insertions(+), 610 deletions(-) create mode 100644 hw/rdma/rdma_hmp.c create mode 100644 include/hw/rdma/rdma_hmp.h