[00/11] target/hppa patches

Message

Sven Schnelle March 11, 2019, 7:15 p.m. UTC

Hi Richard,

here are a few fixes for the HPPA architecture. Some fixes for
problems reported by diagnostics software, some TLB fixes to make
HP-UX 10.20 work with TB chaining in QEMU. I'm not sure whether the
'call eval_interrupt() after ssm' fix is really the right way - please
check.

I haven't seen any problems with these HP-UX 10.20 anymore, and Linux also
still works.

Thanks
Sven

Sven Schnelle (11):
  target/hppa: fix overwriting source reg in addb
  target/hppa: fix TLB handling for page 0
  target/hppa: report ITLB_EXCP_MISS for ITLB misses
  target/hppa: add TLB trace events
  target/hppa: remove PSW I/R/Q bit check
  target/hppa: ignore DIAG opcode
  target/hppa: fix b,gate instruction
  target/hppa: allow multiple itlbp without itlba
  target/hppa: add TLB protection id check
  target/hppa: exit TB if either Data or Instruction TLB changes
  target/hppa: call eval_interrupt() after ssm

 Makefile.objs            |  1 +
 target/hppa/cpu.h        |  5 +++
 target/hppa/insns.decode |  3 ++
 target/hppa/int_helper.c |  2 +-
 target/hppa/mem_helper.c | 68 +++++++++++++++++++++++++++++++---------
 target/hppa/op_helper.c  | 13 +++++---
 target/hppa/trace-events | 18 +++++++++++
 target/hppa/translate.c  | 23 +++++++++-----
 8 files changed, 106 insertions(+), 27 deletions(-)
 create mode 100644 target/hppa/trace-events

Comments

[e-mail] March 11, 2019, 7:48 p.m. UTC | #1

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: [e-mail]
Subject: [Qemu-devel] [PATCH 00/11] target/hppa patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/[e-mail] -> patchew/[e-mail]
Switched to a new branch 'test'
40ceb6e6ae target/hppa: call eval_interrupt() after ssm
c5988388b3 target/hppa: exit TB if either Data or Instruction TLB changes
2fe19345de target/hppa: add TLB protection id check
c6466d97af target/hppa: allow multiple itlbp without itlba
278b4cc1e3 target/hppa: fix b,gate instruction
362d5b268b target/hppa: ignore DIAG opcode
00d4779b37 target/hppa: remove PSW I/R/Q bit check
d51423679b target/hppa: add TLB trace events
92887610fa target/hppa: report ITLB_EXCP_MISS for ITLB misses
95cf25833a target/hppa: fix TLB handling for page 0
7772997bae target/hppa: fix overwriting source reg in addb

=== OUTPUT BEGIN ===
1/11 Checking commit 7772997bae4b (target/hppa: fix overwriting source reg in addb)
2/11 Checking commit 95cf25833af4 (target/hppa: fix TLB handling for page 0)
3/11 Checking commit 92887610fa42 (target/hppa: report ITLB_EXCP_MISS for ITLB misses)
4/11 Checking commit d51423679b65 (target/hppa: add TLB trace events)
ERROR: line over 90 characters
#41: FILE: target/hppa/mem_helper.c:47:
+            trace_hppa_tlb_find_entry(env, ent + i, ent->entry_valid, ent->va_b, ent->va_e, ent->pa);

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#161: 
new file mode 100644

ERROR: Hex numbers must be prefixed with '0x'
#171: FILE: target/hppa/trace-events:6:
+disable hppa_tlb_find_entry_not_found(void *env, uint64_t addr) "env=%p addr=%08lx"

ERROR: Hex numbers must be prefixed with '0x'
#176: FILE: target/hppa/trace-events:11:
+disable hppa_tlb_itlbp(void *env, void *ent, int access_id, int u, int pl2, int pl1, int type, int b, int d, int t) "env=%p ent=%p access_id=%x u=%d pl2=%d pl1=%d type=%d b=%d d=%d t=%d"

total: 3 errors, 1 warnings, 138 lines checked

Patch 4/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/11 Checking commit 00d4779b3785 (target/hppa: remove PSW I/R/Q bit check)
6/11 Checking commit 362d5b268bd8 (target/hppa: ignore DIAG opcode)
7/11 Checking commit 278b4cc1e332 (target/hppa: fix b,gate instruction)
8/11 Checking commit c6466d97af03 (target/hppa: allow multiple itlbp without itlba)
9/11 Checking commit 2fe19345de05 (target/hppa: add TLB protection id check)
10/11 Checking commit c5988388b3de (target/hppa: exit TB if either Data or Instruction TLB changes)
11/11 Checking commit 40ceb6e6aed2 (target/hppa: call eval_interrupt() after ssm)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/[e-mail]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to [e-mail]

Richard Henderson March 12, 2019, 4:21 p.m. UTC | #2

On 3/11/19 12:15 PM, Sven Schnelle wrote:
> Sven Schnelle (11):
>   target/hppa: fix overwriting source reg in addb
>   target/hppa: fix TLB handling for page 0
>   target/hppa: report ITLB_EXCP_MISS for ITLB misses
>   target/hppa: add TLB trace events
>   target/hppa: remove PSW I/R/Q bit check
>   target/hppa: ignore DIAG opcode
>   target/hppa: fix b,gate instruction
>   target/hppa: allow multiple itlbp without itlba
>   target/hppa: add TLB protection id check
>   target/hppa: exit TB if either Data or Instruction TLB changes
>   target/hppa: call eval_interrupt() after ssm

I've incorporated all but this last into a pull request for 4.0.


r~