From patchwork Thu May 9 13:03:41 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefano Garzarella X-Patchwork-Id: 10937135 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 61B391390 for ; Thu, 9 May 2019 13:06:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 521B7285E8 for ; Thu, 9 May 2019 13:06:00 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 461FB28A6F; Thu, 9 May 2019 13:06:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id EBCF6285E8 for ; Thu, 9 May 2019 13:05:59 +0000 (UTC) Received: from localhost ([127.0.0.1]:54294 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOikJ-00016S-7P for patchwork-qemu-devel@patchwork.kernel.org; Thu, 09 May 2019 09:05:59 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43744) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOiin-0007pk-Sr for qemu-devel@nongnu.org; Thu, 09 May 2019 09:04:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hOiim-0007lW-Os for qemu-devel@nongnu.org; Thu, 09 May 2019 09:04:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61883) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hOiik-0007Jf-NG for qemu-devel@nongnu.org; Thu, 09 May 2019 09:04:23 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4AD41308219E for ; Thu, 9 May 2019 13:03:49 +0000 (UTC) Received: from steredhat.redhat.com (ovpn-116-227.ams2.redhat.com [10.36.116.227]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0514B60FA6; Thu, 9 May 2019 13:03:45 +0000 (UTC) From: Stefano Garzarella To: qemu-devel@nongnu.org Date: Thu, 9 May 2019 15:03:41 +0200 Message-Id: <20190509130345.227526-1-sgarzare@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Thu, 09 May 2019 13:03:49 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2 0/4] Clean ups in net/net.c X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Wang , Markus Armbruster Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP This series is a follow up of "[PATCH] net: avoid to use variable length array in net_client_init()" [1], so it contains the v2 of that patch, plus other new related patches. I discovered an assertion failure while I was testing the patches, so I added the patch 1 to solve this issue. Following the Markus' advice, I modified the parsing of IPv6 prefix (patch 2) and IPv4 host:port (patch 3). Then I removed the get_str_sep() function (patch 4) because it is no longer used. @Markus, I modified a little bit what you suggested, introducing g_strsplit() in order to de-duplicate the qemu_opt_set() and qemu_opt_set_number(). I hope it's good for you. v2: - Added patches 1,3 and 4 - Patch 2: - clean up parsing of IPv6 prefix [Markus] - fixed subject line [Eric] [1] https://www.mail-archive.com/qemu-devel@nongnu.org/msg614561.html Stefano Garzarella (4): net: fix assertion failure when ipv6-prefixlen is not a number net: avoid using variable length array in net_client_init() net: use g_strsplit() for parsing host address and port net: remove unused get_str_sep() function net/net.c | 101 +++++++++++++++++++++++++++--------------------------- 1 file changed, 51 insertions(+), 50 deletions(-)