From patchwork Wed Jul 24 11:25:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefano Garzarella X-Patchwork-Id: 11056599 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 72E5C1398 for ; Wed, 24 Jul 2019 11:25:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5DBEB28628 for ; Wed, 24 Jul 2019 11:25:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4F9B528682; Wed, 24 Jul 2019 11:25:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D026A28628 for ; Wed, 24 Jul 2019 11:25:48 +0000 (UTC) Received: from localhost ([::1]:50588 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hqFP2-0000I5-6z for patchwork-qemu-devel@patchwork.kernel.org; Wed, 24 Jul 2019 07:25:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55074) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hqFOt-0008Kx-KG for qemu-devel@nongnu.org; Wed, 24 Jul 2019 07:25:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hqFOs-0002DJ-HJ for qemu-devel@nongnu.org; Wed, 24 Jul 2019 07:25:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34816) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hqFOs-0002CX-CB for qemu-devel@nongnu.org; Wed, 24 Jul 2019 07:25:38 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EAA4B88318; Wed, 24 Jul 2019 11:25:36 +0000 (UTC) Received: from steredhat.redhat.com (ovpn-117-46.ams2.redhat.com [10.36.117.46]) by smtp.corp.redhat.com (Postfix) with ESMTP id F3E0C19C70; Wed, 24 Jul 2019 11:25:31 +0000 (UTC) From: Stefano Garzarella To: qemu-devel@nongnu.org Date: Wed, 24 Jul 2019 13:25:28 +0200 Message-Id: <20190724112531.232260-1-sgarzare@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 24 Jul 2019 11:25:37 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v3 0/3] pc: mmap kernel (ELF image) and initrd X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Eduardo Habkost , Sergio Lopez , "Michael S. Tsirkin" , Julio Montes , "Dr . David Alan Gilbert" , Paolo Bonzini , Richard Henderson Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP In order to reduce the memory footprint when PVH kernel and initrd are used, we map them into memory instead of reading them. In this way we can share them between multiple instances of QEMU. v3: - Added patch 1 to handle memory-mapped ELFs in rom_add_elf_program() [Paolo] - Patch 2: ~ passed the GMappedFile* to rom_add_elf_program() [Paolo] ~ renamed 'GMappedFile *gmf' in 'GMappedFile *mapped_filed' for readability ~ set 'data' pointer only if 'file_size > 0' as the original behaviour [check-qtest-ppc64 fails without it] - Patch 3: ~ stored the initrd GMappedFile* in PCMachineState to avoid Coverity issue [Paolo] ~ renamed 'GMappedFile *gmf' in 'GMappedFile *mapped_filed' for readability v2: https://patchew.org/QEMU/20190723140445.12748-1-sgarzare@redhat.com/ These are the results using a PVH kernel and initrd (cpio): - memory footprint (using smem) [MB] QEMU before now # instances USS PSS USS PSS 1 102.0M 105.8M 102.3M 106.2M 2 94.6M 101.2M 72.3M 90.1M 4 94.1M 98.0M 72.0M 81.5M 8 94.0M 96.2M 71.8M 76.9M 16 93.9M 95.1M 71.6M 74.3M Initrd size: 3.0M Kernel image size: 28M sections size [size -A -d vmlinux]: 18.9M - boot time [ms] before now qemu_init_end: 63.85 55.91 linux_start_kernel: 82.11 (+18.26) 74.51 (+18.60) linux_start_user: 169.94 (+87.83) 159.06 (+84.56) QEMU command used: ./qemu-system-x86_64 -bios /path/to/seabios/out/bios.bin -no-hpet \ -machine q35,accel=kvm,kernel_irqchip,nvdimm,sata=off,smbus=off,vmport=off \ -cpu host -m 1G -smp 1 -vga none -display none -no-user-config -nodefaults \ -kernel /path/to/vmlinux -initrd /path/to/rootfs.cpio \ -append 'root=/dev/mem0 ro console=hvc0 pci=lastbus=0 nosmap' Stefano Garzarella (3): loader: Handle memory-mapped ELFs elf-ops.h: Map into memory the ELF to load hw/i386/pc: Map into memory the initrd hw/core/loader.c | 37 +++++++++++++++++++----- hw/i386/pc.c | 17 ++++++++--- include/hw/elf_ops.h | 68 ++++++++++++++++++++++++++------------------ include/hw/i386/pc.h | 1 + include/hw/loader.h | 5 ++-- 5 files changed, 88 insertions(+), 40 deletions(-)