[0/5] TriCore fixes and gdbstub

Message

Bastian Koppelmann Sept. 30, 2019, 12:46 p.m. UTC

Hi,

this series fixes a few TriCore problems:

- Segfault due to non initialized ctx->env ptr (see
  https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg03527.html)
  I fixed this by properly detangling any reference of the env pointer in the
  translate functions. (as suggested by Peter Maydell) 

- Unimplemented tricore_cpu_get_phys_page_debug() which lead to a temporary fix
  (see b190f477e29c7cd03a8fee49c96d27f160e3f5b0)

The last patch implements a gdbstub for TriCore.

Cheers,
Bastian

Bastian Koppelmann (5):
  target/tricore: Don't save pc in generate_qemu_excp
  target/tricore: Move translate feature check to ctx
  target/tricore: Raise EXCP_DEBUG in gen_goto_tb() for singlestep
  target/tricore: Implement tricore_cpu_get_phys_page_debug
  target/tricore: Implement gdbstub

 target/tricore/Makefile.objs |   2 +-
 target/tricore/cpu.c         |  18 +++--
 target/tricore/cpu.h         |   2 +
 target/tricore/gdbstub.c     | 138 +++++++++++++++++++++++++++++++++++
 target/tricore/helper.c      |  13 ++++
 target/tricore/translate.c   |  79 ++++++++++----------
 6 files changed, 206 insertions(+), 46 deletions(-)
 create mode 100644 target/tricore/gdbstub.c

Comments

[e-mail] Sept. 30, 2019, 2:38 p.m. UTC | #1

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: [e-mail]
Subject: [PATCH 0/5] TriCore fixes and gdbstub

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
e0ab359 target/tricore: Implement gdbstub
af906d6 target/tricore: Implement tricore_cpu_get_phys_page_debug
421ac82 target/tricore: Raise EXCP_DEBUG in gen_goto_tb() for singlestep
5a6c845 target/tricore: Move translate feature check to ctx
69f10b4 target/tricore: Don't save pc in generate_qemu_excp

=== OUTPUT BEGIN ===
1/5 Checking commit 69f10b4a4d39 (target/tricore: Don't save pc in generate_qemu_excp)
2/5 Checking commit 5a6c84545f56 (target/tricore: Move translate feature check to ctx)
3/5 Checking commit 421ac8270548 (target/tricore: Raise EXCP_DEBUG in gen_goto_tb() for singlestep)
4/5 Checking commit af906d6437cd (target/tricore: Implement tricore_cpu_get_phys_page_debug)
5/5 Checking commit e0ab359a6c96 (target/tricore: Implement gdbstub)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#59: 
new file mode 100644

WARNING: line over 80 characters
#133: FILE: target/tricore/gdbstub.c:70:
+static void tricore_cpu_gdb_write_csfr(CPUTriCoreState *env, int n, uint32_t val)

ERROR: spaces required around that '-' (ctx:VxV)
#178: FILE: target/tricore/gdbstub.c:115:
+        return gdb_get_reg32(mem_buf, env->gpr_a[n-16]);
                                                   ^

ERROR: spaces required around that '-' (ctx:VxV)
#196: FILE: target/tricore/gdbstub.c:133:
+        env->gpr_d[n-16] = tmp;
                     ^

total: 2 errors, 2 warnings, 170 lines checked

Patch 5/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/[e-mail]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [e-mail]