| Message ID | 20191115075352.17734-1-tao3.xu@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Build ACPI Heterogeneous Memory Attribute Table (HMAT) | expand |
Patchew URL: https://patchew.org/QEMU/20191115075352.17734-1-tao3.xu@intel.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH v16 00/14] Build ACPI Heterogeneous Memory Attribute Table (HMAT)
Type: series
Message-id: 20191115075352.17734-1-tao3.xu@intel.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20191115083345.22638-1-tao3.xu@intel.com -> patchew/20191115083345.22638-1-tao3.xu@intel.com
Switched to a new branch 'test'
d5da20c tests/bios-tables-test: add test cases for ACPI HMAT
486185d tests/numa: Add case for QMP build HMAT
eb32946 hmat acpi: Build Memory Side Cache Information Structure(s)
e497fe7 hmat acpi: Build System Locality Latency and Bandwidth Information Structure(s)
255487a hmat acpi: Build Memory Proximity Domain Attributes Structure(s)
3af0c0b numa: Extend CLI to provide memory side cache information
56d1c80 numa: Extend CLI to provide memory latency and bandwidth information
b607b84 numa: Extend CLI to provide initiator information for numa nodes
184dd62 tests: Add test for QAPI builtin type time
b7f1b2c qapi: Add builtin type time
2018f91 util/cutils: Add qemu_strtotime_ns()
006728b util/cutils: refactor do_strtosz() to support suffixes list
8a57751 util/cutils: Use qemu_strtold_finite to parse size
eb2d1fd util/cutils: Add Add qemu_strtold and qemu_strtold_finite
=== OUTPUT BEGIN ===
1/14 Checking commit eb2d1fdb2cf0 (util/cutils: Add Add qemu_strtold and qemu_strtold_finite)
ERROR: consider using qemu_strtold in preference to strtold
#61: FILE: util/cutils.c:636:
+ *result = strtold(nptr, &ep);
total: 1 errors, 0 warnings, 69 lines checked
Patch 1/14 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/14 Checking commit 8a57751c17ed (util/cutils: Use qemu_strtold_finite to parse size)
3/14 Checking commit 006728bb0b4b (util/cutils: refactor do_strtosz() to support suffixes list)
4/14 Checking commit 2018f917c391 (util/cutils: Add qemu_strtotime_ns())
5/14 Checking commit b7f1b2cc1e96 (qapi: Add builtin type time)
6/14 Checking commit 184dd629c2fd (tests: Add test for QAPI builtin type time)
7/14 Checking commit b607b8499f73 (numa: Extend CLI to provide initiator information for numa nodes)
8/14 Checking commit 56d1c80175ad (numa: Extend CLI to provide memory latency and bandwidth information)
9/14 Checking commit 3af0c0b8fe71 (numa: Extend CLI to provide memory side cache information)
10/14 Checking commit 255487a44a8b (hmat acpi: Build Memory Proximity Domain Attributes Structure(s))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#72:
new file mode 100644
total: 0 errors, 1 warnings, 185 lines checked
Patch 10/14 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/14 Checking commit e497fe7c8adf (hmat acpi: Build System Locality Latency and Bandwidth Information Structure(s))
12/14 Checking commit eb32946cae4f (hmat acpi: Build Memory Side Cache Information Structure(s))
13/14 Checking commit 486185d6f70e (tests/numa: Add case for QMP build HMAT)
WARNING: line over 80 characters
#65: FILE: tests/numa-test.c:374:
+ g_assert(!qmp_rsp_is_err(qtest_qmp(qs, "{ 'execute': 'x-exit-preconfig' }")));
total: 0 errors, 1 warnings, 63 lines checked
Patch 13/14 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/14 Checking commit d5da20cf0514 (tests/bios-tables-test: add test cases for ACPI HMAT)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#106:
new file mode 100644
total: 0 errors, 1 warnings, 65 lines checked
Patch 14/14 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20191115075352.17734-1-tao3.xu@intel.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
This series of patches will build Heterogeneous Memory Attribute Table (HMAT) according to the command line. The ACPI HMAT describes the memory attributes, such as memory side cache attributes and bandwidth and latency details, related to the Memory Proximity Domain. The software is expected to use HMAT information as hint for optimization. In the linux kernel, the codes in drivers/acpi/hmat/hmat.c parse and report the platform's HMAT tables. The V15 patches link: https://patchwork.kernel.org/cover/11231971/ Changelog: v16: - Add and use qemu_strtold_finite to parse size, support full 64bit precision, modify related test cases (Eduardo and Markus) - Simplify struct HMAT_LB_Info and related code, unify latency and bandwidth (Igor) - Add cross check with hmat_lb data (Igor) - Fields in Cache Attributes are promoted to uint32_t before shifting (Igor) - Add case for QMP build HMAT (Igor) v15: - Add a new patch to refactor do_strtosz() (Eduardo) - Make tests without breaking CI (Michael) v14: - Reuse the codes of do_strtosz to build qemu_strtotime_ns (Eduardo) - Squash patch v13 01/12 and 02/12 together (Daniel and Eduardo) - Drop time unit picosecond (Eric) - Use qemu ctz64 and clz64 instead of builtin function v13: - Modify some text description - Drop "initiator_valid" field in struct NodeInfo - Reuse Garray to store the raw bandwidth and bandwidth data - Calculate common base unit using range bitmap - Add a patch to alculate hmat latency and bandwidth entry list - Drop the total_levels option and use readable cache size - Remove the unnecessary head file - Use decimal notation with appropriate suffix for cache size v12: - Fix a bug that a memory-only node without initiator setting doesn't report error. (reported by Danmei Wei) - Fix a bug that if HMAT is enabled and without hmat-lb setting, QEMU will crash. (reported by Danmei Wei) v11: - Move numa option patches forward. - Add num_initiator in Numa_state to record the number of initiators. - Simplify struct HMAT_LB_Info, use uint64_t array to store data. - Drop hmat_get_base(). - Calculate base in build_hmat_lb(). v10: - Add qemu_strtotime_ps() to convert strings with time suffixes to numbers, and add some tests for it. - Add qapi buildin type time, and add some tests for it. - Add machine oprion properties "-machine hmat=on|off" for enabling or disabling HMAT in QEMU. Liu Jingqi (5): numa: Extend CLI to provide memory latency and bandwidth information numa: Extend CLI to provide memory side cache information hmat acpi: Build Memory Proximity Domain Attributes Structure(s) hmat acpi: Build System Locality Latency and Bandwidth Information Structure(s) hmat acpi: Build Memory Side Cache Information Structure(s) Tao Xu (9): util/cutils: Add Add qemu_strtold and qemu_strtold_finite util/cutils: Use qemu_strtold_finite to parse size util/cutils: refactor do_strtosz() to support suffixes list util/cutils: Add qemu_strtotime_ns() qapi: Add builtin type time tests: Add test for QAPI builtin type time numa: Extend CLI to provide initiator information for numa nodes tests/numa: Add case for QMP build HMAT tests/bios-tables-test: add test cases for ACPI HMAT hw/acpi/Kconfig | 7 +- hw/acpi/Makefile.objs | 1 + hw/acpi/hmat.c | 269 +++++++++++++++++++++++++ hw/acpi/hmat.h | 42 ++++ hw/core/machine.c | 64 ++++++ hw/core/numa.c | 270 ++++++++++++++++++++++++++ hw/i386/acpi-build.c | 5 + include/qapi/visitor-impl.h | 4 + include/qapi/visitor.h | 8 + include/qemu/cutils.h | 4 + include/sysemu/numa.h | 84 ++++++++ qapi/machine.json | 178 ++++++++++++++++- qapi/opts-visitor.c | 22 +++ qapi/qapi-visit-core.c | 12 ++ qapi/qobject-input-visitor.c | 18 ++ qapi/trace-events | 1 + qemu-options.hx | 96 ++++++++- scripts/qapi/schema.py | 1 + tests/bios-tables-test-allowed-diff.h | 8 + tests/bios-tables-test.c | 44 +++++ tests/data/acpi/pc/APIC.acpihmat | 0 tests/data/acpi/pc/DSDT.acpihmat | 0 tests/data/acpi/pc/HMAT.acpihmat | 0 tests/data/acpi/pc/SRAT.acpihmat | 0 tests/data/acpi/q35/APIC.acpihmat | 0 tests/data/acpi/q35/DSDT.acpihmat | 0 tests/data/acpi/q35/HMAT.acpihmat | 0 tests/data/acpi/q35/SRAT.acpihmat | 0 tests/numa-test.c | 51 +++++ tests/test-cutils.c | 214 ++++++++++++++++---- tests/test-keyval.c | 136 +++++++++---- tests/test-qemu-opts.c | 39 +--- tests/test-qobject-input-visitor.c | 29 +++ util/cutils.c | 147 ++++++++++---- 34 files changed, 1596 insertions(+), 158 deletions(-) create mode 100644 hw/acpi/hmat.c create mode 100644 hw/acpi/hmat.h create mode 100644 tests/data/acpi/pc/APIC.acpihmat create mode 100644 tests/data/acpi/pc/DSDT.acpihmat create mode 100644 tests/data/acpi/pc/HMAT.acpihmat create mode 100644 tests/data/acpi/pc/SRAT.acpihmat create mode 100644 tests/data/acpi/q35/APIC.acpihmat create mode 100644 tests/data/acpi/q35/DSDT.acpihmat create mode 100644 tests/data/acpi/q35/HMAT.acpihmat create mode 100644 tests/data/acpi/q35/SRAT.acpihmat