| Message ID | 20200112124913.94959-1-ysato@users.sourceforge.jp (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add RX archtecture support | expand |
Patchew URL: https://patchew.org/QEMU/20200112124913.94959-1-ysato@users.sourceforge.jp/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH v28 00/22] Add RX archtecture support
Type: series
Message-id: 20200112124913.94959-1-ysato@users.sourceforge.jp
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
026424c qemu-doc.texi: Add RX section.
43df918 BootLinuxConsoleTest: Test the RX-Virt machine
a569f77 Add rx-softmmu
8f12a47 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
02960cc hw/rx: Honor -accel qtest
9d25ce1 hw/rx: RX Target hardware definition
54ad24f hw/char: RX62N serial communication interface (SCI)
3d02ca6 hw/timer: RX62N internal timer modules
e0ba72f hw/intc: RX62N interrupt controller (ICUa)
5620d0b target/rx: Dump bytes for each insn during disassembly
f60e312 target/rx: Collect all bytes during disassembly
a0f74d3 target/rx: Emit all disassembly in one prt()
e652144 target/rx: Use prt_ldmi for XCHG_mr disassembly
7f42d50 target/rx: Replace operand with prt_ldmi in disassembler
bff2d28 target/rx: Disassemble rx_index_addr into a string
7e2a7a9 target/rx: RX disassembler
beab025 target/rx: CPU definition
2ef24ae target/rx: TCG helper
5269786 target/rx: TCG translation
7ef5260 hw/registerfields.h: Add 8bit and 16bit register macros
48a408f qemu/bitops.h: Add extract8 and extract16
940bb87 MAINTAINERS: Add RX
=== OUTPUT BEGIN ===
1/22 Checking commit 940bb8785a47 (MAINTAINERS: Add RX)
2/22 Checking commit 48a408ff9633 (qemu/bitops.h: Add extract8 and extract16)
3/22 Checking commit 7ef5260d756d (hw/registerfields.h: Add 8bit and 16bit register macros)
Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2484.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr) \
+ enum { A_ ## reg = (addr) }; \
+ enum { R_ ## reg = (addr) };
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr) \
+ enum { A_ ## reg = (addr) }; \
+ enum { R_ ## reg = (addr) / 2 };
total: 2 errors, 0 warnings, 56 lines checked
Patch 3/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/22 Checking commit 52697860d4d7 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20:
new file mode 100644
total: 0 errors, 1 warnings, 3065 lines checked
Patch 4/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/22 Checking commit 2ef24aef4583 (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21:
new file mode 100644
total: 0 errors, 1 warnings, 650 lines checked
Patch 5/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/22 Checking commit beab0251cc7e (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#32:
new file mode 100644
total: 0 errors, 1 warnings, 588 lines checked
Patch 6/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/22 Checking commit 7e2a7a9e4f15 (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38:
new file mode 100644
total: 0 errors, 1 warnings, 1497 lines checked
Patch 7/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/22 Checking commit bff2d286fd76 (target/rx: Disassemble rx_index_addr into a string)
9/22 Checking commit 7f42d5046602 (target/rx: Replace operand with prt_ldmi in disassembler)
10/22 Checking commit e65214408839 (target/rx: Use prt_ldmi for XCHG_mr disassembly)
11/22 Checking commit a0f74d308947 (target/rx: Emit all disassembly in one prt())
12/22 Checking commit f60e3125f8cf (target/rx: Collect all bytes during disassembly)
13/22 Checking commit 5620d0b56a27 (target/rx: Dump bytes for each insn during disassembly)
14/22 Checking commit e0ba72f7b818 (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40:
new file mode 100644
total: 0 errors, 1 warnings, 445 lines checked
Patch 14/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/22 Checking commit 3d02ca6d4ed0 (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50:
new file mode 100644
total: 0 errors, 1 warnings, 845 lines checked
Patch 15/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/22 Checking commit 54ad24f6d086 (hw/char: RX62N serial communication interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43:
new file mode 100644
total: 0 errors, 1 warnings, 401 lines checked
Patch 16/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/22 Checking commit 9d25ce1b9164 (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29:
new file mode 100644
total: 0 errors, 1 warnings, 480 lines checked
Patch 17/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/22 Checking commit 02960ccac4dd (hw/rx: Honor -accel qtest)
19/22 Checking commit 8f12a475f061 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core)
20/22 Checking commit a569f776aadc (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#59:
new file mode 100644
total: 0 errors, 1 warnings, 74 lines checked
Patch 20/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/22 Checking commit 43df9187c8b7 (BootLinuxConsoleTest: Test the RX-Virt machine)
22/22 Checking commit 026424ca5ceb (qemu-doc.texi: Add RX section.)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20200112124913.94959-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20200112124913.94959-1-ysato@users.sourceforge.jp/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH v28 00/22] Add RX archtecture support
Type: series
Message-id: 20200112124913.94959-1-ysato@users.sourceforge.jp
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Switched to a new branch 'test'
9c8993a qemu-doc.texi: Add RX section.
b31e438 BootLinuxConsoleTest: Test the RX-Virt machine
94d50a2 Add rx-softmmu
5d809ac hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
cfae030 hw/rx: Honor -accel qtest
65c9f90 hw/rx: RX Target hardware definition
5cc9572 hw/char: RX62N serial communication interface (SCI)
56dc57a hw/timer: RX62N internal timer modules
4378db2 hw/intc: RX62N interrupt controller (ICUa)
b692705 target/rx: Dump bytes for each insn during disassembly
32dc7d6 target/rx: Collect all bytes during disassembly
0257d0f target/rx: Emit all disassembly in one prt()
38fc5ec target/rx: Use prt_ldmi for XCHG_mr disassembly
7770d4e target/rx: Replace operand with prt_ldmi in disassembler
04f0e2e target/rx: Disassemble rx_index_addr into a string
60f3f19 target/rx: RX disassembler
a5da94c target/rx: CPU definition
017772d target/rx: TCG helper
9ff83af target/rx: TCG translation
7388b99 hw/registerfields.h: Add 8bit and 16bit register macros
9c71fe7 qemu/bitops.h: Add extract8 and extract16
e31179b MAINTAINERS: Add RX
=== OUTPUT BEGIN ===
1/22 Checking commit e31179b04884 (MAINTAINERS: Add RX)
2/22 Checking commit 9c71fe7faec8 (qemu/bitops.h: Add extract8 and extract16)
3/22 Checking commit 7388b996fcc3 (hw/registerfields.h: Add 8bit and 16bit register macros)
Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2484.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr) \
+ enum { A_ ## reg = (addr) }; \
+ enum { R_ ## reg = (addr) };
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr) \
+ enum { A_ ## reg = (addr) }; \
+ enum { R_ ## reg = (addr) / 2 };
total: 2 errors, 0 warnings, 56 lines checked
Patch 3/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/22 Checking commit 9ff83afa1af6 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20:
new file mode 100644
total: 0 errors, 1 warnings, 3065 lines checked
Patch 4/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/22 Checking commit 017772d3798b (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21:
new file mode 100644
total: 0 errors, 1 warnings, 650 lines checked
Patch 5/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/22 Checking commit a5da94c91154 (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#32:
new file mode 100644
total: 0 errors, 1 warnings, 588 lines checked
Patch 6/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/22 Checking commit 60f3f191676e (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38:
new file mode 100644
total: 0 errors, 1 warnings, 1497 lines checked
Patch 7/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/22 Checking commit 04f0e2e75777 (target/rx: Disassemble rx_index_addr into a string)
9/22 Checking commit 7770d4e19c0d (target/rx: Replace operand with prt_ldmi in disassembler)
10/22 Checking commit 38fc5ec9ace5 (target/rx: Use prt_ldmi for XCHG_mr disassembly)
11/22 Checking commit 0257d0f103e0 (target/rx: Emit all disassembly in one prt())
12/22 Checking commit 32dc7d60b331 (target/rx: Collect all bytes during disassembly)
13/22 Checking commit b692705e6235 (target/rx: Dump bytes for each insn during disassembly)
14/22 Checking commit 4378db2a66e8 (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40:
new file mode 100644
total: 0 errors, 1 warnings, 445 lines checked
Patch 14/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/22 Checking commit 56dc57aa2790 (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50:
new file mode 100644
total: 0 errors, 1 warnings, 845 lines checked
Patch 15/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/22 Checking commit 5cc9572f03fe (hw/char: RX62N serial communication interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43:
new file mode 100644
total: 0 errors, 1 warnings, 401 lines checked
Patch 16/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/22 Checking commit 65c9f907615e (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29:
new file mode 100644
total: 0 errors, 1 warnings, 480 lines checked
Patch 17/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/22 Checking commit cfae030bd281 (hw/rx: Honor -accel qtest)
19/22 Checking commit 5d809acd600a (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core)
20/22 Checking commit 94d50a285a1a (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#59:
new file mode 100644
total: 0 errors, 1 warnings, 74 lines checked
Patch 20/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/22 Checking commit b31e43883b74 (BootLinuxConsoleTest: Test the RX-Virt machine)
22/22 Checking commit 9c8993a0b033 (qemu-doc.texi: Add RX section.)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20200112124913.94959-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Hello. This patch series is added Renesas RX target emulation. Changes for v27. Added RX section to qemu-doc. Rebase for master Changes for v26. Rebase for 5.0 Update machine.json for 5.0 Changes for v25. Update commit message. Squashed qapi/machine.json changes. Changes for v24. Add note for qapi/machine.json. Added Acked-by for 6/22. git rebase master. Changes for v23. Follow master changes. Changes for v22. Added some include. Changes for v21. rebase latest master. Remove unneeded hmp_info_tlb. Chanegs for v20. Reorderd patches. Squashed v19 changes. Changes for v19. Follow tcg changes. Cleanup cpu.c. simplify rx_cpu_class_by_name and rx_load_image move to rx-virt. My git repository is bellow. git://git.pf.osdn.net/gitroot/y/ys/ysato/qemu.git tags/rx-20200112 Testing binaries bellow. u-boot Download - https://osdn.net/users/ysato/pf/qemu/dl/u-boot.bin.gz starting $ gzip -d u-boot.bin.gz $ qemu-system-rx -bios u-boot.bin linux and pico-root (only sash) Download - https://osdn.net/users/ysato/pf/qemu/dl/zImage (kernel) https://osdn.net/users/ysato/pf/qemu/dl/rx-qemu.dtb (DeviceTree) starting $ qemu-system-rx -kernel zImage -dtb rx-qemu.dtb -append "earlycon" Philippe Mathieu-Daudé (3): hw/registerfields.h: Add 8bit and 16bit register macros hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core BootLinuxConsoleTest: Test the RX-Virt machine Richard Henderson (7): target/rx: Disassemble rx_index_addr into a string target/rx: Replace operand with prt_ldmi in disassembler target/rx: Use prt_ldmi for XCHG_mr disassembly target/rx: Emit all disassembly in one prt() target/rx: Collect all bytes during disassembly target/rx: Dump bytes for each insn during disassembly hw/rx: Honor -accel qtest Yoshinori Sato (12): MAINTAINERS: Add RX qemu/bitops.h: Add extract8 and extract16 target/rx: TCG translation target/rx: TCG helper target/rx: CPU definition target/rx: RX disassembler hw/intc: RX62N interrupt controller (ICUa) hw/timer: RX62N internal timer modules hw/char: RX62N serial communication interface (SCI) hw/rx: RX Target hardware definition Add rx-softmmu qemu-doc.texi: Add RX section. qemu-doc.texi | 25 + configure | 8 + default-configs/rx-softmmu.mak | 3 + qapi/machine.json | 3 +- include/disas/dis-asm.h | 5 + include/exec/poison.h | 1 + include/hw/char/renesas_sci.h | 45 + include/hw/intc/rx_icu.h | 56 + include/hw/registerfields.h | 32 +- include/hw/rx/rx.h | 7 + include/hw/rx/rx62n.h | 91 + include/hw/timer/renesas_cmt.h | 38 + include/hw/timer/renesas_tmr.h | 53 + include/qemu/bitops.h | 38 + include/sysemu/arch_init.h | 1 + target/rx/cpu-param.h | 31 + target/rx/cpu-qom.h | 42 + target/rx/cpu.h | 181 ++ target/rx/helper.h | 31 + arch_init.c | 2 + hw/char/renesas_sci.c | 343 ++++ hw/intc/rx_icu.c | 379 ++++ hw/rx/rx-virt.c | 135 ++ hw/rx/rx62n.c | 247 +++ hw/timer/renesas_cmt.c | 278 +++ hw/timer/renesas_tmr.c | 458 +++++ target/rx/cpu.c | 217 +++ target/rx/disas.c | 1446 ++++++++++++++ target/rx/gdbstub.c | 112 ++ target/rx/helper.c | 149 ++ target/rx/op_helper.c | 470 +++++ target/rx/translate.c | 2432 ++++++++++++++++++++++++ tests/machine-none-test.c | 1 + MAINTAINERS | 19 + hw/Kconfig | 1 + hw/char/Kconfig | 3 + hw/char/Makefile.objs | 1 + hw/intc/Kconfig | 3 + hw/intc/Makefile.objs | 1 + hw/rx/Kconfig | 14 + hw/rx/Makefile.objs | 2 + hw/timer/Kconfig | 6 + hw/timer/Makefile.objs | 3 + target/rx/Makefile.objs | 11 + target/rx/insns.decode | 621 ++++++ tests/acceptance/boot_linux_console.py | 47 + 46 files changed, 8090 insertions(+), 2 deletions(-) create mode 100644 default-configs/rx-softmmu.mak create mode 100644 include/hw/char/renesas_sci.h create mode 100644 include/hw/intc/rx_icu.h create mode 100644 include/hw/rx/rx.h create mode 100644 include/hw/rx/rx62n.h create mode 100644 include/hw/timer/renesas_cmt.h create mode 100644 include/hw/timer/renesas_tmr.h create mode 100644 target/rx/cpu-param.h create mode 100644 target/rx/cpu-qom.h create mode 100644 target/rx/cpu.h create mode 100644 target/rx/helper.h create mode 100644 hw/char/renesas_sci.c create mode 100644 hw/intc/rx_icu.c create mode 100644 hw/rx/rx-virt.c create mode 100644 hw/rx/rx62n.c create mode 100644 hw/timer/renesas_cmt.c create mode 100644 hw/timer/renesas_tmr.c create mode 100644 target/rx/cpu.c create mode 100644 target/rx/disas.c create mode 100644 target/rx/gdbstub.c create mode 100644 target/rx/helper.c create mode 100644 target/rx/op_helper.c create mode 100644 target/rx/translate.c create mode 100644 hw/rx/Kconfig create mode 100644 hw/rx/Makefile.objs create mode 100644 target/rx/Makefile.objs create mode 100644 target/rx/insns.decode