[v2,0/5] python/qemu: qmp: Fix, delint and improvements

Message

Wainer dos Santos Moschetta Feb. 4, 2020, 2:11 p.m. UTC

I started fixing an issue on exception handling which in some places
currently use the deprecated (in Python 3.3) `socket.error`. Then I
ended up delinting the module code and making some improvements.

Changes in v2:
- Rebased to master. No conflicts.
- Added docstring describing the allowed value of the new `timeout`
  option in accept() (patch 03) [jsnow]
- Set the new `timeout` option to 15.0 by default [philmd]

v1: https://www.mail-archive.com/[e-mail]/msg667479.html

Git:
- Tree: https://github.com/wainersm/qemu
- Branch: python_qmp_sockets_error-v2

CI:
- Travis (FAIL): https://travis-ci.org/wainersm/qemu/builds/645583812
  Jobs failures aren't related with these changes


Wainer dos Santos Moschetta (5):
  python/qemu: qmp: Replace socket.error with OSError
  python/qemu: Delint the qmp module
  python/qemu: qmp: Make accept()'s timeout configurable
  python/qemu: qmp: Make QEMUMonitorProtocol a context manager
  python/qemu: qmp: Remove unnused attributes

 python/qemu/qmp.py | 97 +++++++++++++++++++++++++++++++++-------------
 1 file changed, 71 insertions(+), 26 deletions(-)

Comments

Philippe Mathieu-Daudé Feb. 6, 2020, 2:52 p.m. UTC | #1

On 2/4/20 3:11 PM, Wainer dos Santos Moschetta wrote:
> I started fixing an issue on exception handling which in some places
> currently use the deprecated (in Python 3.3) `socket.error`. Then I
> ended up delinting the module code and making some improvements.
> 
> Changes in v2:
> - Rebased to master. No conflicts.
> - Added docstring describing the allowed value of the new `timeout`
>    option in accept() (patch 03) [jsnow]
> - Set the new `timeout` option to 15.0 by default [philmd]
> 
> v1: https://www.mail-archive.com/[e-mail]/msg667479.html
> 
> Git:
> - Tree: https://github.com/wainersm/qemu
> - Branch: python_qmp_sockets_error-v2
> 
> CI:
> - Travis (FAIL): https://travis-ci.org/wainersm/qemu/builds/645583812
>    Jobs failures aren't related with these changes
> 
> 
> Wainer dos Santos Moschetta (5):
>    python/qemu: qmp: Replace socket.error with OSError
>    python/qemu: Delint the qmp module
>    python/qemu: qmp: Make accept()'s timeout configurable
>    python/qemu: qmp: Make QEMUMonitorProtocol a context manager
>    python/qemu: qmp: Remove unnused attributes
> 
>   python/qemu/qmp.py | 97 +++++++++++++++++++++++++++++++++-------------
>   1 file changed, 71 insertions(+), 26 deletions(-)
> 

Patches 3 and 4 applied to my python-next tree:
https://gitlab.com/philmd/qemu/commits/python-next