| Message ID | 20200215122354.13706-1-linux@roeck-us.net (mailing list archive) |
|---|---|
| Headers | show |
| Series | hw/arm/xilinx_zynq: Fix USB port instantiation | expand |
On Sat, Feb 15, 2020 at 04:23:52AM -0800, Guenter Roeck wrote: > USB ports on Xilinx Zync must be instantiated as TYPE_CHIPIDEA to work. > Linux expects and checks various chipidea registers, which do not exist > with the basic ehci emulation. This patch series fixes the problem. > > The first patch in the series fixes the actual problem. > > The second patch removes the now obsolete explicit Xilinx > support from the EHCI code. Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
On Sat, 15 Feb 2020 at 12:23, Guenter Roeck <linux@roeck-us.net> wrote: > > USB ports on Xilinx Zync must be instantiated as TYPE_CHIPIDEA to work. > Linux expects and checks various chipidea registers, which do not exist > with the basic ehci emulation. This patch series fixes the problem. > > The first patch in the series fixes the actual problem. > > The second patch removes the now obsolete explicit Xilinx > support from the EHCI code. > > v2: Introduced summary > > ---------------------------------------------------------------- > Guenter Roeck (2): > hw/arm/xilinx_zynq: Fix USB port instantiation > hw/usb/hcd-ehci-sysbus: Remove obsolete xlnx,ps7-usb class Xilinx folks -- could you provide a reviewed-by or acked-by for this series, please? thanks -- PMM
On Thu, 20 Feb 2020 at 15:05, Peter Maydell <peter.maydell@linaro.org> wrote: > > On Sat, 15 Feb 2020 at 12:23, Guenter Roeck <linux@roeck-us.net> wrote: > > > > USB ports on Xilinx Zync must be instantiated as TYPE_CHIPIDEA to work. > > Linux expects and checks various chipidea registers, which do not exist > > with the basic ehci emulation. This patch series fixes the problem. > > > > The first patch in the series fixes the actual problem. > > > > The second patch removes the now obsolete explicit Xilinx > > support from the EHCI code. > > > > v2: Introduced summary > > > > ---------------------------------------------------------------- > > Guenter Roeck (2): > > hw/arm/xilinx_zynq: Fix USB port instantiation > > hw/usb/hcd-ehci-sysbus: Remove obsolete xlnx,ps7-usb class > > Xilinx folks -- could you provide a reviewed-by or acked-by > for this series, please? No? Oh, well, applied to target-arm.next anyway. thanks -- PMM
Sorry Peter, I missed the email. Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> Best regards, Edgar On Fri, 28 Feb. 2020, 10:00 Peter Maydell, <peter.maydell@linaro.org> wrote: > On Thu, 20 Feb 2020 at 15:05, Peter Maydell <peter.maydell@linaro.org> > wrote: > > > > On Sat, 15 Feb 2020 at 12:23, Guenter Roeck <linux@roeck-us.net> wrote: > > > > > > USB ports on Xilinx Zync must be instantiated as TYPE_CHIPIDEA to work. > > > Linux expects and checks various chipidea registers, which do not exist > > > with the basic ehci emulation. This patch series fixes the problem. > > > > > > The first patch in the series fixes the actual problem. > > > > > > The second patch removes the now obsolete explicit Xilinx > > > support from the EHCI code. > > > > > > v2: Introduced summary > > > > > > ---------------------------------------------------------------- > > > Guenter Roeck (2): > > > hw/arm/xilinx_zynq: Fix USB port instantiation > > > hw/usb/hcd-ehci-sysbus: Remove obsolete xlnx,ps7-usb class > > > > Xilinx folks -- could you provide a reviewed-by or acked-by > > for this series, please? > > No? Oh, well, applied to target-arm.next anyway. > > thanks > -- PMM >
On Fri, Feb 28, 2020 at 12:44:19PM -0600, Edgar E. Iglesias wrote: > Sorry Peter, I missed the email. > > Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> > Thanks a lot everyone! Guenter > Best regards, > Edgar > > > On Fri, 28 Feb. 2020, 10:00 Peter Maydell, <peter.maydell@linaro.org> wrote: > > > On Thu, 20 Feb 2020 at 15:05, Peter Maydell <peter.maydell@linaro.org> > > wrote: > > > > > > On Sat, 15 Feb 2020 at 12:23, Guenter Roeck <linux@roeck-us.net> wrote: > > > > > > > > USB ports on Xilinx Zync must be instantiated as TYPE_CHIPIDEA to work. > > > > Linux expects and checks various chipidea registers, which do not exist > > > > with the basic ehci emulation. This patch series fixes the problem. > > > > > > > > The first patch in the series fixes the actual problem. > > > > > > > > The second patch removes the now obsolete explicit Xilinx > > > > support from the EHCI code. > > > > > > > > v2: Introduced summary > > > > > > > > ---------------------------------------------------------------- > > > > Guenter Roeck (2): > > > > hw/arm/xilinx_zynq: Fix USB port instantiation > > > > hw/usb/hcd-ehci-sysbus: Remove obsolete xlnx,ps7-usb class > > > > > > Xilinx folks -- could you provide a reviewed-by or acked-by > > > for this series, please? > > > > No? Oh, well, applied to target-arm.next anyway. > > > > thanks > > -- PMM > >
USB ports on Xilinx Zync must be instantiated as TYPE_CHIPIDEA to work. Linux expects and checks various chipidea registers, which do not exist with the basic ehci emulation. This patch series fixes the problem. The first patch in the series fixes the actual problem. The second patch removes the now obsolete explicit Xilinx support from the EHCI code. v2: Introduced summary ---------------------------------------------------------------- Guenter Roeck (2): hw/arm/xilinx_zynq: Fix USB port instantiation hw/usb/hcd-ehci-sysbus: Remove obsolete xlnx,ps7-usb class hw/arm/xilinx_zynq.c | 5 +++-- hw/usb/hcd-ehci-sysbus.c | 17 ----------------- 2 files changed, 3 insertions(+), 19 deletions(-)