mbox series

[v8,00/14] target/mips: MSA, FPU and other cleanups and improvements

Message ID 20200613152133.8964-1-aleksandar.qemu.devel@gmail.com (mailing list archive)
Headers show
Series target/mips: MSA, FPU and other cleanups and improvements | expand

Message

Aleksandar Markovic June 13, 2020, 3:21 p.m. UTC
This series contains some patches that split heprers in msa_helper.c.
It will make easier for debugging tools to display involved source
code, and also introduces some modest performance improvements gains
for all involved MSA instructions.

v7->v8:

  - added six new demacroing patches

v6->v7:

  - excluded patches that have been already upstreamed
  - added six new demacroing patches

v5->v6:

  - excluded a patch that was included by mistake

v4->v5:

  - corrected some spelling and style mistakes in commit messages
  - added changing MAINTAINERS too while renaming files
  - added two patches on splitting helpers in msa_helper.c

v3->v4:

  - corrected some spelling and style mistakes in commit messages
  - added a patch on renaming some files in hw/mips

v2->v3:

  - changed Malta patch to perform logging
  - added change of Aleksandar Rikalo's email

v1->v2:

  - added more demacroing

Aleksandar Markovic (14):
  target/mips: msa: Split helpers for MADDV.<B|H|W|D>
  target/mips: msa: Split helpers for MSUBV.<B|H|W|D>
  target/mips: msa: Split helpers for DPADD_S.<H|W|D>
  target/mips: msa: Split helpers for DPADD_U.<H|W|D>
  target/mips: msa: Split helpers for DPSUB_S.<H|W|D>
  target/mips: msa: Split helpers for DPSUB_U.<H|W|D>
  target/mips: msa: Split helpers for DOTP_S.<H|W|D>
  target/mips: msa: Split helpers for DOTP_U.<H|W|D>
  target/mips: msa: Split helpers for SUBS_S.<B|H|W|D>
  target/mips: msa: Split helpers for SUBS_U.<B|H|W|D>
  target/mips: msa: Split helpers for SUBSUS_U.<B|H|W|D>
  target/mips: msa: Split helpers for SUBSUU_S.<B|H|W|D>
  target/mips: msa: Split helpers for SUBV.<B|H|W|D>
  target/mips: msa: Split helpers for MULV.<B|H|W|D>

 target/mips/helper.h     |   73 ++-
 target/mips/msa_helper.c | 1296 ++++++++++++++++++++++++++++++--------
 target/mips/translate.c  |  200 +++++-
 3 files changed, 1271 insertions(+), 298 deletions(-)

Comments

Aleksandar Rikalo June 15, 2020, 10:16 a.m. UTC | #1
> This series contains some patches that split heprers in msa_helper.c.
> It will make easier for debugging tools to display involved source
> code, and also introduces some modest performance improvements gains
> for all involved MSA instructions.
>
> v7->v8:
>
>    - added six new demacroing patches
>
> v6->v7:
>
>    - excluded patches that have been already upstreamed
>    - added six new demacroing patches
>
> v5->v6:
>
>    - excluded a patch that was included by mistake
>
> v4->v5:
>
>    - corrected some spelling and style mistakes in commit messages
>    - added changing MAINTAINERS too while renaming files
>    - added two patches on splitting helpers in msa_helper.c
>
> v3->v4:
>
>    - corrected some spelling and style mistakes in commit messages
>    - added a patch on renaming some files in hw/mips
>
> v2->v3:
>
>    - changed Malta patch to perform logging
>    - added change of Aleksandar Rikalo's email
>
> v1->v2:
>
>    - added more demacroing
>
> Aleksandar Markovic (14):
>    target/mips: msa: Split helpers for MADDV.<B|H|W|D>
>    target/mips: msa: Split helpers for MSUBV.<B|H|W|D>
>    target/mips: msa: Split helpers for DPADD_S.<H|W|D>
>    target/mips: msa: Split helpers for DPADD_U.<H|W|D>
>    target/mips: msa: Split helpers for DPSUB_S.<H|W|D>
>    target/mips: msa: Split helpers for DPSUB_U.<H|W|D>
>    target/mips: msa: Split helpers for DOTP_S.<H|W|D>
>    target/mips: msa: Split helpers for DOTP_U.<H|W|D>
>    target/mips: msa: Split helpers for SUBS_S.<B|H|W|D>
>    target/mips: msa: Split helpers for SUBS_U.<B|H|W|D>
>    target/mips: msa: Split helpers for SUBSUS_U.<B|H|W|D>
>    target/mips: msa: Split helpers for SUBSUU_S.<B|H|W|D>
>    target/mips: msa: Split helpers for SUBV.<B|H|W|D>
>    target/mips: msa: Split helpers for MULV.<B|H|W|D>
>
>   target/mips/helper.h     |   73 ++-
>   target/mips/msa_helper.c | 1296 ++++++++++++++++++++++++++++++--------
>   target/mips/translate.c  |  200 +++++-
>   3 files changed, 1271 insertions(+), 298 deletions(-)
>
For the whole series:
Reviewed-by: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>

Please run all regression tests. Thank you.

Aleksandar Rikalo
Aleksandar Markovic June 15, 2020, 7:14 p.m. UTC | #2
On Sat, Jun 13, 2020 at 5:22 PM Aleksandar Markovic
<aleksandar.qemu.devel@gmail.com> wrote:
>
> This series contains some patches that split heprers in msa_helper.c.
> It will make easier for debugging tools to display involved source
> code, and also introduces some modest performance improvements gains
> for all involved MSA instructions.
>

Applied to MIPS+misc queue.

> v7->v8:
>
>   - added six new demacroing patches
>
> v6->v7:
>
>   - excluded patches that have been already upstreamed
>   - added six new demacroing patches
>
> v5->v6:
>
>   - excluded a patch that was included by mistake
>
> v4->v5:
>
>   - corrected some spelling and style mistakes in commit messages
>   - added changing MAINTAINERS too while renaming files
>   - added two patches on splitting helpers in msa_helper.c
>
> v3->v4:
>
>   - corrected some spelling and style mistakes in commit messages
>   - added a patch on renaming some files in hw/mips
>
> v2->v3:
>
>   - changed Malta patch to perform logging
>   - added change of Aleksandar Rikalo's email
>
> v1->v2:
>
>   - added more demacroing
>
> Aleksandar Markovic (14):
>   target/mips: msa: Split helpers for MADDV.<B|H|W|D>
>   target/mips: msa: Split helpers for MSUBV.<B|H|W|D>
>   target/mips: msa: Split helpers for DPADD_S.<H|W|D>
>   target/mips: msa: Split helpers for DPADD_U.<H|W|D>
>   target/mips: msa: Split helpers for DPSUB_S.<H|W|D>
>   target/mips: msa: Split helpers for DPSUB_U.<H|W|D>
>   target/mips: msa: Split helpers for DOTP_S.<H|W|D>
>   target/mips: msa: Split helpers for DOTP_U.<H|W|D>
>   target/mips: msa: Split helpers for SUBS_S.<B|H|W|D>
>   target/mips: msa: Split helpers for SUBS_U.<B|H|W|D>
>   target/mips: msa: Split helpers for SUBSUS_U.<B|H|W|D>
>   target/mips: msa: Split helpers for SUBSUU_S.<B|H|W|D>
>   target/mips: msa: Split helpers for SUBV.<B|H|W|D>
>   target/mips: msa: Split helpers for MULV.<B|H|W|D>
>
>  target/mips/helper.h     |   73 ++-
>  target/mips/msa_helper.c | 1296 ++++++++++++++++++++++++++++++--------
>  target/mips/translate.c  |  200 +++++-
>  3 files changed, 1271 insertions(+), 298 deletions(-)
>
> --
> 2.20.1
>
>