[RFC,0/5] Use ACPI PCI hot-plug for q35

Message

Julia Suvorova July 8, 2020, 10:46 p.m. UTC

PCIe native hot-plug has numerous problems with racing events and unpredictable
guest behaviour (Windows). Switching to ACPI hot-plug for now.

Tested on RHEL 8 and Windows 2019.

pxb-pcie is not yet supported.

Julia Suvorova (5):
  hw/acpi/pcihp: Introduce find_host()
  hw/acpi/ich9: Trace ich9_gpe_readb()/writeb()
  hw/i386/acpi-build: Add ACPI PCI hot-plug methods to q35
  hw/i386/acpi-build: Turn off support of PCIe native hot-plug and SHPC
    in _OSC
  hw/acpi/ich9: Enable ACPI PCI hot-plug

 hw/i386/acpi-build.h   |  2 ++
 include/hw/acpi/ich9.h |  3 +++
 hw/acpi/ich9.c         | 52 +++++++++++++++++++++++++++++++++++++++++-
 hw/acpi/pcihp.c        | 16 ++++++++++++-
 hw/i386/acpi-build.c   | 34 +++++++++++++++++----------
 hw/i386/pc.c           |  4 +++-
 hw/acpi/trace-events   |  4 ++++
 7 files changed, 100 insertions(+), 15 deletions(-)

Comments

[e-mail] July 8, 2020, 11:29 p.m. UTC | #1

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

  CC      hw/acpi/tpm.o
  CC      hw/acpi/ipmi.o
/tmp/qemu-test/src/hw/acpi/ich9.c: In function 'ich9_pm_init':
/tmp/qemu-test/src/hw/acpi/ich9.c:315:34: error: too many arguments to function 'qbus_set_hotplug_handler'
                                  &error_abort);
                                  ^
In file included from /tmp/qemu-test/src/include/hw/isa/isa.h:8:0,
---
 void qbus_set_hotplug_handler(BusState *bus, Object *handler);
      ^
  CC      hw/acpi/acpi-stub.o
make: *** [hw/acpi/ich9.o] Error 1
make: *** Waiting for unfinished jobs....
  CC      hw/acpi/aml-build-stub.o
Traceback (most recent call last):
---
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=e8dad3af07f046e6acc07d5aab1854b9', '-u', '1001', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-_j3k8sfi/src/docker-src.2020-07-08-19.27.02.11252:/var/tmp/qemu:z,ro', 'qemu:centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit status 2.
filter=--filter=label=com.qemu.instance.uuid=e8dad3af07f046e6acc07d5aab1854b9
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-_j3k8sfi/src'
make: *** [docker-run-test-quick@centos7] Error 2

real    2m25.350s
user    0m8.686s


The full log is available at
http://patchew.org/logs/[e-mail]/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [e-mail]

[e-mail] July 8, 2020, 11:33 p.m. UTC | #2

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series failed the docker-mingw@fedora build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#! /bin/bash
export ARCH=x86_64
make docker-image-fedora V=1 NETWORK=1
time make docker-test-mingw@fedora J=14 NETWORK=1
=== TEST SCRIPT END ===

  CC      hw/acpi/acpi_interface.o
  CC      hw/acpi/bios-linker-loader.o
/tmp/qemu-test/src/hw/acpi/ich9.c: In function 'ich9_pm_init':
/tmp/qemu-test/src/hw/acpi/ich9.c:313:9: error: too many arguments to function 'qbus_set_hotplug_handler'
  313 |         qbus_set_hotplug_handler(BUS(pci_get_bus(lpc_pci)),
      |         ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from /tmp/qemu-test/src/include/hw/isa/isa.h:8,
---
/tmp/qemu-test/src/include/hw/qdev-core.h:538:6: note: declared here
  538 | void qbus_set_hotplug_handler(BusState *bus, Object *handler);
      |      ^~~~~~~~~~~~~~~~~~~~~~~~
make: *** [/tmp/qemu-test/src/rules.mak:69: hw/acpi/ich9.o] Error 1
make: *** Waiting for unfinished jobs....
  CC      hw/acpi/aml-build.o
Traceback (most recent call last):
---
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=f40198b991eb4bf4a15cccbf81eccbf5', '-u', '1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-tvkth6at/src/docker-src.2020-07-08-19.30.00.18172:/var/tmp/qemu:z,ro', 'qemu:fedora', '/var/tmp/qemu/run', 'test-mingw']' returned non-zero exit status 2.
filter=--filter=label=com.qemu.instance.uuid=f40198b991eb4bf4a15cccbf81eccbf5
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-tvkth6at/src'
make: *** [docker-run-test-mingw@fedora] Error 2

real    3m32.203s
user    0m8.424s


The full log is available at
http://patchew.org/logs/[e-mail]/testing.docker-mingw@fedora/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [e-mail]