[0/2] tracetool: fix log-stap format

Message

Laurent Vivier Jan. 5, 2021, 7:17 p.m. UTC

The first patch fixes a problem I have introduced in vhost-vdpa
traces by adding an unsupported format ("%llu").

The second patch fixes a problem I've seen while I was checking
the result of the first patch: %PRI formats are not decoded
correctly and we can end with things like "0x%u" because
the used format is always the one of the first format of the string.

Laurent Vivier (2):
  vhost-vdpa: fix "unsigned long long" error with stap
  tracetool: fix "PRI" macro decoding

 hw/virtio/trace-events               | 2 +-
 hw/virtio/vhost-vdpa.c               | 4 ++--
 scripts/tracetool/format/log_stap.py | 1 +
 3 files changed, 4 insertions(+), 3 deletions(-)

Comments

Philippe Mathieu-Daudé Jan. 5, 2021, 7:44 p.m. UTC | #1

On 1/5/21 8:17 PM, Laurent Vivier wrote:
> The first patch fixes a problem I have introduced in vhost-vdpa
> traces by adding an unsupported format ("%llu").
> 
> The second patch fixes a problem I've seen while I was checking
> the result of the first patch: %PRI formats are not decoded
> correctly and we can end with things like "0x%u" because
> the used format is always the one of the first format of the string.
> 
> Laurent Vivier (2):
>   vhost-vdpa: fix "unsigned long long" error with stap
>   tracetool: fix "PRI" macro decoding
> 
>  hw/virtio/trace-events               | 2 +-
>  hw/virtio/vhost-vdpa.c               | 4 ++--
>  scripts/tracetool/format/log_stap.py | 1 +
>  3 files changed, 4 insertions(+), 3 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <[e-mail]>