From patchwork Wed Jan 13 14:06:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Max Reitz X-Patchwork-Id: 12016891 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDF43C433E0 for ; Wed, 13 Jan 2021 14:17:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B6BE233FD for ; Wed, 13 Jan 2021 14:17:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B6BE233FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59680 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kzgxw-0004UG-8I for qemu-devel@archiver.kernel.org; Wed, 13 Jan 2021 09:17:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49034) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzgnI-0002xJ-S6 for qemu-devel@nongnu.org; Wed, 13 Jan 2021 09:06:44 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:29839) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kzgn3-0003Xw-06 for qemu-devel@nongnu.org; Wed, 13 Jan 2021 09:06:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610546782; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=46Q08HyWUZ/ZVfJVQZ4DEqdROPwYepYeeZ59SFyUJ08=; b=UBnlCTzw9nmQQFNodmL2N9/3rs7aZY4YPo0gv0++2xDWRqe6RJJkVoxdD2ZeYiSkY4x6i2 YGkF+ApD3TFgH2wuBxQqygoWHClZccJOgPxuVO0xlV0yjJF24Mu3PRti4G60NsES4n3ggT heSATGnQUQ+o7UjYe1aGBIcX5f5PnEI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-346-4QuH7xEkPXqvMYbLKRt1zQ-1; Wed, 13 Jan 2021 09:06:19 -0500 X-MC-Unique: 4QuH7xEkPXqvMYbLKRt1zQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1F8E580667A; Wed, 13 Jan 2021 14:06:18 +0000 (UTC) Received: from localhost (ovpn-113-103.ams2.redhat.com [10.36.113.103]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B36E36F976; Wed, 13 Jan 2021 14:06:17 +0000 (UTC) From: Max Reitz To: qemu-block@nongnu.org Subject: [PATCH 0/7] iotests/129: Fix it Date: Wed, 13 Jan 2021 15:06:09 +0100 Message-Id: <20210113140616.150283-1-mreitz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mreitz@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=63.128.21.124; envelope-from=mreitz@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi, There are some problems with iotests 129 (perhaps more than these, but these are the ones I know of): 1. It checks @busy to see whether a block job is still running; however, block jobs tend to unset @busy all the time (when they yield). [Fixed by patch 3] 2. It uses blockdev throttling, which quite some time ago has been moved to the BB level; since then, such throttling will no longer affect block jobs. We can get throttling to work by using a throttle filter node. [Fixed by patch 4] 3. The mirror job has a large buffer size by default. A simple drain may lead to it making significant process, which is kind of dangerous, because we don’t want the job to complete. To get around this, we can simply limit its buffer size. (And we should make the commit job an actual commit job instead of an active commit (which is just mirror), because the commit interface does not allow setting a buffer size.) [Fixed by patches 5 and 6] This series fixes those things, and now 129 seems to reliably pass for me. Apart from the major issues above, there are also minor flaws: - It doesn’t remove the test images. [Fixed by patches 1 and 2] - pylint and mypy complain. (Running mypy with the options given in 297.) [Patch 4 removes one pylint complaint; patch 7 the rest.] Max Reitz (7): iotests: Move try_remove to iotests.py iotests/129: Remove test images in tearDown() iotests/129: Do not check @busy iotests/129: Use throttle node iotests/129: Actually test a commit job iotests/129: Limit mirror job's buffer size iotests/129: Clean up pylint and mypy complaints tests/qemu-iotests/124 | 8 +--- tests/qemu-iotests/129 | 76 ++++++++++++++++++++++------------- tests/qemu-iotests/iotests.py | 11 +++-- 3 files changed, 55 insertions(+), 40 deletions(-)