[v2,0/8] iotests: Fix 129 and expand 297’s reach

Message

Max Reitz Jan. 13, 2021, 5:57 p.m. UTC

v1 cover letter:
https://lists.nongnu.org/archive/html/qemu-block/2021-01/msg00254.html

Hi,

See the cover letter above for the main point of this series (it’s just
that all patch indices are shifted up by one in v2).

In addition to that, I’ve added patch 1 that makes some changes to 297
so it checks all Python files in qemu-iotests/ by default (with an
extensive skip list for now).  With Vladimir’s changes to test naming,
we’ll need to extend this to include files under qemu-iotests/tests/,
but that shouldn’t be a problem.

v2:
- Added patch 1 so 297 checks all Python files in qemu-iotests/ by
  default, skipping “only” files given in an explicit list.  This list
  is extremely long right now, but at least patch 8 makes it one entry
  shorter.

- Patch 5:
  - Use multi-line string concatenation without +
  - Drop block-job-cancel

- Patch 6:
  - Use multi-line string concatenation without +

- Patch 7:
  - Changed the commit message from implying that 'stop' shouldn’t drain
    the block job (it does and it should) to stating that 'stop'
    shouldn’t make the block job try to complete

- Patch 8:
  - Remove 129 from 297’s new skip list


git-backport-diff against v1:

Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch
[down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively

001/8:[down] 'iotests/297: Allow checking all Python test files'
002/8:[----] [--] 'iotests: Move try_remove to iotests.py'
003/8:[----] [--] 'iotests/129: Remove test images in tearDown()'
004/8:[----] [--] 'iotests/129: Do not check @busy'
005/8:[0008] [FC] 'iotests/129: Use throttle node'
006/8:[0002] [FC] 'iotests/129: Actually test a commit job'
007/8:[----] [--] 'iotests/129: Limit mirror job's buffer size'
008/8:[0003] [FC] 'iotests/129: Clean up pylint and mypy complaints'


Max Reitz (8):
  iotests/297: Allow checking all Python test files
  iotests: Move try_remove to iotests.py
  iotests/129: Remove test images in tearDown()
  iotests/129: Do not check @busy
  iotests/129: Use throttle node
  iotests/129: Actually test a commit job
  iotests/129: Limit mirror job's buffer size
  iotests/129: Clean up pylint and mypy complaints

 tests/qemu-iotests/124        |  8 +---
 tests/qemu-iotests/129        | 74 +++++++++++++++++++++--------------
 tests/qemu-iotests/297        | 66 ++++++++++++++++++++++++++++---
 tests/qemu-iotests/297.out    |  7 +++-
 tests/qemu-iotests/iotests.py | 11 ++++--
 5 files changed, 119 insertions(+), 47 deletions(-)