From patchwork Mon Apr 12 04:46:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cleber Rosa X-Patchwork-Id: 12196817 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB106C433ED for ; Mon, 12 Apr 2021 04:48:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2FD30610CA for ; Mon, 12 Apr 2021 04:48:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2FD30610CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46674 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lVoVK-0003Wv-Ai for qemu-devel@archiver.kernel.org; Mon, 12 Apr 2021 00:48:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44820) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVoUC-00022R-Tq for qemu-devel@nongnu.org; Mon, 12 Apr 2021 00:47:44 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:59071) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVoUA-0003b7-8f for qemu-devel@nongnu.org; Mon, 12 Apr 2021 00:47:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618202860; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=NOWzOk061Z/EBRl7BhsvBCjP9eSgSDKtYrWYuI7qnHo=; b=hvj4j4eUb6nTygwNOwVQuvqnsY0BUwlAecP4AOIWKAAFIOTwp8EXPj0bdkmvNOcKBDSCTI 1YQsKCJQohqa0pRMRvY/RqJeEE7DyXPZLAp2EFDpXF29KGarjCiIgfAmW0g9+pzi8J/GcO NNNn8pzOilgp8Vfg7rL3h0YnYHSDtpg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-143-D40-qCktNqW9AUIDnk6Vfg-1; Mon, 12 Apr 2021 00:47:37 -0400 X-MC-Unique: D40-qCktNqW9AUIDnk6Vfg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C6138107ACC7; Mon, 12 Apr 2021 04:47:35 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-113-108.rdu2.redhat.com [10.10.113.108]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8F3BB1037EAF; Mon, 12 Apr 2021 04:46:55 +0000 (UTC) From: Cleber Rosa To: qemu-devel@nongnu.org Subject: [PATCH v3 00/11] Acceptance Test: introduce base class for Linux based tests Date: Mon, 12 Apr 2021 00:46:33 -0400 Message-Id: <20210412044644.55083-1-crosa@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=crosa@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=216.205.24.124; envelope-from=crosa@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Eduardo Habkost , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Wainer dos Santos Moschetta , Willian Rampazzo , John Snow , Willian Rampazzo , Cleber Rosa , =?utf-8?q?Alex_Benn=C3=A9e?= , Aurelien Jarno , Beraldo Leal Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This introduces a base class for tests that need to interact with a Linux guest. It generalizes the "boot_linux.py" code, already been used by the "virtiofs_submounts.py" and also SSH related code being used by that and "linux_ssh_mips_malta.py". While at it, a number of fixes on hopeful improvements to those tests were added. Changes from v2: * Removed type information in docstring on python/qemu/utils.py, as that's already present on the type hints (John Snow) * Reworded commit message about moving ssh-related methods to a auxiliary, mix-in class, and not to the base LinuxTest class (Eric Auger) * Removed unused import of get_info_usernet_hostfwd_port on tests/acceptance/linux_ssh_mips_malta.py (Eric Auger) * Added note on commit message about setUp() method also allowing one to define network device, which is by default, set to virtio-net (Eric Auger) * Kept note about the network device that allows for SSH connections (Wainer Moschetta) * Do not set up an SSH connection on tests that won't be using it (Eric Auger) * Mention the use of a Fedora 31 guest image (Wainer Moschetta) * Fix of SSH pubkey setup on tests/acceptance/virtiofs_submounts.py (new patch, reported by Wainer Moschetta) Changes from v1: * Majority of v1 patches have been merged. * New patches: - Acceptance Tests: make username/password configurable - Acceptance Tests: set up SSH connection by default after boot for LinuxTest - tests/acceptance/virtiofs_submounts.py: remove launch_vm() * Allowed for the configuration of the network device type (defaulting to virtio-net) [Phil] * Fix module name typo (s/qemu.util/qemu.utils/) in the commit message [John] * Tests based on LinuxTest will have the SSH connection already prepared Cleber Rosa (11): tests/acceptance/virtiofs_submounts.py: add missing accel tag tests/acceptance/virtiofs_submounts.py: evaluate string not length Python: add utility function for retrieving port redirection Acceptance Tests: move useful ssh methods to base class Acceptance Tests: add port redirection for ssh by default Acceptance Tests: make username/password configurable Acceptance Tests: set up SSH connection by default after boot for LinuxTest tests/acceptance/virtiofs_submounts.py: remove launch_vm() Acceptance Tests: add basic documentation on LinuxTest base class Acceptance Tests: introduce CPU hotplug test tests/acceptance/virtiofs_submounts.py: fix setup of SSH pubkey docs/devel/testing.rst | 26 +++++++++ python/qemu/utils.py | 33 +++++++++++ tests/acceptance/avocado_qemu/__init__.py | 64 ++++++++++++++++++-- tests/acceptance/boot_linux.py | 18 +++--- tests/acceptance/hotplug_cpu.py | 37 ++++++++++++ tests/acceptance/info_usernet.py | 29 +++++++++ tests/acceptance/linux_ssh_mips_malta.py | 42 +------------- tests/acceptance/virtiofs_submounts.py | 71 +++-------------------- tests/vm/basevm.py | 7 +-- 9 files changed, 206 insertions(+), 121 deletions(-) create mode 100644 python/qemu/utils.py create mode 100644 tests/acceptance/hotplug_cpu.py create mode 100644 tests/acceptance/info_usernet.py