[v2,0/7] virtiofsd: Few cleanups in virtio_send_data_iov()

Message

Vivek Goyal May 18, 2021, 9:35 p.m. UTC

Hi,

This is V2 of the patches. Changes since V1 are.

- Took care of coding style issue.
- Got rid of label "err" completely in last patch. (Dave, Connor). 
- Captured Reviewed-by tags from Connor and David.

Code in virtio_send_data_iov() little twisted and complicated. This
patch series just tries to simplify it a bit to make it little easier
to read this piece of code.

Thanks
Vivek


Vivek Goyal (7):
  virtiofsd: Check for EINTR in preadv() and retry
  virtiofsd: Get rid of unreachable code in read
  virtiofsd: Use iov_discard_front() to skip bytes
  virtiofsd: get rid of in_sg_left variable
  virtiofsd: Simplify skip byte logic
  virtiofsd: Check EOF before short read
  virtiofsd: Set req->reply_sent right after sending reply

 tools/virtiofsd/fuse_virtio.c | 81 +++++++++++------------------------
 1 file changed, 25 insertions(+), 56 deletions(-)

Comments

Dr. David Alan Gilbert May 25, 2021, 6:49 p.m. UTC | #1

* Vivek Goyal ([e-mail]) wrote:
> Hi,
> 
> This is V2 of the patches. Changes since V1 are.
> 
> - Took care of coding style issue.
> - Got rid of label "err" completely in last patch. (Dave, Connor). 
> - Captured Reviewed-by tags from Connor and David.
> 
> Code in virtio_send_data_iov() little twisted and complicated. This
> patch series just tries to simplify it a bit to make it little easier
> to read this piece of code.

Queued

> Thanks
> Vivek
> 
> 
> Vivek Goyal (7):
>   virtiofsd: Check for EINTR in preadv() and retry
>   virtiofsd: Get rid of unreachable code in read
>   virtiofsd: Use iov_discard_front() to skip bytes
>   virtiofsd: get rid of in_sg_left variable
>   virtiofsd: Simplify skip byte logic
>   virtiofsd: Check EOF before short read
>   virtiofsd: Set req->reply_sent right after sending reply
> 
>  tools/virtiofsd/fuse_virtio.c | 81 +++++++++++------------------------
>  1 file changed, 25 insertions(+), 56 deletions(-)
> 
> -- 
> 2.25.4
> 
>