mbox series

[v5,00/13] virtio-gpu: Add support for Blob resources feature (v5)

Message ID 20210519001414.786439-1-vivek.kasireddy@intel.com (mailing list archive)
Headers show
Series virtio-gpu: Add support for Blob resources feature (v5) | expand

Message

Kasireddy, Vivek May 19, 2021, 12:14 a.m. UTC 
Enabling this feature would eliminate data copies from the resource
object in the Guest to the shadow resource in Qemu. This patch series
however adds support only for Blobs of type
VIRTIO_GPU_BLOB_MEM_GUEST with property VIRTIO_GPU_BLOB_FLAG_USE_SHAREABLE.

Most of the patches in this series are a rebased, refactored and bugfixed 
versions of Gerd Hoffmann's patches located here:
https://gitlab.freedesktop.org/virgl/qemu/-/commits/virtio-gpu-next

v2:
- Moved dpy_gl_update from set_scanout to resource_flush
- Dropped the modifier
- Rebase and other minor refactoring

v3:
- Rebased on top of Gerd's virgl device split series
- Split the udmabuf helpers patch from the previous 
  version into two (Gerd)
- Added explicit flush feature (last 7 patches)

v4 (Gerd):
- Dropped explicit flush feature patches from the series
- Slightly refactored udmabuf helpers patch (#3) to introduce
  and use blob and blob_size fields
- Fixed indentation issues and made other small changes in
  set_scanout_blob patch (#12)

v5:
- Rebase (only #6 - Refactor virtio_gpu_create_mapping_iov)

Cc: Gerd Hoffmann <kraxel@redhat.com>

Vivek Kasireddy (13):
  ui: Get the fd associated with udmabuf driver
  headers: Add udmabuf.h
  virtio-gpu: Add udmabuf helpers
  virtio-gpu: Add virtio_gpu_find_check_resource
  virtio-gpu: Refactor virtio_gpu_set_scanout
  virtio-gpu: Refactor virtio_gpu_create_mapping_iov
  virtio-gpu: Add initial definitions for blob resources
  virtio-gpu: Add virtio_gpu_resource_create_blob
  ui/pixman: Add qemu_pixman_to_drm_format()
  virtio-gpu: Add helpers to create and destroy dmabuf objects
  virtio-gpu: Factor out update scanout
  virtio-gpu: Add virtio_gpu_set_scanout_blob
  virtio-gpu: Update cursor data using blob

 hw/display/meson.build                   |   2 +-
 hw/display/trace-events                  |   2 +
 hw/display/virtio-gpu-base.c             |   3 +
 hw/display/virtio-gpu-udmabuf.c          | 255 +++++++++++++
 hw/display/virtio-gpu-virgl.c            |   3 +-
 hw/display/virtio-gpu.c                  | 433 ++++++++++++++++++-----
 include/hw/virtio/virtio-gpu-bswap.h     |  16 +
 include/hw/virtio/virtio-gpu.h           |  39 +-
 include/standard-headers/linux/udmabuf.h |  32 ++
 include/ui/console.h                     |   3 +
 include/ui/qemu-pixman.h                 |   1 +
 scripts/update-linux-headers.sh          |   3 +
 ui/meson.build                           |   1 +
 ui/qemu-pixman.c                         |  35 +-
 ui/udmabuf.c                             |  40 +++
 15 files changed, 758 insertions(+), 110 deletions(-)
 create mode 100644 hw/display/virtio-gpu-udmabuf.c
 create mode 100644 include/standard-headers/linux/udmabuf.h
 create mode 100644 ui/udmabuf.c

Comments

no-reply@patchew.org May 19, 2021, 12:48 a.m. UTC | #1 
Patchew URL: https://patchew.org/QEMU/20210519001414.786439-1-vivek.kasireddy@intel.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210519001414.786439-1-vivek.kasireddy@intel.com
Subject: [PATCH v5 00/13] virtio-gpu: Add support for Blob resources feature (v5)

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20210519001414.786439-1-vivek.kasireddy@intel.com -> patchew/20210519001414.786439-1-vivek.kasireddy@intel.com
Switched to a new branch 'test'
128a9d2 virtio-gpu: Update cursor data using blob
05f9981 virtio-gpu: Add virtio_gpu_set_scanout_blob
e3c9314 virtio-gpu: Factor out update scanout
dbc67f1 virtio-gpu: Add helpers to create and destroy dmabuf objects
9570991 ui/pixman: Add qemu_pixman_to_drm_format()
45da29f virtio-gpu: Add virtio_gpu_resource_create_blob
2f7f18a virtio-gpu: Add initial definitions for blob resources
7e99cae virtio-gpu: Refactor virtio_gpu_create_mapping_iov
321ce3a virtio-gpu: Refactor virtio_gpu_set_scanout
442ec4a virtio-gpu: Add virtio_gpu_find_check_resource
0d66622 virtio-gpu: Add udmabuf helpers
ae69eca headers: Add udmabuf.h
4d7d9e1 ui: Get the fd associated with udmabuf driver

=== OUTPUT BEGIN ===
1/13 Checking commit 4d7d9e1eb3e4 (ui: Get the fd associated with udmabuf driver)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#45: 
new file mode 100644

total: 0 errors, 1 warnings, 54 lines checked

Patch 1/13 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/13 Checking commit ae69eca3ab23 (headers: Add udmabuf.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21: 
new file mode 100644

total: 0 errors, 1 warnings, 53 lines checked

Patch 2/13 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/13 Checking commit 0d66622c5482 (virtio-gpu: Add udmabuf helpers)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#42: 
new file mode 100644

total: 0 errors, 1 warnings, 212 lines checked

Patch 3/13 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/13 Checking commit 442ec4a6a78d (virtio-gpu: Add virtio_gpu_find_check_resource)
5/13 Checking commit 321ce3a6fd5a (virtio-gpu: Refactor virtio_gpu_set_scanout)
6/13 Checking commit 7e99cae8610f (virtio-gpu: Refactor virtio_gpu_create_mapping_iov)
7/13 Checking commit 2f7f18ac97ad (virtio-gpu: Add initial definitions for blob resources)
8/13 Checking commit 45da29ff2830 (virtio-gpu: Add virtio_gpu_resource_create_blob)
9/13 Checking commit 957099133aa4 (ui/pixman: Add qemu_pixman_to_drm_format())
10/13 Checking commit dbc67f12bb53 (virtio-gpu: Add helpers to create and destroy dmabuf objects)
ERROR: code indent should never use tabs
#80: FILE: hw/display/virtio-gpu-udmabuf.c:216:
+^I^I^Inew_primary->buf.width,$

total: 1 errors, 0 warnings, 117 lines checked

Patch 10/13 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

11/13 Checking commit e3c9314bc71a (virtio-gpu: Factor out update scanout)
12/13 Checking commit 05f9981acd94 (virtio-gpu: Add virtio_gpu_set_scanout_blob)
13/13 Checking commit 128a9d200bdc (virtio-gpu: Update cursor data using blob)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210519001414.786439-1-vivek.kasireddy@intel.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com