[0/3] renesas_sci update

Message

Yoshinori Sato June 16, 2021, 9:12 a.m. UTC

Renesas SH/RX have various SCI in serial interface.
The design of sh_serial is old, so I integrate these SCIs with renesas_sci.

Yoshinori Sato (3):
  hw/char: renesas_sci: Refactor for merge all SCI variant..
  hw/char: renesas_sci Add SCI and SCIF support.
  hw/sh4: sh7750 using renesas_sci.

 include/hw/char/renesas_sci.h |  117 +++-
 include/hw/rx/rx62n.h         |    2 +-
 include/hw/sh4/sh.h           |    8 -
 hw/char/renesas_sci.c         | 1053 +++++++++++++++++++++++++++------
 hw/rx/rx62n.c                 |    2 +-
 hw/sh4/sh7750.c               |   41 ++
 hw/sh4/Kconfig                |    2 +-
 7 files changed, 1025 insertions(+), 200 deletions(-)

Comments

[e-mail] June 16, 2021, 9:27 a.m. UTC | #1

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: [e-mail]
Subject: [PATCH 0/3] renesas_sci update

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/[e-mail] -> patchew/[e-mail]
 - [tag update]      patchew/[e-mail] -> patchew/[e-mail]
 - [tag update]      patchew/[e-mail] -> patchew/[e-mail]
 - [tag update]      patchew/[e-mail] -> patchew/[e-mail]
 * [new tag]         patchew/[e-mail] -> patchew/[e-mail]
Switched to a new branch 'test'
2aee00f hw/sh4: sh7750 using renesas_sci.
163b17f hw/char: renesas_sci Add SCI and SCIF support.
3a37650 hw/char: renesas_sci: Refactor for merge all SCI variant..

=== OUTPUT BEGIN ===
1/3 Checking commit 3a3765029d7c (hw/char: renesas_sci: Refactor for merge all SCI variant..)
2/3 Checking commit 163b17f2e78e (hw/char: renesas_sci Add SCI and SCIF support.)
ERROR: spaces required around that ':' (ctx:VxW)
#24: FILE: hw/char/renesas_sci.c:6:
+ *        And SH7751 Group, SH7751R Group User's Manual: Hardware
                                                        ^

ERROR: space prohibited after that '*' (ctx:ExW)
#25: FILE: hw/char/renesas_sci.c:7:
+ *            (Rev.4.01 R01UH0457EJ0401)
  ^

total: 2 errors, 0 warnings, 715 lines checked

Patch 2/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/3 Checking commit 2aee00ffc830 (hw/sh4: sh7750 using renesas_sci.)
ERROR: space required before the open parenthesis '('
#63: FILE: hw/sh4/sh7750.c:770:
+    switch(feat) {

ERROR: braces {} are necessary for all arms of this statement
#79: FILE: hw/sh4/sh7750.c:786:
+    if (tei_source)
[...]

ERROR: braces {} are necessary for all arms of this statement
#81: FILE: hw/sh4/sh7750.c:788:
+    if (bri_source)
[...]

total: 3 errors, 0 warnings, 79 lines checked

Patch 3/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/[e-mail]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [e-mail]