| Message ID | 20220112130332.1648664-1-imammedo@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | acpi: fix short OEM [Table] ID padding | expand |
On Wed, 12 Jan 2022 08:03:28 -0500 Igor Mammedov <imammedo@redhat.com> wrote: > Since 6.0 the commit: > 602b458201 ("acpi: Permit OEM ID and OEM table ID fields to be changed") > regressed values of OEM [Table] ID fields in ACPI tables > by padding them with whitespace is a value is shorter then > max possible. That depending on vendor broke OEM [Table] ID patching > with SLIC table values and as result licensing of Windows guests. > > First reported here https://gitlab.com/qemu-project/qemu/-/issues/707 ping, Michael can you pick it up so that downstreams could backport the fix? > > CC: Marian Postevca <posteuca@mutex.one> > CC: Michael S. Tsirkin <mst@redhat.com> > CC: Ani Sinha <ani@anisinha.ca> > > Igor Mammedov (4): > tests: acpi: manually pad OEM_ID/OEM_TABLE_ID for test_oem_fields() > test > tests: acpi: whitelist nvdimm's SSDT and FACP.slic expected blobs > acpi: fix OEM ID/OEM Table ID padding > tests: acpi: update expected blobs > > hw/acpi/aml-build.c | 4 ++-- > tests/data/acpi/pc/SSDT.dimmpxm | Bin 734 -> 734 bytes > tests/data/acpi/q35/FACP.slic | Bin 244 -> 244 bytes > tests/data/acpi/q35/SSDT.dimmpxm | Bin 734 -> 734 bytes > tests/data/acpi/virt/SSDT.memhp | Bin 736 -> 736 bytes > tests/qtest/bios-tables-test.c | 15 ++++++--------- > 6 files changed, 8 insertions(+), 11 deletions(-) >
On Mon, Jan 31, 2022 at 02:21:56PM +0100, Igor Mammedov wrote: > On Wed, 12 Jan 2022 08:03:28 -0500 > Igor Mammedov <imammedo@redhat.com> wrote: > > > Since 6.0 the commit: > > 602b458201 ("acpi: Permit OEM ID and OEM table ID fields to be changed") > > regressed values of OEM [Table] ID fields in ACPI tables > > by padding them with whitespace is a value is shorter then > > max possible. That depending on vendor broke OEM [Table] ID patching > > with SLIC table values and as result licensing of Windows guests. > > > > First reported here https://gitlab.com/qemu-project/qemu/-/issues/707 > > ping, > Michael can you pick it up so that downstreams could > backport the fix? I see the differences with Ani have been resolved, will be in the next pull. > > > > CC: Marian Postevca <posteuca@mutex.one> > > CC: Michael S. Tsirkin <mst@redhat.com> > > CC: Ani Sinha <ani@anisinha.ca> > > > > Igor Mammedov (4): > > tests: acpi: manually pad OEM_ID/OEM_TABLE_ID for test_oem_fields() > > test > > tests: acpi: whitelist nvdimm's SSDT and FACP.slic expected blobs > > acpi: fix OEM ID/OEM Table ID padding > > tests: acpi: update expected blobs > > > > hw/acpi/aml-build.c | 4 ++-- > > tests/data/acpi/pc/SSDT.dimmpxm | Bin 734 -> 734 bytes > > tests/data/acpi/q35/FACP.slic | Bin 244 -> 244 bytes > > tests/data/acpi/q35/SSDT.dimmpxm | Bin 734 -> 734 bytes > > tests/data/acpi/virt/SSDT.memhp | Bin 736 -> 736 bytes > > tests/qtest/bios-tables-test.c | 15 ++++++--------- > > 6 files changed, 8 insertions(+), 11 deletions(-) > >
Since 6.0 the commit: 602b458201 ("acpi: Permit OEM ID and OEM table ID fields to be changed") regressed values of OEM [Table] ID fields in ACPI tables by padding them with whitespace is a value is shorter then max possible. That depending on vendor broke OEM [Table] ID patching with SLIC table values and as result licensing of Windows guests. First reported here https://gitlab.com/qemu-project/qemu/-/issues/707 CC: Marian Postevca <posteuca@mutex.one> CC: Michael S. Tsirkin <mst@redhat.com> CC: Ani Sinha <ani@anisinha.ca> Igor Mammedov (4): tests: acpi: manually pad OEM_ID/OEM_TABLE_ID for test_oem_fields() test tests: acpi: whitelist nvdimm's SSDT and FACP.slic expected blobs acpi: fix OEM ID/OEM Table ID padding tests: acpi: update expected blobs hw/acpi/aml-build.c | 4 ++-- tests/data/acpi/pc/SSDT.dimmpxm | Bin 734 -> 734 bytes tests/data/acpi/q35/FACP.slic | Bin 244 -> 244 bytes tests/data/acpi/q35/SSDT.dimmpxm | Bin 734 -> 734 bytes tests/data/acpi/virt/SSDT.memhp | Bin 736 -> 736 bytes tests/qtest/bios-tables-test.c | 15 ++++++--------- 6 files changed, 8 insertions(+), 11 deletions(-)