From patchwork Thu Feb 10 14:14:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Sementsov-Ogievskiy X-Patchwork-Id: 12742236 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6BEDDC433F5 for ; Thu, 10 Feb 2022 17:11:42 +0000 (UTC) Received: from localhost ([::1]:39670 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nICyr-00025W-Hm for qemu-devel@archiver.kernel.org; Thu, 10 Feb 2022 12:11:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35734) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nIAWo-0000AN-1A for qemu-devel@nongnu.org; Thu, 10 Feb 2022 09:34:34 -0500 Received: from mail-eopbgr80123.outbound.protection.outlook.com ([40.107.8.123]:23808 helo=EUR04-VI1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nIAWm-00066T-5L for qemu-devel@nongnu.org; Thu, 10 Feb 2022 09:34:33 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CHWBD5nRHt1qyso5xy3N8rcfPHgg8kcWO+BipSQlCdpj8XfvjZLk012qaC9DI8FLPmqDGz6lLgjstrbukz6NAOsWUw6zinsScCowpGvN+0eYFpVS1nRZ79MPDTEeYcBvo66MTdnUCPBCDuvhJAhvBIDOCP/XbiL/ZM5OBxQVGVZA35WGwPPIQTwXczpBamKelPyxw+FSrDk2ZCu/iG7/0TXTR9J74cCkaW1+ubNsMvU0gdedXaExmcbaCSX1KkvFseDqRkZhibF/g5BrWIB4WYx7twN8bMi+UaHeeTm0/pyzoAQtAFsdJUL6045Ah+KRHTAstN4bI82na7IPAPHJqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U5/BSiGlqQJ0fRwRPvtmjzdV44BR5P8M43Z9Ua4i/AM=; b=k/1RF8Xo6Vt1QUNiscYeg9WBlvcUYftM7MyH9YteF3+gLV0O/saf4BL09LaH87baXY1FXzWolSH5xMQ8Ma+v1Pp6dCMU0oqWMIQCMieu4et1bQgCUxcAAKUtU+wEPZeUQddg1bF8ODr1T4xh6TKxprN7EdmqFWCCwxBXZ8hbNPaTWnhNxr9TURDkzuBa2ciWAAPNxqBDwXWTcsZ0jE1Q2hLuuWMQ4oqXZUFK4sa13dBw4xaMYkF66kVwDgnq1G/O9O+NHB4KkoryhfticSQx4JztP82bSy6fWwJYfxRLua6tZy7NKhC4Ea58zuFZofdWUC6lO1TkIoa3V0y/a7Gc7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U5/BSiGlqQJ0fRwRPvtmjzdV44BR5P8M43Z9Ua4i/AM=; b=mqH95xRyyhmjKQC0XfGazLxAKPn/5Yn+6ylXqLCstSsckMAIXkwX/FBFhMyMRg0RwTROkkIEujhMnrPxcgBjQniRqJCJnKaMzPR+KdvIwzsnys//qObwf+VyVo2RgFdNJLKbAa1oIPGpb149E7HD5TYKArAAEkcGJ6jvuBjmyFo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from AM9PR08MB6737.eurprd08.prod.outlook.com (2603:10a6:20b:304::18) by AM7PR08MB5413.eurprd08.prod.outlook.com (2603:10a6:20b:10a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Thu, 10 Feb 2022 14:15:09 +0000 Received: from AM9PR08MB6737.eurprd08.prod.outlook.com ([fe80::49c:67e9:3e24:8714]) by AM9PR08MB6737.eurprd08.prod.outlook.com ([fe80::49c:67e9:3e24:8714%4]) with mapi id 15.20.4975.011; Thu, 10 Feb 2022 14:15:09 +0000 From: Vladimir Sementsov-Ogievskiy To: qemu-devel@nongnu.org Cc: bleal@redhat.com, wainersm@redhat.com, f4bug@amsat.org, crosa@redhat.com, eblake@redhat.com, armbru@redhat.com, kraxel@redhat.com, vsementsov@virtuozzo.com, berrange@redhat.com, marcandre.lureau@redhat.com Subject: [PATCH v4 0/3] qapi/ui: change vnc addresses Date: Thu, 10 Feb 2022 15:14:54 +0100 Message-Id: <20220210141457.539582-1-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.31.1 X-ClientProxiedBy: AM6PR05CA0036.eurprd05.prod.outlook.com (2603:10a6:20b:2e::49) To AM9PR08MB6737.eurprd08.prod.outlook.com (2603:10a6:20b:304::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7f4a7473-a2af-4966-5d7e-08d9ec9fbe7d X-MS-TrafficTypeDiagnostic: AM7PR08MB5413:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3IO7c11k1z/9o1AAE1331pj5Wrl0ww0zTcP4Bm/320rL4t8iOy/CK6VESotTCqeSjUGXBfFoJ3CwLmAck26OnzoPPDPCoNZ0pMaH/NmQzHxQ7FsBZ4eghUkuyoUbdCf8TUrFp3LCR8E9C3Kg+IiAc550I0fNFzQkqlvVj03c32wi0CaC0zMpvSVOfvUvWxb9kUMN0DhU/p9dhibtbAXdxlh6KwgjRhDH1j/BGV6k/8JXu9DDNXbaxY6tjHmFB1RYUqLb5Czx6O25/aItAqmMCw6zBmDIcpIjkr2ZUKsP06e3WcY03KR4Z/Q7rM8Ye6pMnl+1nWpVpI8tU5lNpMFwUrVFtspg2nS348M9Y1a94ySDOWFjaFyRf0T8pAvs1JA+tqJBNHoDpAGpLzmsbrMcvxD0fb1cBHUGviJrJjt8gUw2EdU9DNfFTwjJGRImmd0aUYVh5mZBRlScQsapW0V2uYOvUsPEOcZzfKpuiew7CDu9gYTdq+r47cmWbpNDhm1pSlaohJHN23fuehv3qwSfLAKcXLbSTVCfZNnkZ7Emy7DpyBk+3WF25K93eWovhKoRMpgZks4J6dh8d1yg1Xt9MmsyTRbhX2wOyO30kkbMH+EVMXBBfCfo/l8hwcn20fpHF7PxcrET12Fqj5ECXCj/ZrXjA6636a1pP+ZhrFBpL9sNf/Yj6nJtZxfXUN2vupXuJt0ggdEcumjZhvkAS4Mg7g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM9PR08MB6737.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(26005)(186003)(52116002)(2616005)(2906002)(6506007)(38100700002)(316002)(86362001)(6916009)(38350700002)(66946007)(1076003)(66556008)(66476007)(4326008)(8676002)(5660300002)(8936002)(6486002)(6512007)(83380400001)(7416002)(6666004)(508600001)(36756003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?WkLReOqNkb/QIAo5m6bciisXk8z/?= =?utf-8?q?Rdn8jfzcbt6rjM/KTcSJA4LVepjXqSBmKiJZ+NyapFFjPAEuY4CRZOF4+BfmRhJid?= =?utf-8?q?ggycm5WmtsMy9WCs4r7FwqH1lYUDbF6Sc8bc/z+9BymISBkPDZbveVtwqIpJ+r3pk?= =?utf-8?q?HNIFUSVysC0gB8oWs1LawSq1RlPw2m6moCUJyylyWzzG66qlbuC2sj4AXYEaBv/0Q?= =?utf-8?q?BlWY7v1QUfezSr65QlB2V+zxQa0tBNXRdwuxjSSthuTY8ppp+9eUnMlWEyZssbAVe?= =?utf-8?q?/SaT7zcFnG3Q7wmGha2QW2cQzOI+T8xUeMVKyF+cDXhXglagq1e5n3XvYz9OOLs1J?= =?utf-8?q?G/w7wY0j+KAwexQ8ThcV8G0UTuuL0FUXhqvtchSs7WtJRsC4hXFJAjZBcJ18xHyQf?= =?utf-8?q?9VsW75PoF5CaBPfU6IVLu0rlAf0zTEsXZAj1KQDcp6GbYI0VOC+6+a7+qtQCQ/XX+?= =?utf-8?q?PbmT+PnAzoxOjWcYP5RnWFUYL/d6zoKITAnDutI7GDl2WN4r08ui71rHxJO7I5NF8?= =?utf-8?q?kYGJcAN57+fJoFZO8PFj4/Hn81Ygi0IqAYtGsYWsFIXhG1DDs0PUbZfZCFgbSUtlI?= =?utf-8?q?SgEgnk4vMWXgT67RxDCxPhI3oF8S+ASvqESD7EL+yDMUwJOS3KV0924NvS5SUzBGy?= =?utf-8?q?fsi8f3E28QBWbKTxrkWKPDZwCoFTCr0kQQlFKSkoGGZ4Z3friA69q34VrE4VO5mmB?= =?utf-8?q?7QjavTdxkVWsQWup2LEBs3UY3Xr5ckUdMN8I4nhlY1CPiT5mM7Zlg0pSzg4ynjwvQ?= =?utf-8?q?Ao2P8gXEZbzhGd13SvZJuX5jrffDhKR+crKEYmw5QitjUzRRkac7drUWfXWDa50/2?= =?utf-8?q?gkslgWu3O0RSeEwn2rimNVCcEJPs3AJTCz04e/kR+L7IzmeaLRLa1FwUkiucdnisJ?= =?utf-8?q?D1bP1brpicWcdTHJTJzRfS5s9/gX8SLPmG5YzwSxL1QFRuBPwL2pYtEOBvZBWFs54?= =?utf-8?q?J0akfAW3+KUVzYZ8O6nwRO0WzvGXRKVHcLnUNTMon3I+THu2kdnTXxyfHDK/ZSh7/?= =?utf-8?q?kdTA1JZvL2PbOsKof6P4VoOrmkn5NqC6x6xf0NioLqzs4lgEjh3JimeuZzgF5fTNQ?= =?utf-8?q?d1/rbLvIWJP/BVHiqfmCHms25fNjW/MqDQHG5RU5seNWTVK0pwTm6qXp3YZPjb4r8?= =?utf-8?q?2mSTU7mwZdM6aq9eUWTEgODZP1q+HoPoboHZI6jHybidXEM3LyjASHKwPymG7UvMU?= =?utf-8?q?5pp1NvwPZcPzBGRLi8WxwG9YE5GVM6uKJyAm3g6STv4HaLqfbJJZyvckx9PvltMsh?= =?utf-8?q?enBgfq1CKtMa78/AJdiSOsanBSydvxMVJ8UTy1GWm/CZ9EmBIw2/yDEuLr1a9I6DT?= =?utf-8?q?+hwgM3UD/CeH8BfWFreo7H8Lo4lbAe6e3HuKRq4aXd7mjY5AF7JoJ6BFAXnJUUHtN?= =?utf-8?q?1Izb/GiaN6r4nlMFO9RT5NvgcIEMHihF0bMzm0KPs3u0QcnZA65pEi29WL7qxYjz1?= =?utf-8?q?R3hfSBPjB/qoID2KezuQFSOR5dySzkNIVPelbbmlXZWD4QzsGQa2BHbKuMXvhji3r?= =?utf-8?q?DZc08ku84um/XNIQ04Y1OunKznR8LuAYU6v7EsfWbJIlJVz8gYNR4VHlWcKPy4uMb?= =?utf-8?q?iAC6efluamRZ59sJaoPcgas0lqy9VQTtg=3D=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7f4a7473-a2af-4966-5d7e-08d9ec9fbe7d X-MS-Exchange-CrossTenant-AuthSource: AM9PR08MB6737.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 14:15:09.2446 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DANanRbm+y2y6WvdMhf/Nw5MR53PPhgsDWSC/LiyOZXWF0UEkjwuji18tzXNfD5PH+pUcYFUrowM3E/McX17FziEa+ITfeiDFPSICcJEVjk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5413 Received-SPF: pass client-ip=40.107.8.123; envelope-from=vsementsov@virtuozzo.com; helo=EUR04-VI1-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi all! v4: 01: add Daniel's r-b 02: refactor to add new display-update command instead 03: rebase on 02 search for free ports, using same range as in tests/qemu-iotests/147 check connection on ports Recently our customer requested a possibility to change VNC listen port dynamically. Happily in Rhel7-based Qemu we already have this possibility: through deprecated "change" qmp command. But since 6.0 "change" qmp command was removed, with recommendation to use change-vnc-password or blockdev-change-medium instead. Of course, neither of them allow change VNC listen port. So, let's reimplement the possibility. Vladimir Sementsov-Ogievskiy (3): ui/vnc: refactor arrays of addresses to SocketAddressList qapi/ui: display-update: add possibility to change listen address avocado/vnc: add test_change_listen docs/about/removed-features.rst | 3 +- qapi/ui.json | 65 ++++++++++++++ include/ui/console.h | 1 + monitor/qmp-cmds.c | 15 ++++ ui/vnc.c | 152 ++++++++++++++++---------------- tests/avocado/vnc.py | 63 +++++++++++++ 6 files changed, 220 insertions(+), 79 deletions(-)