From patchwork Fri Mar 25 22:06:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12792096 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F34CBC433F5 for ; Fri, 25 Mar 2022 22:09:15 +0000 (UTC) Received: from localhost ([::1]:42138 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXs7O-00071d-SA for qemu-devel@archiver.kernel.org; Fri, 25 Mar 2022 18:09:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35388) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXs5V-0004Sd-3B for qemu-devel@nongnu.org; Fri, 25 Mar 2022 18:07:17 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:58009) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXs5R-0002kf-By for qemu-devel@nongnu.org; Fri, 25 Mar 2022 18:07:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648246031; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hpqrxgM2SdA25cYOywVh83Cj2OJJweXyRcmQcjphs6k=; b=JLjIzMABSZ5bpKVdE/0OxKq4tyXaLvgD5kunth5qKI7QqQ5x8/+8MIWoeMRYQV5TCxgOJA gwJ1VHDIE7sOy0cGp0AZST56JarcLtqS/va93pWAonCfO/OVAh/F0EDEQKVbwavp4u0C/V WpINypSY4LyxxuMmGo5F6GD8N0XSWeU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-214-4fW72DSLPzudzYWkzJueHA-1; Fri, 25 Mar 2022 18:07:10 -0400 X-MC-Unique: 4fW72DSLPzudzYWkzJueHA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0D4A4802803 for ; Fri, 25 Mar 2022 22:07:10 +0000 (UTC) Received: from tapioca.redhat.com (unknown [10.40.192.95]) by smtp.corp.redhat.com (Postfix) with ESMTP id CC41740C1438; Fri, 25 Mar 2022 22:07:08 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH v2 00/14] Fix some qapi examples and a TODO section Date: Fri, 25 Mar 2022 23:06:53 +0100 Message-Id: <20220325220707.52118-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" I've being using the examples as unit tests and found a few that doesn't work out-of-the-box, might be inteded in order to be less verbose in the qapi documentation but nevertheless I'm sending this out in case you want to cherry-pick them. * Changes in v2: 02/14: qapi: fix example of BLOCK_IMAGE_CORRUPTED event - changed the example to an actual error picked from qemu-iotests/60.out - added recent timestamp :) 03/14: qapi: fix example of BLOCK_IO_ERROR event - use real error message, in this case "No space left on device" 04/14: qapi: fix example of BLOCK_JOB_PENDING event - added an extra space - added recent timestamp 07/14: qapi: fix example of UNPLUG_PRIMARY event - amended commit message 08/14: qapi: fix example of FAILOVER_NEGOTIATED event - fixed syntax for proper document parameter 09/14: qapi: run-state examples: add missing member - fixed commit message 10/14: qapi: run-state examples: add missing timestamp - added chronological timestamps ;) Cheers, Victor Toso (14): qapi: BlockExportRemoveMode: move comments to TODO qapi: fix example of BLOCK_IMAGE_CORRUPTED event qapi: fix example of BLOCK_IO_ERROR event qapi: fix example of BLOCK_JOB_PENDING event qapi: fix example of DUMP_COMPLETED event qapi: fix example of MEMORY_DEVICE_SIZE_CHANGE event qapi: fix example of UNPLUG_PRIMARY event qapi: fix example of FAILOVER_NEGOTIATED event qapi: fix examples: SHUTDOWN and RESET events qapi: run-state examples: add missing timestamp qapi: fix example of MEMORY_FAILURE qapi: ui examples: add missing websocket member qapi: fix example of ACPI_DEVICE_OST event qapi: fix example of dump-guest-memory qapi/acpi.json | 5 +++-- qapi/block-core.json | 14 +++++++------- qapi/block-export.json | 10 +++++----- qapi/dump.json | 9 +++++---- qapi/machine.json | 3 ++- qapi/migration.json | 4 +++- qapi/net.json | 6 ++++-- qapi/run-state.json | 16 +++++++++++----- qapi/ui.json | 12 ++++++------ 9 files changed, 46 insertions(+), 33 deletions(-)