[v3,0/3] qcow2: Improve refcount structure rebuilding

Message

Hanna Czenczek April 5, 2022, 1:46 p.m. UTC

Hi,

v2 cover letter:
https://lists.nongnu.org/archive/html/qemu-block/2022-03/msg01260.html

v1 cover letter:
https://lists.nongnu.org/archive/html/qemu-block/2021-03/msg00651.html

This series fixes the qcow2 refcount structure rebuilding mechanism for
when the qcow2 image file doesn’t allow writes beyond the end of file
(e.g. because it’s on an LVM block device).

v3:
- Added patch 3 (didn’t squash this into patch 1, because (a) Eric gave
  his R-b on 1 as-is, and (b) I ended up retouching
  rebuild_refcount_structure() as a whole, not just the new helper, so a
  dedicated patch made more sense)
- In patch 1: Changed `assert(reftable_size_changed == true)` to just
  `assert(reftable_size_changed)`
- In patch 2: In comments, replaced “were” by “was”


git-backport-diff against v2:

Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch
[down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively

001/3:[0002] [FC] 'qcow2: Improve refcount structure rebuilding'
002/3:[0006] [FC] 'iotests/108: Test new refcount rebuild algorithm'
003/3:[down] 'qcow2: Add errp to rebuild_refcount_structure()'


Hanna Reitz (3):
  qcow2: Improve refcount structure rebuilding
  iotests/108: Test new refcount rebuild algorithm
  qcow2: Add errp to rebuild_refcount_structure()

 block/qcow2-refcount.c     | 353 ++++++++++++++++++++++++++-----------
 tests/qemu-iotests/108     | 259 ++++++++++++++++++++++++++-
 tests/qemu-iotests/108.out |  81 +++++++++
 3 files changed, 587 insertions(+), 106 deletions(-)