| Message ID | 20220412065753.3216538-1-robert.hu@linux.intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | acpi/nvdimm: support NVDIMM _LS{I,R,W} methods | expand |
Ping... On Tue, 2022-04-12 at 14:57 +0800, Robert Hoo wrote: > The original NVDIMM _DSM functions (index 4~6) for label operations > have > been deprecated by new ACPI methods _LS{I,R,W}[1][2]. > > Patch 1 implements the new _LS{I,R,W} methods, on top of old _DSM > implementation. > > Patch 2 fixes some typo of logical and/or with bitwise and/or, though > functionally they haven't causing trouble. > > [1] https://uefi.org/htmlspecs/ACPI_Spec_6_4_html/index.html, 6.5.10 > NVDIMM Label Methods > [2] https://pmem.io/documents/IntelOptanePMem_DSM_Interface-V2.0.pdf, > 3.10 Deprecated Functions > > --- > Resend for previous failed delivery to "qemu-devel@nongnu.org" due to > 550-'Message headers fail syntax check'. > > Robert Hoo (2): > acpi/nvdimm: Create _LS{I,R,W} method for NVDIMM device > acpi/nvdimm: Fix aml_or() and aml_and() in if clause > > hw/acpi/nvdimm.c | 60 +++++++++++++++++++++++++++++++++++++++++++--- > -- > 1 file changed, 54 insertions(+), 6 deletions(-) > > > base-commit: 95a3fcc7487e5bef262e1f937ed8636986764c4e
On Tue, 12 Apr 2022 14:57:51 +0800 Robert Hoo <robert.hu@linux.intel.com> wrote: > The original NVDIMM _DSM functions (index 4~6) for label operations have > been deprecated by new ACPI methods _LS{I,R,W}[1][2]. > > Patch 1 implements the new _LS{I,R,W} methods, on top of old _DSM > implementation. > > Patch 2 fixes some typo of logical and/or with bitwise and/or, though > functionally they haven't causing trouble. generic requirement for ACPI patches, the should pass bios-tables-test (part of 'make check') for that you need to update testcase expected data, see tests/qtest/bios-tables-test.c for the process also see https://www.mail-archive.com/qemu-devel@nongnu.org/msg875304.html for example > > [1] https://uefi.org/htmlspecs/ACPI_Spec_6_4_html/index.html, 6.5.10 NVDIMM Label Methods > [2] https://pmem.io/documents/IntelOptanePMem_DSM_Interface-V2.0.pdf, 3.10 Deprecated Functions > > --- > Resend for previous failed delivery to "qemu-devel@nongnu.org" due to > 550-'Message headers fail syntax check'. > > Robert Hoo (2): > acpi/nvdimm: Create _LS{I,R,W} method for NVDIMM device > acpi/nvdimm: Fix aml_or() and aml_and() in if clause > > hw/acpi/nvdimm.c | 60 +++++++++++++++++++++++++++++++++++++++++++----- > 1 file changed, 54 insertions(+), 6 deletions(-) > > > base-commit: 95a3fcc7487e5bef262e1f937ed8636986764c4e
On Wed, 2022-04-27 at 16:39 +0200, Igor Mammedov wrote: > On Tue, 12 Apr 2022 14:57:51 +0800 > Robert Hoo <robert.hu@linux.intel.com> wrote: > > > The original NVDIMM _DSM functions (index 4~6) for label operations > > have > > been deprecated by new ACPI methods _LS{I,R,W}[1][2]. > > > > Patch 1 implements the new _LS{I,R,W} methods, on top of old _DSM > > implementation. > > > > Patch 2 fixes some typo of logical and/or with bitwise and/or, > > though > > functionally they haven't causing trouble. > > generic requirement for ACPI patches, > the should pass bios-tables-test (part of 'make check') > > for that you need to update testcase expected data, > see tests/qtest/bios-tables-test.c for the process > also see > https://www.mail-archive.com/qemu-devel@nongnu.org/msg875304.html for > example > Got it. Thanks Igor. > > > > [1] https://uefi.org/htmlspecs/ACPI_Spec_6_4_html/index.html, > > 6.5.10 NVDIMM Label Methods > > [2] > > https://pmem.io/documents/IntelOptanePMem_DSM_Interface-V2.0.pdf, > > 3.10 Deprecated Functions > > > > --- > > Resend for previous failed delivery to "qemu-devel@nongnu.org" due > > to > > 550-'Message headers fail syntax check'. > > > > Robert Hoo (2): > > acpi/nvdimm: Create _LS{I,R,W} method for NVDIMM device > > acpi/nvdimm: Fix aml_or() and aml_and() in if clause > > > > hw/acpi/nvdimm.c | 60 +++++++++++++++++++++++++++++++++++++++++++- > > ---- > > 1 file changed, 54 insertions(+), 6 deletions(-) > > > > > > base-commit: 95a3fcc7487e5bef262e1f937ed8636986764c4e > >
The original NVDIMM _DSM functions (index 4~6) for label operations have been deprecated by new ACPI methods _LS{I,R,W}[1][2]. Patch 1 implements the new _LS{I,R,W} methods, on top of old _DSM implementation. Patch 2 fixes some typo of logical and/or with bitwise and/or, though functionally they haven't causing trouble. [1] https://uefi.org/htmlspecs/ACPI_Spec_6_4_html/index.html, 6.5.10 NVDIMM Label Methods [2] https://pmem.io/documents/IntelOptanePMem_DSM_Interface-V2.0.pdf, 3.10 Deprecated Functions --- Resend for previous failed delivery to "qemu-devel@nongnu.org" due to 550-'Message headers fail syntax check'. Robert Hoo (2): acpi/nvdimm: Create _LS{I,R,W} method for NVDIMM device acpi/nvdimm: Fix aml_or() and aml_and() in if clause hw/acpi/nvdimm.c | 60 +++++++++++++++++++++++++++++++++++++++++++----- 1 file changed, 54 insertions(+), 6 deletions(-) base-commit: 95a3fcc7487e5bef262e1f937ed8636986764c4e