[0/4] Revert "main-loop: Disable GLOBAL_STATE_CODE() assertions"

Message

Hanna Czenczek April 27, 2022, 11:40 a.m. UTC

Hi,

This assertion was disabled in commit
b1c073490553f80594b903ceedfc7c1aef6b1b19.  We wanted to re-enable it
once the 7.1 tree has opened (which is now), but to do so, we should
also fix the bug reported in
https://gitlab.com/qemu-project/qemu/-/issues/945 .

Patches 1 and 2 fix that problem (I hope), patch 3 re-enables the
assertion, and patch 4 adds a regression test for issue 945.


Hanna Reitz (4):
  block: Classify bdrv_get_flags() as I/O function
  qcow2: Do not reopen data_file in invalidate_cache
  Revert "main-loop: Disable GLOBAL_STATE_CODE() assertions"
  iotests: Add regression test for issue 945

 include/block/block-global-state.h            |   1 -
 include/block/block-io.h                      |   1 +
 include/qemu/main-loop.h                      |   3 +-
 block.c                                       |   2 +-
 block/qcow2.c                                 | 104 +++++++++++-------
 .../tests/export-incoming-iothread            |  81 ++++++++++++++
 .../tests/export-incoming-iothread.out        |   5 +
 7 files changed, 151 insertions(+), 46 deletions(-)
 create mode 100755 tests/qemu-iotests/tests/export-incoming-iothread
 create mode 100644 tests/qemu-iotests/tests/export-incoming-iothread.out

Comments

Kevin Wolf April 27, 2022, 4:13 p.m. UTC | #1

Am 27.04.2022 um 13:40 hat Hanna Reitz geschrieben:
> Hi,
> 
> This assertion was disabled in commit
> b1c073490553f80594b903ceedfc7c1aef6b1b19.  We wanted to re-enable it
> once the 7.1 tree has opened (which is now), but to do so, we should
> also fix the bug reported in
> https://gitlab.com/qemu-project/qemu/-/issues/945 .
> 
> Patches 1 and 2 fix that problem (I hope), patch 3 re-enables the
> assertion, and patch 4 adds a regression test for issue 945.

Thanks, applied to the block branch.

Kevin