| Message ID | 20220626094656.15673-1-shentey@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Decouple Xen-HVM from PIIX | expand |
Am 26. Juni 2022 09:46:54 UTC schrieb Bernhard Beschow <shentey@gmail.com>: >hw/i386/xen/xen-hvm.c contains logic which is PIIX-specific. This makes xen-hvm.c depend on PIIX which can be avoided if PIIX logic was isolated in PIIX itself. > > > >Bernhard Beschow (2): > > hw/i386/xen/xen-hvm: Allow for stubbing xen_set_pci_link_route() > > hw/i386/xen/xen-hvm: Inline xen_piix_pci_write_config_client() and > > remove it > > > > hw/i386/xen/xen-hvm.c | 17 ++--------------- > > hw/isa/piix3.c | 15 ++++++++++++++- > > include/hw/xen/xen.h | 2 +- > > include/hw/xen/xen_common.h | 6 ------ > > stubs/xen-hw-stub.c | 3 ++- > > 5 files changed, 19 insertions(+), 24 deletions(-) > > > >-- > >2.36.1 > > > Hi Laurent, would you like to queue this as well? Both patches have been reviewed at least once, piix twice. Or would you rather keep the review period open for longer? Best regards, Bernhard
On Tue, 28 Jun 2022, B wrote: > Am 26. Juni 2022 09:46:54 UTC schrieb Bernhard Beschow <shentey@gmail.com>: > >hw/i386/xen/xen-hvm.c contains logic which is PIIX-specific. This makes xen-hvm.c depend on PIIX which can be avoided if PIIX logic was isolated in PIIX itself. > > > > > > > >Bernhard Beschow (2): > > > > hw/i386/xen/xen-hvm: Allow for stubbing xen_set_pci_link_route() > > > > hw/i386/xen/xen-hvm: Inline xen_piix_pci_write_config_client() and > > > > remove it > > > > > > > > hw/i386/xen/xen-hvm.c | 17 ++--------------- > > > > hw/isa/piix3.c | 15 ++++++++++++++- > > > > include/hw/xen/xen.h | 2 +- > > > > include/hw/xen/xen_common.h | 6 ------ > > > > stubs/xen-hw-stub.c | 3 ++- > > > > 5 files changed, 19 insertions(+), 24 deletions(-) > > > > > > > >-- > > >2.36.1 > > > > > > > > Hi Laurent, > > would you like to queue this as well? Both patches have been reviewed at least once, piix twice. Or would you rather keep the review period open for longer? Paul reviewed them both -- I don't think we need further reviews. Laurent could just take them.
hw/i386/xen/xen-hvm.c contains logic which is PIIX-specific. This makes xen-hvm.c depend on PIIX which can be avoided if PIIX logic was isolated in PIIX itself. Bernhard Beschow (2): hw/i386/xen/xen-hvm: Allow for stubbing xen_set_pci_link_route() hw/i386/xen/xen-hvm: Inline xen_piix_pci_write_config_client() and remove it hw/i386/xen/xen-hvm.c | 17 ++--------------- hw/isa/piix3.c | 15 ++++++++++++++- include/hw/xen/xen.h | 2 +- include/hw/xen/xen_common.h | 6 ------ stubs/xen-hw-stub.c | 3 ++- 5 files changed, 19 insertions(+), 24 deletions(-)