| Message ID | 20221007144553.79648-1-miguel.luis@oracle.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | fix for two ACPI GTDT physical addresses | expand |
On Fri, Oct 7, 2022 at 8:16 PM Miguel Luis <miguel.luis@oracle.com> wrote: > > The ACPI GTDT table contains two invalid 64-bit physical addresses according to > the ACPI spec. 6.5 [1]. Those are the Counter Control Base physical address and > the Counter Read Base physical address. Those fields of the GTDT table should be > set to 0xFFFFFFFFFFFFFFFF if not provided, rather than 0x0. > > [1]: https://uefi.org/specs/ACPI/6.5/05_ACPI_Software_Programming_Model.html#gtdt-table-structure > > Changelog: > > v2: > Updated with collected tags from v1. For future reference, there is no need to send out a new version with just the tags added. The tooling make sure that the tags are collected correctly from the last version. > > v1: https://lists.nongnu.org/archive/html/qemu-devel/2022-09/msg02847.html > > Miguel Luis (3): > tests/acpi: virt: allow acpi GTDT changes > acpi: arm/virt: build_gtdt: fix invalid 64-bit physical addresses > tests/acpi: virt: update ACPI GTDT binaries > > hw/arm/virt-acpi-build.c | 5 ++--- > tests/data/acpi/virt/GTDT | Bin 96 -> 96 bytes > tests/data/acpi/virt/GTDT.memhp | Bin 96 -> 96 bytes > tests/data/acpi/virt/GTDT.numamem | Bin 96 -> 96 bytes > 4 files changed, 2 insertions(+), 3 deletions(-) > > -- > 2.37.3 >
> On 7 Oct 2022, at 15:21, Ani Sinha <ani@anisinha.ca> wrote: > > On Fri, Oct 7, 2022 at 8:16 PM Miguel Luis <miguel.luis@oracle.com> wrote: >> >> The ACPI GTDT table contains two invalid 64-bit physical addresses according to >> the ACPI spec. 6.5 [1]. Those are the Counter Control Base physical address and >> the Counter Read Base physical address. Those fields of the GTDT table should be >> set to 0xFFFFFFFFFFFFFFFF if not provided, rather than 0x0. >> >> [1]: https://urldefense.com/v3/__https://uefi.org/specs/ACPI/6.5/05_ACPI_Software_Programming_Model.html*gtdt-table-structure__;Iw!!ACWV5N9M2RV99hQ!I-YqmAwYNhk19YHxcbjQBMwEE9a8rZOvufvOOonAPEtgTynOYOf5AyYKLTTGJ2RRzsjvkjIuleSubpg$ >> >> Changelog: >> >> v2: >> Updated with collected tags from v1. > > For future reference, there is no need to send out a new version with > just the tags added. The tooling make sure that the tags are collected > correctly from the last version. > Great! Thanks for the tip which is very helpful. Miguel >> >> v1: https://urldefense.com/v3/__https://lists.nongnu.org/archive/html/qemu-devel/2022-09/msg02847.html__;!!ACWV5N9M2RV99hQ!I-YqmAwYNhk19YHxcbjQBMwEE9a8rZOvufvOOonAPEtgTynOYOf5AyYKLTTGJ2RRzsjvkjIulSis4m4$ >> >> Miguel Luis (3): >> tests/acpi: virt: allow acpi GTDT changes >> acpi: arm/virt: build_gtdt: fix invalid 64-bit physical addresses >> tests/acpi: virt: update ACPI GTDT binaries >> >> hw/arm/virt-acpi-build.c | 5 ++--- >> tests/data/acpi/virt/GTDT | Bin 96 -> 96 bytes >> tests/data/acpi/virt/GTDT.memhp | Bin 96 -> 96 bytes >> tests/data/acpi/virt/GTDT.numamem | Bin 96 -> 96 bytes >> 4 files changed, 2 insertions(+), 3 deletions(-) >> >> -- >> 2.37.3 >>
The ACPI GTDT table contains two invalid 64-bit physical addresses according to the ACPI spec. 6.5 [1]. Those are the Counter Control Base physical address and the Counter Read Base physical address. Those fields of the GTDT table should be set to 0xFFFFFFFFFFFFFFFF if not provided, rather than 0x0. [1]: https://uefi.org/specs/ACPI/6.5/05_ACPI_Software_Programming_Model.html#gtdt-table-structure Changelog: v2: Updated with collected tags from v1. v1: https://lists.nongnu.org/archive/html/qemu-devel/2022-09/msg02847.html Miguel Luis (3): tests/acpi: virt: allow acpi GTDT changes acpi: arm/virt: build_gtdt: fix invalid 64-bit physical addresses tests/acpi: virt: update ACPI GTDT binaries hw/arm/virt-acpi-build.c | 5 ++--- tests/data/acpi/virt/GTDT | Bin 96 -> 96 bytes tests/data/acpi/virt/GTDT.memhp | Bin 96 -> 96 bytes tests/data/acpi/virt/GTDT.numamem | Bin 96 -> 96 bytes 4 files changed, 2 insertions(+), 3 deletions(-)