From patchwork Tue May 9 09:53:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sergio Lopez X-Patchwork-Id: 13235526 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4DC70C77B75 for ; Tue, 9 May 2023 09:52:52 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pwK1J-0005FA-KW; Tue, 09 May 2023 05:52:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwK1H-0005Ed-Pd for qemu-devel@nongnu.org; Tue, 09 May 2023 05:52:31 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwK1F-0005q5-Rn for qemu-devel@nongnu.org; Tue, 09 May 2023 05:52:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683625948; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+GSum0wfVL8ErLzPEVfATgkcISmXbv7ZPMv1ocg4MVY=; b=T55L3F+h3POLxlUXC2hEK7RbEnJxj94Gg7OYwqibW7Bbs7doWf+/u7g4egS574s9iMHLDM YCy49vdIyJznTMNkPkQgKFxX2qAm5/GPmCJSPhL//iYIvXWjkXVuLKPoUIfW4euPxHYg/k PsL9/zVxBw+DNRInN9o+375Yxp0WckY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-196-PFyvhEZNO1ilJvl9o6YJkw-1; Tue, 09 May 2023 05:52:26 -0400 X-MC-Unique: PFyvhEZNO1ilJvl9o6YJkw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9278E885623; Tue, 9 May 2023 09:52:26 +0000 (UTC) Received: from toolbox.redhat.com (unknown [10.42.28.197]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7DF1963F88; Tue, 9 May 2023 09:52:23 +0000 (UTC) From: Sergio Lopez To: qemu-devel@nongnu.org Cc: Eric Blake , Paolo Bonzini , Pavel Dovgalyuk , =?utf-8?q?Marc-Andr=C3=A9_Lurea?= =?utf-8?q?u?= , Markus Armbruster , Gerd Hoffmann , "Michael S. Tsirkin" , Sergio Lopez Subject: [PATCH v4 0/6] Implement virtio-multitouch and enable GTK3 to use it Date: Tue, 9 May 2023 11:53:39 +0200 Message-Id: <20230509095345.42600-1-slp@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Received-SPF: pass client-ip=170.10.133.124; envelope-from=slp@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org This series adds a virtio-multitouch device to the family of devices emulated by virtio-input implementing the Multi-touch protocol as descripted here: https://www.kernel.org/doc/html/latest/input/multi-touch-protocol.html?highlight=multi+touch It also extends the GTK UI backend to be able to receive multi-touch events and transpose them to a guest, so the latter can recognize them as gestures when appropriate. An example of this in action can be seen here: https://fosstodon.org/@slp/109545849296546767 Since v3: - Use MultiTouch instead of Multitouch and multi-touch instead of multitouch in qapi/ui.json (Markus). - Adopt documentation suggestions by Markus to qapi/ui.json. - Adapt the references to automatically generated structs after the spelling change. Since v2: - Fix InputMultitouchEvent doc in qapi/ui.json (Marc-André). - Use warn_report() instead of fprintf() in gtk.c (Marc-André). - Rebase and collect R-b. Since v1: - Split 0002 patch to implement ui, virtio-input-hid and virtio-input-pci changes in different patches (Marc-André). - Fix versioning in qapi/ui.json (Marc-André). - Print a warning if touch->sequence >= INPUT_EVENT_SLOTS_MAX (Marc-André). - Only send SYN_REPORT once, if needed (Marc-André). - Rebase and collect R-b. Sergio Lopez (6): virtio-input: generalize virtio_input_key_config() ui: add the infrastructure to support MT events virtio-input: add a virtio-mulitouch device virtio-input-pci: add virtio-multitouch-pci ui: add helpers for virtio-multitouch events ui/gtk: enable backend to send multi-touch events hw/input/virtio-input-hid.c | 156 +++++++++++++++++++++++++++---- hw/virtio/virtio-input-pci.c | 25 ++++- include/hw/virtio/virtio-input.h | 9 +- include/ui/input.h | 8 ++ qapi/ui.json | 58 ++++++++++-- replay/replay-input.c | 18 ++++ ui/gtk.c | 92 ++++++++++++++++++ ui/input.c | 42 +++++++++ ui/trace-events | 1 + 9 files changed, 372 insertions(+), 37 deletions(-)