mbox series

[v2,0/2] qemu-img: fix getting stuck in infinite loop on in-chain rebase

Message ID 20230525180213.902012-1-andrey.drobyshev@virtuozzo.com (mailing list archive)
Headers show
Series qemu-img: fix getting stuck in infinite loop on in-chain rebase | expand

Message

Andrey Drobyshev May 25, 2023, 6:02 p.m. UTC
v1 -> v2:

  * Avoid breaking the loop just yet, as the offsets beyond the old
    backing size need to be explicitly zeroed;
  * Amend the commit message accordingly;
  * Alter the added test case to take the last zeroed cluster into
    consideration.

v1: https://lists.nongnu.org/archive/html/qemu-block/2023-05/msg00674.html

Andrey Drobyshev (2):
  qemu-img: rebase: stop when reaching EOF of old backing file
  qemu-iotests: 024: add rebasing test case for overlay_size >
    backing_size

 qemu-img.c                 | 13 ++++++++-
 tests/qemu-iotests/024     | 57 ++++++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/024.out | 30 ++++++++++++++++++++
 3 files changed, 99 insertions(+), 1 deletion(-)

Comments

Andrey Drobyshev June 1, 2023, 8:54 p.m. UTC | #1
On 5/25/23 21:02, Andrey Drobyshev wrote:
> v1 -> v2:
> 
>   * Avoid breaking the loop just yet, as the offsets beyond the old
>     backing size need to be explicitly zeroed;
>   * Amend the commit message accordingly;
>   * Alter the added test case to take the last zeroed cluster into
>     consideration.
> 
> v1: https://lists.nongnu.org/archive/html/qemu-block/2023-05/msg00674.html
> 
> Andrey Drobyshev (2):
>   qemu-img: rebase: stop when reaching EOF of old backing file
>   qemu-iotests: 024: add rebasing test case for overlay_size >
>     backing_size
> 
>  qemu-img.c                 | 13 ++++++++-
>  tests/qemu-iotests/024     | 57 ++++++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/024.out | 30 ++++++++++++++++++++
>  3 files changed, 99 insertions(+), 1 deletion(-)
> 

Since there're no comments so far, I've included this same bugfix into
the bigger series regarding "qemu-img rebase".  Please refer to
https://lists.nongnu.org/archive/html/qemu-block/2023-06/msg00068.html.