From patchwork Wed Jun 7 14:54:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Erico Nunes X-Patchwork-Id: 13270821 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC12CC7EE25 for ; Wed, 7 Jun 2023 14:56:27 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q6uZ2-0002qV-MW; Wed, 07 Jun 2023 10:55:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6uZ1-0002pv-Af for qemu-devel@nongnu.org; Wed, 07 Jun 2023 10:55:07 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6uYy-0001E5-PC for qemu-devel@nongnu.org; Wed, 07 Jun 2023 10:55:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686149703; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=aPPe1I8tabzgciGvQuxIGHu8FxB953o4NxNVOYn32z0=; b=Ocvgg7ZlCcqN5Qzo4xYBYqIoRvTJvtjTOaAo88HsSqTO5L6ld1vDw0dA1FoCBHANl15/e0 MCG2O5z+dQk/QTDE0Am/B5iPqSvybs0tI587h8yBC0gkwxIMFXruBKy6e+ZrbcOaTtCD+1 vgy9iNBllT+zajt0f6AesvxetRH5It4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-539-lrVtdeuMNF-v5g1i8U_WXw-1; Wed, 07 Jun 2023 10:55:01 -0400 X-MC-Unique: lrVtdeuMNF-v5g1i8U_WXw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A7529811E8D for ; Wed, 7 Jun 2023 14:55:01 +0000 (UTC) Received: from centennial.enunes.eu.com (unknown [10.45.227.17]) by smtp.corp.redhat.com (Postfix) with ESMTP id BB7FB403362; Wed, 7 Jun 2023 14:55:00 +0000 (UTC) From: Erico Nunes To: qemu-devel@nongnu.org Cc: marcandre.lureau@redhat.com, mst@redhat.com, kraxel@redhat.com, Erico Nunes Subject: [PATCH v3 0/4] vhost-user-gpu get_edid feature Date: Wed, 7 Jun 2023 16:54:51 +0200 Message-Id: <20230607145455.158267-1-ernunes@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 Received-SPF: pass client-ip=170.10.129.124; envelope-from=ernunes@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org This adds support to the virtio-gpu get_edid command in qemu as the frontend as well as the vhost-user-gpu implementation in contrib/. So far, qemu has been outputting the following message: EDID requested but the backend doesn't support it. when using that implementation. This is tested with vhost-user-gpu, the dbus ui backend and the monitor-edid application, which now shows complete "QEMU Monitor" edid data. The VHOST_USER_GPU_PROTOCOL_F_EDID protocol feature is required if the frontend sets the VIRTIO_GPU_F_EDID virtio-gpu feature. If the frontend sets the virtio-gpu feature but does not support the protocol feature, the backend will abort with an error. v2 -> v3: - Fixed review comments from v2. Missing struct documentation and setting feature bits to be compatible with the frontend. Erico Nunes (4): virtio-gpu: refactor generate_edid function to virtio_gpu_base docs: vhost-user-gpu: add protocol changes for EDID contrib/vhost-user-gpu: implement get_edid feature vhost-user-gpu: implement get_edid frontend feature contrib/vhost-user-gpu/vhost-user-gpu.c | 73 +++++++++++++++++++++++-- contrib/vhost-user-gpu/virgl.c | 3 + contrib/vhost-user-gpu/vugpu.h | 11 ++++ docs/interop/vhost-user-gpu.rst | 28 +++++++++- hw/display/vhost-user-gpu.c | 36 ++++++++++++ hw/display/virtio-gpu-base.c | 17 ++++++ hw/display/virtio-gpu.c | 20 +------ include/hw/virtio/virtio-gpu.h | 2 + 8 files changed, 162 insertions(+), 28 deletions(-) Reviewed-by: Marc-André Lureau