From patchwork Thu Jul 20 18:14:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Eugenio Perez Martin X-Patchwork-Id: 13320950 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78ADCEB64DA for ; Thu, 20 Jul 2023 18:16:36 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qMYBj-00053Z-IZ; Thu, 20 Jul 2023 14:15:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMYBO-0004KL-RC for qemu-devel@nongnu.org; Thu, 20 Jul 2023 14:15:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMYBM-0003Gy-It for qemu-devel@nongnu.org; Thu, 20 Jul 2023 14:15:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689876909; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5Tl7/y4tm1U21k3a2j51YzVThWNUiYwfs1PxNKmVHYA=; b=Tp6swRPjUkR6+NE3EdkxqgETkKb++KqofC3++s86Kk01ItLBjYstychYlL4DBcv8MdNrsv DtcVIzAIp1XL7TCuBNeRO3nwoZ2uMH7qhT79KxaTpBQq7At3qjbqUs4QLkwsvOa6cDr/G4 hX2rFB7e8KIe2SL3r8SO8/d9rgSSR8c= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-160-n7_ah0rlMRWkoJtFQphQ1w-1; Thu, 20 Jul 2023 14:15:03 -0400 X-MC-Unique: n7_ah0rlMRWkoJtFQphQ1w-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 500F8185A78B; Thu, 20 Jul 2023 18:15:03 +0000 (UTC) Received: from eperezma.remote.csb (unknown [10.39.193.122]) by smtp.corp.redhat.com (Postfix) with ESMTP id CB6F32166B25; Thu, 20 Jul 2023 18:15:01 +0000 (UTC) From: =?utf-8?q?Eugenio_P=C3=A9rez?= To: qemu-devel@nongnu.org Cc: yvugenfi@redhat.com, =?utf-8?q?Eugenio_P=C3=A9rez?= , si-wei.liu@oracle.com, Jason Wang , "Michael S. Tsirkin" , Dragos Tatulea , Shannon Nelson Subject: [RFC PATCH 00/12] Prefer to use SVQ to stall dataplane at NIC state restore through CVQ Date: Thu, 20 Jul 2023 20:14:47 +0200 Message-Id: <20230720181459.607008-1-eperezma@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 Received-SPF: pass client-ip=170.10.133.124; envelope-from=eperezma@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org At this moment the migration of net features that depends on CVQ is not possible, as there is no reliable way to restore the device state like mac address, number of enabled queues, etc to the destination. This is mainly caused because the device must only read CVQ, and process all the commands before resuming the dataplane. This series uses the VirtIO feature _F_RING_RESET to achieve it, adding an alternative method to late vq enabling proposed in [1][2]. It expose SVQ to the device until it process all the CVQ messages, and then replaces the vring for the guest's one. As an advantage, it uses a feature well deviced in the VirtIO standard. As a disadvantage, current HW already support the late enabling and it does not support RING_RESET. This patch must be applied on top of the series ("Enable vdpa net migration with features depending on CVQ") [1][2]. The patch has been tested with vp_vdpa, but using high IOVA instead of a sepparated ID for shadow CVQ and shadow temporal vrings. [1] Message-id: <20230706191227.835526-1-eperezma@redhat.com> [2] https://lists.nongnu.org/archive/html/qemu-devel/2023-07/msg01325.html Eugenio Pérez (12): vhost: add vhost_reset_queue_op vhost: add vhost_restart_queue_op vhost_net: Use ops->vhost_restart_queue in vhost_net_virtqueue_restart vhost_net: Use ops->vhost_reset_queue in vhost_net_virtqueue_reset vdpa: add vhost_vdpa_set_vring_ready_internal vdpa: add vhost_vdpa_svq_stop vdpa: add vhost_vdpa_reset_queue vdpa: add vhost_vdpa_svq_start vdpa: add vhost_vdpa_restart_queue vdpa: enable all vqs if the device support RING_RESET feature vdpa: use SVQ to stall dataplane while NIC state is being restored vhost: Allow _F_RING_RESET with shadow virtqueue include/hw/virtio/vhost-backend.h | 6 ++ hw/net/vhost_net.c | 16 ++-- hw/virtio/vhost-shadow-virtqueue.c | 1 + hw/virtio/vhost-vdpa.c | 139 +++++++++++++++++++++-------- net/vhost-vdpa.c | 55 ++++++++++-- hw/virtio/trace-events | 2 +- 6 files changed, 171 insertions(+), 48 deletions(-)