| Message ID | 20231013092143.365296-1-f.ebner@proxmox.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | mirror: allow switching from background to active mode | expand |
Fiona Ebner <f.ebner@proxmox.com> writes: > Changes in v3: > * unlock the job mutex when calling the new block job driver > 'query' handler > * squash patch adapting iotest output into patch that changes the > output > * turn accesses to copy_mode and actively_synced atomic > * slightly rework error handling in mirror_change > > Changes in v2: > * move bitmap to filter which allows to avoid draining when > changing the copy mode > * add patch to determine copy_to_target only once > * drop patches returning redundant information upon query > * update QEMU version in QAPI > * update indentation in QAPI > * update indentation in QAPI (like in a937b6aa73 ("qapi: Reformat > doc comments to conform to current conventions")) > * add patch to adapt iotest output > > Discussion of v2: > https://lists.nongnu.org/archive/html/qemu-devel/2023-10/msg02290.html > > Discussion of v1: > https://lists.nongnu.org/archive/html/qemu-devel/2023-02/msg07216.html > > With active mode, the guest write speed is limited by the synchronous > writes to the mirror target. For this reason, management applications > might want to start out in background mode and only switch to active > mode later, when certain conditions are met. This series adds a > block-job-change QMP command to achieve that, as well as > job-type-specific information when querying block jobs, which > can be used to decide when the switch should happen. > > For now, only the direction background -> active is supported. > > The information added upon querying is whether the target is actively > synced, the total data sent, and the remaining dirty bytes. > > Initially, I tried to go for a more general 'job-change' command, but > to avoid mutual inclusion of block-core.json and job.json, more > preparation would be required. Can you elaborate a bit? A more generic command is preferable, and we need to understand what it would take.
Am 18.10.23 um 11:41 schrieb Markus Armbruster: > Fiona Ebner <f.ebner@proxmox.com> writes: >> >> Initially, I tried to go for a more general 'job-change' command, but >> to avoid mutual inclusion of block-core.json and job.json, more >> preparation would be required. > > Can you elaborate a bit? A more generic command is preferable, and we > need to understand what it would take. > Yes, I did so during the discussion of v2: https://lists.nongnu.org/archive/html/qemu-devel/2023-10/msg02993.html Best Regards, Fiona
Am 13.10.2023 um 11:21 hat Fiona Ebner geschrieben: > Changes in v3: > * unlock the job mutex when calling the new block job driver > 'query' handler > * squash patch adapting iotest output into patch that changes the > output > * turn accesses to copy_mode and actively_synced atomic > * slightly rework error handling in mirror_change > > Changes in v2: > * move bitmap to filter which allows to avoid draining when > changing the copy mode > * add patch to determine copy_to_target only once > * drop patches returning redundant information upon query > * update QEMU version in QAPI > * update indentation in QAPI > * update indentation in QAPI (like in a937b6aa73 ("qapi: Reformat > doc comments to conform to current conventions")) > * add patch to adapt iotest output > > Discussion of v2: > https://lists.nongnu.org/archive/html/qemu-devel/2023-10/msg02290.html > > Discussion of v1: > https://lists.nongnu.org/archive/html/qemu-devel/2023-02/msg07216.html > > With active mode, the guest write speed is limited by the synchronous > writes to the mirror target. For this reason, management applications > might want to start out in background mode and only switch to active > mode later, when certain conditions are met. This series adds a > block-job-change QMP command to achieve that, as well as > job-type-specific information when querying block jobs, which > can be used to decide when the switch should happen. > > For now, only the direction background -> active is supported. > > The information added upon querying is whether the target is actively > synced, the total data sent, and the remaining dirty bytes. Most of this series looks good to me. Apart from the comments I made in the individual patches, I would like to see iotests coverage of changing the mirroring mode. At the least to show that the query result changes, but ideally also that requests really block after switchting to active. I think with a throttled target node and immediately reading the target when the write request completes we should be able to check this. Kevin
Am 19.10.23 um 15:36 schrieb Kevin Wolf: > Most of this series looks good to me. Apart from the comments I made in > the individual patches, I would like to see iotests coverage of changing > the mirroring mode. At the least to show that the query result changes, > but ideally also that requests really block after switchting to active. > I think with a throttled target node and immediately reading the target > when the write request completes we should be able to check this. > I'll try to work something out for v4. Best Regards, Fiona
Am 23.10.23 um 13:39 schrieb Fiona Ebner: > Am 19.10.23 um 15:36 schrieb Kevin Wolf: >> Most of this series looks good to me. Apart from the comments I made in >> the individual patches, I would like to see iotests coverage of changing >> the mirroring mode. At the least to show that the query result changes, >> but ideally also that requests really block after switchting to active. >> I think with a throttled target node and immediately reading the target >> when the write request completes we should be able to check this. >> > > I'll try to work something out for v4. > I'm having a bit of a hard time unfortunately. I created a throttle group with > 'iops-total': iops, > 'iops-total-max': iops and used that for the 'throttle' driver for the target. I then tried issuing requests via qemu_io > self.vm.hmp_qemu_io('mirror-top', > f'aio_write -P 1 {req_size * i} {req_size * (i + 1)}') but when I create more requests than the 'iops' limit (to ensure that not all are completed immediately), it will get stuck when draining the temporary BlockBackend used by qemu_io [0]. Note this is while still in background mode. I also wanted to have request going on while the copy mode is changed and for that, I was able to work around the issue by creating an NBD export of the source like in iotest 151 and issuing the requests to the NBD socket instead. But after I switch to active mode and when I issue more than the 'iops' limit requests to the NBD export then, it also seems to get stuck, visible during shutdown when it tries to close the export[1]. Happy about any hints/suggestions :) Best Regards, Fiona [0]: > Thread 4 (Thread 0x7f0101f876c0 (LWP 46638) "qemu-system-x86"): > #0 0x00007f010decbc02 in __GI___sigtimedwait (set=set@entry=0x7f0101f822e0, info=info@entry=0x7f0101f82210, timeout=timeout@entry=0x0) at ../sysdeps/unix/sysv/linux/sigtimedwait.c:31 > #1 0x00007f010decb31c in __GI___sigwait (set=0x7f0101f822e0, sig=0x7f0101f822d0) at ../sysdeps/unix/sysv/linux/sigwait.c:28 > #2 0x00005612182e2c96 in dummy_cpu_thread_fn (arg=0x561219892a90) at ../accel/dummy-cpus.c:50 > #3 0x0000561218729f03 in qemu_thread_start (args=0x56121989bc80) at ../util/qemu-thread-posix.c:541 > #4 0x00007f010df18044 in start_thread (arg=<optimized out>) at ./nptl/pthread_create.c:442 > #5 0x00007f010df9861c in clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:81 > > Thread 3 (Thread 0x7f01027886c0 (LWP 46637) "qemu-system-x86"): > #0 0x00007f010df8b05f in __GI___poll (fds=0x7f00f4003320, nfds=3, timeout=-1) at ../sysdeps/unix/sysv/linux/poll.c:29 > #1 0x00007f010f2009ae in () at /lib/x86_64-linux-gnu/libglib-2.0.so.0 > #2 0x00007f010f200cef in g_main_loop_run () at /lib/x86_64-linux-gnu/libglib-2.0.so.0 > #3 0x000056121856b683 in iothread_run (opaque=0x5612194df940) at ../iothread.c:70 > #4 0x0000561218729f03 in qemu_thread_start (args=0x56121955c1d0) at ../util/qemu-thread-posix.c:541 > #5 0x00007f010df18044 in start_thread (arg=<optimized out>) at ./nptl/pthread_create.c:442 > #6 0x00007f010df9861c in clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:81 > > Thread 2 (Thread 0x7f010308a6c0 (LWP 46636) "qemu-system-x86"): > #0 syscall () at ../sysdeps/unix/sysv/linux/x86_64/syscall.S:38 > #1 0x0000561218729b69 in qemu_futex_wait (f=0x561219185498 <rcu_call_ready_event>, val=4294967295) at /home/febner/repos/qemu/include/qemu/futex.h:29 > #2 0x0000561218729d50 in qemu_event_wait (ev=0x561219185498 <rcu_call_ready_event>) at ../util/qemu-thread-posix.c:464 > #3 0x0000561218737107 in call_rcu_thread (opaque=0x0) at ../util/rcu.c:278 > #4 0x0000561218729f03 in qemu_thread_start (args=0x5612194c35b0) at ../util/qemu-thread-posix.c:541 > #5 0x00007f010df18044 in start_thread (arg=<optimized out>) at ./nptl/pthread_create.c:442 > #6 0x00007f010df9861c in clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:81 > > Thread 1 (Thread 0x7f01031f81c0 (LWP 46635) "qemu-system-x86"): > #0 0x00007f010df8b156 in __ppoll (fds=0x561219fe4060, nfds=1, timeout=<optimized out>, sigmask=0x0) at ../sysdeps/unix/sysv/linux/ppoll.c:42 > #1 0x000056121874808e in qemu_poll_ns (fds=0x561219fe4060, nfds=1, timeout=62500000) at ../util/qemu-timer.c:351 > #2 0x00005612187252f4 in fdmon_poll_wait (ctx=0x56121955e540, ready_list=0x7ffe4c596330, timeout=62500000) at ../util/fdmon-poll.c:79 > #3 0x0000561218724c30 in aio_poll (ctx=0x56121955e540, blocking=true) at ../util/aio-posix.c:670 > #4 0x00005612185b614f in bdrv_do_drained_begin (bs=0x5612198b9da0, parent=0x0, poll=true) at ../block/io.c:399 > #5 0x00005612185b626b in bdrv_drained_begin (bs=0x5612198b9da0) at ../block/io.c:412 > #6 0x00005612185a7277 in blk_drain (blk=0x56121a22abd0) at ../block/block-backend.c:2086 > #7 0x00005612185a3bdf in blk_unref (blk=0x56121a22abd0) at ../block/block-backend.c:553 > #8 0x000056121824f7e2 in hmp_qemu_io (mon=0x7ffe4c596630, qdict=0x5612198c0410) at ../block/monitor/block-hmp-cmds.c:621 > #9 0x00005612182b7224 in handle_hmp_command_exec (mon=0x7ffe4c596630, cmd=0x561219099a00 <hmp_cmds+6080>, qdict=0x5612198c0410) at ../monitor/hmp.c:1106 > #10 0x00005612182b7451 in handle_hmp_command (mon=0x7ffe4c596630, cmdline=0x56121a0dfbc8 "mirror-top \"aio_write -P 1 8192 8704\"") at ../monitor/hmp.c:1158 > #11 0x00005612182b8a3e in qmp_human_monitor_command (command_line=0x56121a0dfbc0 "qemu-io mirror-top \"aio_write -P 1 8192 8704\"", has_cpu_index=false, cpu_index=0, errp=0x7ffe4c596740) at ../monitor/qmp-cmds.c:182 > #12 0x00005612186d12e6 in qmp_marshal_human_monitor_command (args=0x7f00f4005e70, ret=0x7f0102889d98, errp=0x7f0102889d90) at qapi/qapi-commands-misc.c:347 > #13 0x00005612187171d2 in do_qmp_dispatch_bh (opaque=0x7f0102889e30) at ../qapi/qmp-dispatch.c:128 > #14 0x0000561218741b1b in aio_bh_call (bh=0x56121a3cf2c0) at ../util/async.c:169 > #15 0x0000561218741c36 in aio_bh_poll (ctx=0x56121955e540) at ../util/async.c:216 > #16 0x00005612187244da in aio_dispatch (ctx=0x56121955e540) at ../util/aio-posix.c:423 > #17 0x0000561218742075 in aio_ctx_dispatch (source=0x56121955e540, callback=0x0, user_data=0x0) at ../util/async.c:358 > #18 0x00007f010f2007a9 in g_main_context_dispatch () at /lib/x86_64-linux-gnu/libglib-2.0.so.0 > #19 0x0000561218743830 in glib_pollfds_poll () at ../util/main-loop.c:290 > #20 0x00005612187438ad in os_host_main_loop_wait (timeout=0) at ../util/main-loop.c:313 > #21 0x00005612187439bb in main_loop_wait (nonblocking=0) at ../util/main-loop.c:592 > #22 0x00005612182610e7 in qemu_main_loop () at ../system/runstate.c:782 > #23 0x000056121851ab0e in qemu_default_main () at ../system/main.c:37 > #24 0x000056121851ab49 in main (argc=20, argv=0x7ffe4c596b68) at ../system/main.c:48 [1]: Note there's also threads 6-18 which are also worker threads with a similar backtrace as thread 5. > Thread 5 (Thread 0x7f867ffff6c0 (LWP 48159) "qemu-system-x86"): > #0 __futex_abstimed_wait_common64 (private=0, cancel=true, abstime=0x7f867fffa300, op=393, expected=0, futex_word=0x562994eef7a8) at ./nptl/futex-internal.c:57 > #1 __futex_abstimed_wait_common (futex_word=futex_word@entry=0x562994eef7a8, expected=expected@entry=0, clockid=clockid@entry=0, abstime=abstime@entry=0x7f867fffa300, private=private@entry=0, cancel=cancel@entry=true) at ./nptl/futex-internal.c:87 > #2 0x00007f86aa314e0b in __GI___futex_abstimed_wait_cancelable64 (futex_word=futex_word@entry=0x562994eef7a8, expected=expected@entry=0, clockid=clockid@entry=0, abstime=abstime@entry=0x7f867fffa300, private=private@entry=0) at ./nptl/futex-internal.c:139 > #3 0x00007f86aa31774c in __pthread_cond_wait_common (abstime=0x7f867fffa300, clockid=0, mutex=0x562994eef710, cond=0x562994eef780) at ./nptl/pthread_cond_wait.c:503 > #4 ___pthread_cond_timedwait64 (cond=0x562994eef780, mutex=0x562994eef710, abstime=0x7f867fffa300) at ./nptl/pthread_cond_wait.c:643 > #5 0x000056299413676e in qemu_cond_timedwait_ts (cond=0x562994eef780, mutex=0x562994eef710, ts=0x7f867fffa300, file=0x562994412d1d "../util/thread-pool.c", line=90) at ../util/qemu-thread-posix.c:239 > #6 0x0000562994136809 in qemu_cond_timedwait_impl (cond=0x562994eef780, mutex=0x562994eef710, ms=10000, file=0x562994412d1d "../util/thread-pool.c", line=90) at ../util/qemu-thread-posix.c:253 > #7 0x00005629941538ac in worker_thread (opaque=0x562994eef700) at ../util/thread-pool.c:90 > #8 0x0000562994136f03 in qemu_thread_start (args=0x562995710f80) at ../util/qemu-thread-posix.c:541 > #9 0x00007f86aa318044 in start_thread (arg=<optimized out>) at ./nptl/pthread_create.c:442 > #10 0x00007f86aa39861c in clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:81 > > Thread 4 (Thread 0x7f869e3c66c0 (LWP 48157) "qemu-system-x86"): > #0 0x00007f86aa2cbc02 in __GI___sigtimedwait (set=set@entry=0x7f869e3c12e0, info=info@entry=0x7f869e3c1210, timeout=timeout@entry=0x0) at ../sysdeps/unix/sysv/linux/sigtimedwait.c:31 > #1 0x00007f86aa2cb31c in __GI___sigwait (set=0x7f869e3c12e0, sig=0x7f869e3c12d0) at ../sysdeps/unix/sysv/linux/sigwait.c:28 > #2 0x0000562993cefc96 in dummy_cpu_thread_fn (arg=0x5629951f7a90) at ../accel/dummy-cpus.c:50 > #3 0x0000562994136f03 in qemu_thread_start (args=0x562995200c80) at ../util/qemu-thread-posix.c:541 > #4 0x00007f86aa318044 in start_thread (arg=<optimized out>) at ./nptl/pthread_create.c:442 > #5 0x00007f86aa39861c in clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:81 > > Thread 3 (Thread 0x7f869ebc76c0 (LWP 48156) "qemu-system-x86"): > #0 0x00007f86aa38b05f in __GI___poll (fds=0x7f8690003320, nfds=2, timeout=-1) at ../sysdeps/unix/sysv/linux/poll.c:29 > #1 0x00007f86ab63f9ae in () at /lib/x86_64-linux-gnu/libglib-2.0.so.0 > #2 0x00007f86ab63fcef in g_main_loop_run () at /lib/x86_64-linux-gnu/libglib-2.0.so.0 > #3 0x0000562993f78683 in iothread_run (opaque=0x562994e44940) at ../iothread.c:70 > #4 0x0000562994136f03 in qemu_thread_start (args=0x562994ec11d0) at ../util/qemu-thread-posix.c:541 > #5 0x00007f86aa318044 in start_thread (arg=<optimized out>) at ./nptl/pthread_create.c:442 > #6 0x00007f86aa39861c in clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:81 > > Thread 2 (Thread 0x7f869f4c96c0 (LWP 48155) "qemu-system-x86"): > #0 syscall () at ../sysdeps/unix/sysv/linux/x86_64/syscall.S:38 > #1 0x0000562994136b69 in qemu_futex_wait (f=0x562994b92498 <rcu_call_ready_event>, val=4294967295) at /home/febner/repos/qemu/include/qemu/futex.h:29 > #2 0x0000562994136d50 in qemu_event_wait (ev=0x562994b92498 <rcu_call_ready_event>) at ../util/qemu-thread-posix.c:464 > #3 0x0000562994144107 in call_rcu_thread (opaque=0x0) at ../util/rcu.c:278 > #4 0x0000562994136f03 in qemu_thread_start (args=0x562994e285b0) at ../util/qemu-thread-posix.c:541 > #5 0x00007f86aa318044 in start_thread (arg=<optimized out>) at ./nptl/pthread_create.c:442 > #6 0x00007f86aa39861c in clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:81 > > Thread 1 (Thread 0x7f869f6371c0 (LWP 48154) "qemu-system-x86"): > #0 0x00007f86aa38b156 in __ppoll (fds=0x562994e3b260, nfds=1, timeout=<optimized out>, sigmask=0x0) at ../sysdeps/unix/sysv/linux/ppoll.c:42 > #1 0x000056299415508e in qemu_poll_ns (fds=0x562994e3b260, nfds=1, timeout=62500000) at ../util/qemu-timer.c:351 > #2 0x00005629941322f4 in fdmon_poll_wait (ctx=0x562994ec3540, ready_list=0x7fffe1a38d20, timeout=62500000) at ../util/fdmon-poll.c:79 > #3 0x0000562994131c30 in aio_poll (ctx=0x562994ec3540, blocking=true) at ../util/aio-posix.c:670 > #4 0x0000562993f6a48b in blk_exp_close_all_type (type=BLOCK_EXPORT_TYPE__MAX) at ../block/export/export.c:315 > #5 0x0000562993f6a4ba in blk_exp_close_all () at ../block/export/export.c:320 > #6 0x0000562993c6e26b in qemu_cleanup (status=0) at ../system/runstate.c:853 > #7 0x0000562993f27b1b in qemu_default_main () at ../system/main.c:38 > #8 0x0000562993f27b49 in main (argc=20, argv=0x7fffe1a38f48) at ../system/main.c:48
Am 25.10.2023 um 14:27 hat Fiona Ebner geschrieben: > Am 23.10.23 um 13:39 schrieb Fiona Ebner: > > Am 19.10.23 um 15:36 schrieb Kevin Wolf: > >> Most of this series looks good to me. Apart from the comments I made in > >> the individual patches, I would like to see iotests coverage of changing > >> the mirroring mode. At the least to show that the query result changes, > >> but ideally also that requests really block after switchting to active. > >> I think with a throttled target node and immediately reading the target > >> when the write request completes we should be able to check this. > >> > > > > I'll try to work something out for v4. > > > > I'm having a bit of a hard time unfortunately. I created a throttle > group with > > > 'iops-total': iops, > > 'iops-total-max': iops I would have throttled only writes, because you need to do a read to check the target and don't want that one to be throttled until the writes have completed. > and used that for the 'throttle' driver for the target. I then tried > issuing requests via qemu_io > > > self.vm.hmp_qemu_io('mirror-top', > > f'aio_write -P 1 {req_size * i} {req_size * (i + 1)}') > > but when I create more requests than the 'iops' limit (to ensure that > not all are completed immediately), it will get stuck when draining the > temporary BlockBackend used by qemu_io [0]. Note this is while still in > background mode. You should be able to get around this by using an existing named BlockBackend (created with -drive if=none) instead of a node name. mirror-top stays at the root of the tree, right? > I also wanted to have request going on while the copy mode is changed > and for that, I was able to work around the issue by creating an NBD > export of the source like in iotest 151 and issuing the requests to the > NBD socket instead. > > But after I switch to active mode and when I issue more than the 'iops' > limit requests to the NBD export then, it also seems to get stuck, > visible during shutdown when it tries to close the export[1]. Because the NBD server still throttles the I/O that needs to complete until QEMU can shut down? If this is a problem, I suppose you can lift the limit on the NBD server side if you use QSD. graph-changes-while-io is an example of a test cases that uses QSD. Kevin
Fiona Ebner <f.ebner@proxmox.com> writes: > Am 18.10.23 um 11:41 schrieb Markus Armbruster: >> Fiona Ebner <f.ebner@proxmox.com> writes: >>> >>> Initially, I tried to go for a more general 'job-change' command, but >>> to avoid mutual inclusion of block-core.json and job.json, more >>> preparation would be required. >> >> Can you elaborate a bit? A more generic command is preferable, and we >> need to understand what it would take. >> > > Yes, I did so during the discussion of v2: > > https://lists.nongnu.org/archive/html/qemu-devel/2023-10/msg02993.html Replied there. Sorry for the delay!
Changes in v3: * unlock the job mutex when calling the new block job driver 'query' handler * squash patch adapting iotest output into patch that changes the output * turn accesses to copy_mode and actively_synced atomic * slightly rework error handling in mirror_change Changes in v2: * move bitmap to filter which allows to avoid draining when changing the copy mode * add patch to determine copy_to_target only once * drop patches returning redundant information upon query * update QEMU version in QAPI * update indentation in QAPI * update indentation in QAPI (like in a937b6aa73 ("qapi: Reformat doc comments to conform to current conventions")) * add patch to adapt iotest output Discussion of v2: https://lists.nongnu.org/archive/html/qemu-devel/2023-10/msg02290.html Discussion of v1: https://lists.nongnu.org/archive/html/qemu-devel/2023-02/msg07216.html With active mode, the guest write speed is limited by the synchronous writes to the mirror target. For this reason, management applications might want to start out in background mode and only switch to active mode later, when certain conditions are met. This series adds a block-job-change QMP command to achieve that, as well as job-type-specific information when querying block jobs, which can be used to decide when the switch should happen. For now, only the direction background -> active is supported. The information added upon querying is whether the target is actively synced, the total data sent, and the remaining dirty bytes. Initially, I tried to go for a more general 'job-change' command, but to avoid mutual inclusion of block-core.json and job.json, more preparation would be required. Fiona Ebner (9): blockjob: introduce block-job-change QMP command block/mirror: set actively_synced even after the job is ready block/mirror: move dirty bitmap to filter block/mirror: determine copy_to_target only once mirror: implement mirror_change method qapi/block-core: use JobType for BlockJobInfo's type qapi/block-core: turn BlockJobInfo into a union blockjob: query driver-specific info via a new 'query' driver method mirror: return mirror-specific information upon query block/mirror.c | 111 ++++++++++++++++++++++----------- block/monitor/block-hmp-cmds.c | 4 +- blockdev.c | 14 +++++ blockjob.c | 28 ++++++++- include/block/blockjob.h | 11 ++++ include/block/blockjob_int.h | 10 +++ job.c | 1 + qapi/block-core.json | 59 +++++++++++++++++- qapi/job.json | 4 +- tests/qemu-iotests/109.out | 24 +++---- 10 files changed, 212 insertions(+), 54 deletions(-)