[0/3] block: Make snapshots fail gracefully on inactive images

Message

Kevin Wolf Dec. 1, 2023, 2:25 p.m. UTC

Kevin Wolf (3):
  block: Fix crash when loading snapshot on inactive node
  vl: Improve error message for conflicting -incoming and -loadvm
  iotests: Basic tests for internal snapshots

 block/snapshot.c                              |   4 +-
 system/vl.c                                   |   4 +
 .../tests/qcow2-internal-snapshots            | 170 ++++++++++++++++++
 .../tests/qcow2-internal-snapshots.out        | 107 +++++++++++
 4 files changed, 284 insertions(+), 1 deletion(-)
 create mode 100755 tests/qemu-iotests/tests/qcow2-internal-snapshots
 create mode 100644 tests/qemu-iotests/tests/qcow2-internal-snapshots.out

Comments

Michael Tokarev Dec. 22, 2023, 7:24 p.m. UTC | #1

01.12.2023 17:25, Kevin Wolf :
> Kevin Wolf (3):
>    block: Fix crash when loading snapshot on inactive node
>    vl: Improve error message for conflicting -incoming and -loadvm
>    iotests: Basic tests for internal snapshots

This smells like a stable-8.2 material, at least the first change
(tho I'd pick all 3).  Maybe stable-8.1 too.

On the other hand, this is a rarely-used code path.

Thanks,

/mjt

Kevin Wolf Jan. 9, 2024, 11:01 a.m. UTC | #2

Am 22.12.2023 um 20:24 hat Michael Tokarev geschrieben:
> 01.12.2023 17:25, Kevin Wolf :
> > Kevin Wolf (3):
> >    block: Fix crash when loading snapshot on inactive node
> >    vl: Improve error message for conflicting -incoming and -loadvm
> >    iotests: Basic tests for internal snapshots
> 
> This smells like a stable-8.2 material, at least the first change
> (tho I'd pick all 3).  Maybe stable-8.1 too.

Yes, makes sense to me. It was a bit late for 8.2.0, but adding it to a
future stable release is reasonable.

> On the other hand, this is a rarely-used code path.

It is, but if you do hit it, it's still a crash.

Kevin