mbox series

[v3,0/6] migration removals & deprecations

Message ID 20240430142737.29066-1-farosas@suse.de (mailing list archive)
Headers show
Series migration removals & deprecations | expand

Message

Fabiano Rosas April 30, 2024, 2:27 p.m. UTC 
since v2:

- removed some more stuff which I missed:
   blk/inc options from hmp-commands.hx
   the entire ram-compress.h
   unused declarations from options.h
   unused compression functions from qemu-file.c

- removed must_remove_block_options earlier in the 'blk' patch

- added a deprecation warning to outgoing/incoming fd

CI run: https://gitlab.com/farosas/qemu/-/pipelines/1272385260

v2:
https://lore.kernel.org/r/20240426131408.25410-1-farosas@suse.de
v1:
https://lore.kernel.org/r/20240425150939.19268-1-farosas@suse.de

Hi everyone,

Here's some cleaning up of deprecated code. It removes the old block
migration and compression code. Both have suitable replacements in the
form of the blockdev-mirror driver and multifd compression,
respectively.

There's also a deprecation for fd: + file to cope with the fact that
the new MigrationAddress API defines transports instead of protocols
(loose terms) like the old string API did. So we cannot map 1:1 from
fd: to any transport because fd: allows *both* file migration and
socket migration.

Fabiano Rosas (6):
  migration: Remove 'skipped' field from MigrationStats
  migration: Remove 'inc' option from migrate command
  migration: Remove 'blk/-b' option from migrate commands
  migration: Remove block migration
  migration: Remove non-multifd compression
  migration: Deprecate fd: for file migration

 .gitlab-ci.d/buildtest.yml       |    2 +-
 MAINTAINERS                      |    1 -
 docs/about/deprecated.rst        |   51 +-
 docs/about/removed-features.rst  |  103 +++
 docs/devel/migration/main.rst    |    2 +-
 hmp-commands.hx                  |   17 +-
 hw/core/machine.c                |    1 -
 include/migration/misc.h         |    6 -
 meson.build                      |    2 -
 meson_options.txt                |    2 -
 migration/block.c                | 1019 ------------------------------
 migration/block.h                |   52 --
 migration/colo.c                 |    1 -
 migration/fd.c                   |   12 +
 migration/meson.build            |    4 -
 migration/migration-hmp-cmds.c   |   97 +--
 migration/migration.c            |   70 +-
 migration/migration.h            |   11 -
 migration/options.c              |  229 -------
 migration/options.h              |   13 -
 migration/qemu-file.c            |   78 ---
 migration/qemu-file.h            |    4 -
 migration/ram-compress.c         |  564 -----------------
 migration/ram-compress.h         |   77 ---
 migration/ram.c                  |  169 +----
 migration/savevm.c               |    5 -
 qapi/migration.json              |  205 +-----
 scripts/meson-buildoptions.sh    |    4 -
 tests/qemu-iotests/183           |  147 -----
 tests/qemu-iotests/183.out       |   66 --
 tests/qemu-iotests/common.filter |    7 -
 tests/qtest/migration-test.c     |  139 ----
 32 files changed, 147 insertions(+), 3013 deletions(-)
 delete mode 100644 migration/block.c
 delete mode 100644 migration/block.h
 delete mode 100644 migration/ram-compress.c
 delete mode 100644 migration/ram-compress.h
 delete mode 100755 tests/qemu-iotests/183
 delete mode 100644 tests/qemu-iotests/183.out


base-commit: fd87be1dada5672f877e03c2ca8504458292c479

Comments

Peter Xu May 1, 2024, 3:53 p.m. UTC | #1 
On Tue, Apr 30, 2024 at 11:27:31AM -0300, Fabiano Rosas wrote:
> since v2:
> 
> - removed some more stuff which I missed:
>    blk/inc options from hmp-commands.hx
>    the entire ram-compress.h
>    unused declarations from options.h
>    unused compression functions from qemu-file.c
> 
> - removed must_remove_block_options earlier in the 'blk' patch
> 
> - added a deprecation warning to outgoing/incoming fd
> 
> CI run: https://gitlab.com/farosas/qemu/-/pipelines/1272385260
> 
> v2:
> https://lore.kernel.org/r/20240426131408.25410-1-farosas@suse.de
> v1:
> https://lore.kernel.org/r/20240425150939.19268-1-farosas@suse.de
> 
> Hi everyone,
> 
> Here's some cleaning up of deprecated code. It removes the old block
> migration and compression code. Both have suitable replacements in the
> form of the blockdev-mirror driver and multifd compression,
> respectively.
> 
> There's also a deprecation for fd: + file to cope with the fact that
> the new MigrationAddress API defines transports instead of protocols
> (loose terms) like the old string API did. So we cannot map 1:1 from
> fd: to any transport because fd: allows *both* file migration and
> socket migration.
> 
> Fabiano Rosas (6):
>   migration: Remove 'skipped' field from MigrationStats
>   migration: Remove 'inc' option from migrate command
>   migration: Remove 'blk/-b' option from migrate commands
>   migration: Remove block migration
>   migration: Remove non-multifd compression
>   migration: Deprecate fd: for file migration

Reviewed-by: Peter Xu <peterx@redhat.com>