| Message ID | 20240625121843.120035-1-vsementsov@yandex-team.ru (mailing list archive) |
|---|---|
| Headers | show |
| Series | vhost-user-blk: live resize additional APIs | expand |
I have no issues with these APIs, but I'm not a QMP expert so others should review those bits. For the vhost-user-blk code: Acked-by: Raphael Norwitz <raphael@enfabrica.net> On Tue, Jun 25, 2024 at 8:19 AM Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> wrote: > > v5: > 03: drop extra check on is is runstate running > > > Vladimir Sementsov-Ogievskiy (3): > qdev-monitor: add option to report GenericError from find_device_state > vhost-user-blk: split vhost_user_blk_sync_config() > qapi: introduce device-sync-config > > hw/block/vhost-user-blk.c | 27 ++++++++++++++------ > hw/virtio/virtio-pci.c | 9 +++++++ > include/hw/qdev-core.h | 3 +++ > qapi/qdev.json | 24 ++++++++++++++++++ > system/qdev-monitor.c | 53 ++++++++++++++++++++++++++++++++++++--- > 5 files changed, 105 insertions(+), 11 deletions(-) > > -- > 2.34.1 >
On Mon, Jul 01, 2024 at 08:42:39AM -0400, Raphael Norwitz wrote: > I have no issues with these APIs, but I'm not a QMP expert so others > should review those bits. > > For the vhost-user-blk code: > > Acked-by: Raphael Norwitz <raphael@enfabrica.net> Could the relevant bits get ack from qapi maintainers please? > On Tue, Jun 25, 2024 at 8:19 AM Vladimir Sementsov-Ogievskiy > <vsementsov@yandex-team.ru> wrote: > > > > v5: > > 03: drop extra check on is is runstate running > > > > > > Vladimir Sementsov-Ogievskiy (3): > > qdev-monitor: add option to report GenericError from find_device_state > > vhost-user-blk: split vhost_user_blk_sync_config() > > qapi: introduce device-sync-config > > > > hw/block/vhost-user-blk.c | 27 ++++++++++++++------ > > hw/virtio/virtio-pci.c | 9 +++++++ > > include/hw/qdev-core.h | 3 +++ > > qapi/qdev.json | 24 ++++++++++++++++++ > > system/qdev-monitor.c | 53 ++++++++++++++++++++++++++++++++++++--- > > 5 files changed, 105 insertions(+), 11 deletions(-) > > > > -- > > 2.34.1 > >
ping. Markus, Eric, could someone give an ACC for QAPI part? On 25.06.24 15:18, Vladimir Sementsov-Ogievskiy wrote: > v5: > 03: drop extra check on is is runstate running > > > Vladimir Sementsov-Ogievskiy (3): > qdev-monitor: add option to report GenericError from find_device_state > vhost-user-blk: split vhost_user_blk_sync_config() > qapi: introduce device-sync-config > > hw/block/vhost-user-blk.c | 27 ++++++++++++++------ > hw/virtio/virtio-pci.c | 9 +++++++ > include/hw/qdev-core.h | 3 +++ > qapi/qdev.json | 24 ++++++++++++++++++ > system/qdev-monitor.c | 53 ++++++++++++++++++++++++++++++++++++--- > 5 files changed, 105 insertions(+), 11 deletions(-) >
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> writes:
> ping. Markus, Eric, could someone give an ACC for QAPI part?
I apologize for the delay. It was pretty bad.
On 18.07.24 11:31, Markus Armbruster wrote: > Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> writes: > >> ping. Markus, Eric, could someone give an ACC for QAPI part? > > I apologize for the delay. It was pretty bad. > No problem, I myself make worse delays now when busy with other work, thanks for reviewing!
On 01.07.24 23:55, Michael S. Tsirkin wrote: > On Mon, Jul 01, 2024 at 08:42:39AM -0400, Raphael Norwitz wrote: >> I have no issues with these APIs, but I'm not a QMP expert so others >> should review those bits. >> >> For the vhost-user-blk code: >> >> Acked-by: Raphael Norwitz <raphael@enfabrica.net> > > Could the relevant bits get ack from qapi maintainers please? > We go them. Could you queue the patches please? > > >> On Tue, Jun 25, 2024 at 8:19 AM Vladimir Sementsov-Ogievskiy >> <vsementsov@yandex-team.ru> wrote: >>> >>> v5: >>> 03: drop extra check on is is runstate running >>> >>> >>> Vladimir Sementsov-Ogievskiy (3): >>> qdev-monitor: add option to report GenericError from find_device_state >>> vhost-user-blk: split vhost_user_blk_sync_config() >>> qapi: introduce device-sync-config >>> >>> hw/block/vhost-user-blk.c | 27 ++++++++++++++------ >>> hw/virtio/virtio-pci.c | 9 +++++++ >>> include/hw/qdev-core.h | 3 +++ >>> qapi/qdev.json | 24 ++++++++++++++++++ >>> system/qdev-monitor.c | 53 ++++++++++++++++++++++++++++++++++++--- >>> 5 files changed, 105 insertions(+), 11 deletions(-) >>> >>> -- >>> 2.34.1 >>> >
On Thu, Aug 01, 2024 at 11:35:19AM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 01.07.24 23:55, Michael S. Tsirkin wrote: > > On Mon, Jul 01, 2024 at 08:42:39AM -0400, Raphael Norwitz wrote: > > > I have no issues with these APIs, but I'm not a QMP expert so others > > > should review those bits. > > > > > > For the vhost-user-blk code: > > > > > > Acked-by: Raphael Norwitz <raphael@enfabrica.net> > > > > Could the relevant bits get ack from qapi maintainers please? > > > > We go them. Could you queue the patches please? Tagged for after the freeze. Thanks! > > > > > > > On Tue, Jun 25, 2024 at 8:19 AM Vladimir Sementsov-Ogievskiy > > > <vsementsov@yandex-team.ru> wrote: > > > > > > > > v5: > > > > 03: drop extra check on is is runstate running > > > > > > > > > > > > Vladimir Sementsov-Ogievskiy (3): > > > > qdev-monitor: add option to report GenericError from find_device_state > > > > vhost-user-blk: split vhost_user_blk_sync_config() > > > > qapi: introduce device-sync-config > > > > > > > > hw/block/vhost-user-blk.c | 27 ++++++++++++++------ > > > > hw/virtio/virtio-pci.c | 9 +++++++ > > > > include/hw/qdev-core.h | 3 +++ > > > > qapi/qdev.json | 24 ++++++++++++++++++ > > > > system/qdev-monitor.c | 53 ++++++++++++++++++++++++++++++++++++--- > > > > 5 files changed, 105 insertions(+), 11 deletions(-) > > > > > > > > -- > > > > 2.34.1 > > > > > > > > -- > Best regards, > Vladimir
On 01.08.24 11:37, Michael S. Tsirkin wrote: > On Thu, Aug 01, 2024 at 11:35:19AM +0300, Vladimir Sementsov-Ogievskiy wrote: >> On 01.07.24 23:55, Michael S. Tsirkin wrote: >>> On Mon, Jul 01, 2024 at 08:42:39AM -0400, Raphael Norwitz wrote: >>>> I have no issues with these APIs, but I'm not a QMP expert so others >>>> should review those bits. >>>> >>>> For the vhost-user-blk code: >>>> >>>> Acked-by: Raphael Norwitz <raphael@enfabrica.net> >>> >>> Could the relevant bits get ack from qapi maintainers please? >>> >> >> We go them. Could you queue the patches please? > > > Tagged for after the freeze. Thanks! Oh right, I missed the freeze. OK, thanks! > >>> >>> >>>> On Tue, Jun 25, 2024 at 8:19 AM Vladimir Sementsov-Ogievskiy >>>> <vsementsov@yandex-team.ru> wrote: >>>>> >>>>> v5: >>>>> 03: drop extra check on is is runstate running >>>>> >>>>> >>>>> Vladimir Sementsov-Ogievskiy (3): >>>>> qdev-monitor: add option to report GenericError from find_device_state >>>>> vhost-user-blk: split vhost_user_blk_sync_config() >>>>> qapi: introduce device-sync-config >>>>> >>>>> hw/block/vhost-user-blk.c | 27 ++++++++++++++------ >>>>> hw/virtio/virtio-pci.c | 9 +++++++ >>>>> include/hw/qdev-core.h | 3 +++ >>>>> qapi/qdev.json | 24 ++++++++++++++++++ >>>>> system/qdev-monitor.c | 53 ++++++++++++++++++++++++++++++++++++--- >>>>> 5 files changed, 105 insertions(+), 11 deletions(-) >>>>> >>>>> -- >>>>> 2.34.1 >>>>> >>> >> >> -- >> Best regards, >> Vladimir >
On Tue, Jun 25, 2024 at 03:18:40PM +0300, Vladimir Sementsov-Ogievskiy wrote: > v5: > 03: drop extra check on is is runstate running Causes build failures when generating qdoc. https://gitlab.com/mstredhat/qemu/-/jobs/7792086965 > > Vladimir Sementsov-Ogievskiy (3): > qdev-monitor: add option to report GenericError from find_device_state > vhost-user-blk: split vhost_user_blk_sync_config() > qapi: introduce device-sync-config > > hw/block/vhost-user-blk.c | 27 ++++++++++++++------ > hw/virtio/virtio-pci.c | 9 +++++++ > include/hw/qdev-core.h | 3 +++ > qapi/qdev.json | 24 ++++++++++++++++++ > system/qdev-monitor.c | 53 ++++++++++++++++++++++++++++++++++++--- > 5 files changed, 105 insertions(+), 11 deletions(-) > > -- > 2.34.1
On 11.09.24 12:51, Michael S. Tsirkin wrote: > On Tue, Jun 25, 2024 at 03:18:40PM +0300, Vladimir Sementsov-Ogievskiy wrote: >> v5: >> 03: drop extra check on is is runstate running > > Causes build failures when generating qdoc. > > https://gitlab.com/mstredhat/qemu/-/jobs/7792086965 > > Sorry for a delay, I'll send a v6 soon with fix for that.