From patchwork Mon Jul 22 13:16:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= X-Patchwork-Id: 13738836 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1E32C3DA5D for ; Mon, 22 Jul 2024 13:17:46 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sVsuU-00005i-Sg; Mon, 22 Jul 2024 09:17:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sVsuC-0008SZ-1n for qemu-devel@nongnu.org; Mon, 22 Jul 2024 09:16:51 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sVsu9-0007b4-1K for qemu-devel@nongnu.org; Mon, 22 Jul 2024 09:16:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721654199; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=r+lf4BKlaqOUAJje5KJcFHJEKO0xqQXydsQGnXm+5Oc=; b=R8fF7R397bQnGz9PAxFVPv3RC9PHNgGIfxk6klSqhTqbr6faCwq8ELDEocKcfxoFAYp4Cg d84gMJA7jT1O/KP2GqUn82y8CjY2gb3RjRXFtJofRTU2EJMjgBjgLxqYVzo+vG0hFL0CJD HkxhBfaB2sGPzJqoA0qrmxY9Qcc9Bm0= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-553-3NMUIjgSP5-Z_lyZNv5f6w-1; Mon, 22 Jul 2024 09:16:37 -0400 X-MC-Unique: 3NMUIjgSP5-Z_lyZNv5f6w-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 63AE5191041D; Mon, 22 Jul 2024 13:16:36 +0000 (UTC) Received: from toolbox.redhat.com (unknown [10.42.28.102]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0EC3E1955DC9; Mon, 22 Jul 2024 13:16:12 +0000 (UTC) From: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= To: qemu-devel@nongnu.org Cc: Michael Roth , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Marc?= =?utf-8?q?-Andr=C3=A9_Lureau?= , Markus Armbruster , Paolo Bonzini Subject: [PATCH 0/5] crypto: improve error reporting detail Date: Mon, 22 Jul 2024 14:16:06 +0100 Message-ID: <20240722131611.2820041-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.133, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org This small series came about after struggling to diagnose some problems with TLS, due to unhelpfully generic error messages. Daniel P. Berrangé (5): qapi: allow for g_autoptr(Error) usage chardev: add tracing of socket error conditions crypto: drop gnutls debug logging support crypto: push error reporting into TLS session I/O APIs crypto: propagate errors from TLS session I/O callbacks chardev/char-socket.c | 34 +++++---- chardev/trace-events | 10 +++ crypto/init.c | 11 --- crypto/tlssession.c | 110 ++++++++++++++++++++-------- include/crypto/tlssession.h | 33 +++++++-- include/qapi/error.h | 2 + io/channel-tls.c | 62 +++++++--------- tests/unit/test-crypto-tlssession.c | 28 ++++++- 8 files changed, 189 insertions(+), 101 deletions(-)